Debian Bug report logs - #21400
/usr/lib/dpkg/methods/disk/setup outputs junk

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Richard Kettlewell <rjk@greenend.org.uk>

To: submit@bugs.debian.org

Subject: /usr/lib/dpkg/methods/disk/setup outputs junk

Date: Sun, 19 Apr 98 16:49:23 +0100 (BST)

Package: dpkg
Version: 1.4.0.21

When setting up the access method in dselect, I got the following
output:

    Enter _main_ binary dir. [/myrddin-anon/debian/development/binary-i386]
     ?  /opt/debian/hamm/hamm/binary-i386
    /usr/lib/dpkg//methods/disk/setup: line 8: 23226 Broken pipe             find "$mountpoint$2" -follow -name '*.deb' -print 2>/dev/null
	 23227 Done                    | head -1
	 23228 Done                    | grep . >/dev/null
    Using `/opt/debian/hamm/hamm/binary-i386' as main binary dir.
    Using `/opt/debian/hamm/hamm/binary-i386/Packages.gz' for main.

The following patch to /usr/lib/dpkg/methods/disk/setup solves this,
and also makes the code somewhat more transparent (assuming I've
deduced the intended function correctly):

--- setup.orig	Sun Apr 19 16:37:49 1998
+++ setup	Sun Apr 19 16:43:03 1998
@@ -429,8 +429,8 @@
 		echo "\`$2' does not exist."
 		return
 	fi
-	if ! find "$mountpoint$2" -follow -name '*.deb' -print \
-		2>/dev/null | head -1 | grep . >/dev/null
+	find "$mountpoint$2" -follow -name '*.deb' -print >$tp.d 2>/dev/null
+	if [ ! -s $tp.d ]
 	then
 		echo "\`$2' does not contain any *.deb packages.  Hmmpf."
 		return

ttfn/rjk

Message #14 received at 21400@bugs.debian.org (full text, mbox, reply):

From: Bruce Sass <bmsass@shaw.ca>

To: 21400@bugs.debian.org

Subject: this bug is obsolete

Date: Mon, 04 Sep 2006 05:13:27 -0600

[runs dselect, chooses "access method" -> "disk", no "Distribution top 
level"]

---
Enter _main_ binary dir. []
 ?  /var/cache/apt-build/repository
Using `/var/cache/apt-build/repository' as main binary dir.
Using `/var/cache/apt-build/repository/Packages.gz' for main.
---

I am using Unstable (1.13.22), but the exact same code exists in Stable 
(1.10.28). See: src/dpkg-1.10.28/methods/disk.setup and 
src/dpkg-1.13.22/dselect/methods/disk.

It looks like this 8+ year old bug was fixed without trying at some 
point and should be closed.


- Bruce

Message #19 received at 21400@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>

To: Bruce Sass <bmsass@shaw.ca>, 21400@bugs.debian.org

Subject: Re: Bug#21400: this bug is obsolete

Date: Mon, 4 Sep 2006 23:00:27 +0200

[Message part 1 (text/plain, inline)]

> It looks like this 8+ year old bug was fixed without trying at some 
> point and should be closed.


Well, you're the one who spotted this, so I would say that if you're
sure of this, noone will deprive you from the pleasure of closing a 8+
years old bug...:)

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.