Debian Bug report logs - #28412
libpng2: libpng 1.0.2 broken for some files

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: <e2od5@tower.physik.uni-halle.de>

To: submit@bugs.debian.org

Subject: libpng2: libpng 1.0.2 broken for some files

Date: Thu, 22 Oct 1998 22:47:35 +0200 (CEST)

Package: libpng2
Version: 1.0.0-0.1

Hello,

I've send a copy of this text to debian-devel to get possibly
helpful response.

due to problems with the latest libpng which I call from ImLib
I wrote to rasterman (author of ImLib).  Because it seems me to be
importand I enclose his private mail here (hoping that he hasn't
any objections against this ...).

R> Date: Thu, 22 Oct 1998 14:03:41 -0400 (EDT)
R> From: "The Rasterman (Carsten Haitzler)" <raster@redhat.com>
R> To: Andreas Tille <tille@physik.uni-halle.de>
R> Subject: Re: ImLib can't read all png files with libpng 1.0.2
R> 
R> On Thu, 22 Oct 1998, Andreas Tille wrote:
R> 
R> > Hello,
R> > 
R> > I updated to libpng-1.0.2 (... may be this was my fault :-().
R> 
R> 1.0.2 has bugs - downgrade to 1.0.1
R> 
R> > Now some png files aren't read correctly by ImLib.
R> > I tested it with your very simple example from the tutorial.
R> > I attached one of the files, which ImLib isn't able to load.
R> > 
R> > I looked some hours on the code but couldn't detect the problem.
R> 
R> That's cause its a libpng bug.

I've done some further investigation which showed at least the reason
*why* some of my files can't be read correctly.  The allocation of
png_ptr->zbuf changes the value of png_ptr->time_buffer (please don't
ask me why.  Later on freeing of png_ptr->time_buffer breaks the
program with SIG_SEGV or may be libpng creates a scrambled pixmap.

In the following patch I marked the critical parts of pngread.c:

-----------------------------------------------------------------------
--- pngread.c	Sun Jun 14 21:43:31 1998
+++ pngread.c.new	Thu Oct 22 22:16:19 1998
@@ -81,8 +81,10 @@
 
    /* initialize zbuf - compression buffer */
    png_ptr->zbuf_size = PNG_ZBUF_SIZE;
+printf("%s(%i) png_ptr->time_buffer = %p\n", __FILE__, __LINE__, png_ptr->time_buffer);
    png_ptr->zbuf = (png_bytep)png_malloc(png_ptr,
      (png_uint_32)png_ptr->zbuf_size);
+printf("%s(%i) png_ptr->time_buffer = %p\n", __FILE__, __LINE__, png_ptr->time_buffer);
    png_ptr->zstream.zalloc = png_zalloc;
    png_ptr->zstream.zfree = png_zfree;
    png_ptr->zstream.opaque = (voidpf)png_ptr;
@@ -846,7 +848,9 @@
 #endif
 #endif
 #if defined(PNG_TIME_RFC1123_SUPPORTED)
-   png_free(png_ptr, png_ptr->time_buffer);
+printf("%s(%i) next line was commented out to avoid crash (png_ptr->time_buffer = %p)\n",
+       __FILE__, __LINE__, png_ptr->time_buffer);
+/* png_free(png_ptr, png_ptr->time_buffer); */
 #endif /* PNG_TIME_RFC1123_SUPPORTED */
 
    inflateEnd(&png_ptr->zstream);
-----------------------------------------------------------------------------

Note: This patch does NOT SOLVE the problem but gives a pointer to the
location, where it has to be solved!!  I'm not so familiar with libpng
that I could do the job but I want it to make someone else easyer.

I decided to report this to the list give a reasonable warning and the
chance to give the maintainer more help.

If someone can't reproduce the problem I can support some files that
break when using the simplest viewer I can imagine: some code snipped
from the ImLib tutorial.

Should we follow the suggestion of "The Rasterman" to downgrade or
should we fix the bug(s???).

In the case we decide to fix it I'm afraid that we have to do it
ourselves.  In former times I wanted to support the libpng authors
by some autoconf/automake stuff I've written to cope with several
machines (If there is any interest I can ship it to an apropriate
location, may be the maintainer??).  In my opinion it would be a case
of fairness to give any answer (may be:  We don't need your nonsense.)
but ignoring it completely wasn't the way I expected...


Kind regards

          Andreas.

-- System Information
Debian Release: slink
Kernel Version: Linux tower 2.0.33 #165 Mon Apr 27 09:40:53 /etc/localtime 1998 i586 unknown

Message #12 received at 28412@bugs.debian.org (full text, mbox, reply):

From: Vincent Renardias <vincent@ldsol.com>

To: debian-devel-changes@lists.debian.org

Cc: 28412@bugs.debian.org

Subject: Uploaded libpng 1.0.2-1.1 (source i386) to ~vincent on master [NMU]

Date: Wed, 6 Jan 1999 21:36:06 +0100 (CET)

I've just uploaded on my account on master a new version of libpng2.
It fixes the problem with Imlib/Gnome and does not seem to break the
programs compiled with previous versions of libpng2 (although I've only
tested with xv).

Please test and tell me if it also works for you.

-----BEGIN PGP SIGNED MESSAGE-----

Format: 1.5
Date: Wed,  6 Jan 1999 19:00:15 +0100
Source: libpng
Binary: libpng2 libpng2-dev
Architecture: source i386
Version: 1.0.2-1.1
Distribution: frozen unstable
Urgency: low
Maintainer: Vincent Renardias <vincent@waw.com>
Description: 
 libpng2    - PNG library - runtime
 libpng2-dev - PNG library - development
Changes: 
 libpng (1.0.2-1.1) frozen unstable; urgency=low
 .
   * Fix Important bug #28412
     (using pngread.c from libpng-1.0.1 did the trick).
Files: 
 aec44ceb2cf2d5eb6c416b4f9778260a 633 libs optional libpng_1.0.2-1.1.dsc
 7220fb52ba0c622a4fd2d1c27e016736 13131 libs optional libpng_1.0.2-1.1.diff.gz
 80cfccd7bd03c6376ac1ca7c5724f4c6 113636 libs optional libpng2_1.0.2-1.1_i386.deb
 52e78eeaaac29ab4bd39798ba70c39fc 138718 graphics optional libpng2-dev_1.0.2-1.1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3ia
Charset: noconv

iQCVAwUBNpPG3w+bo1sI1mwpAQF+0QP/dIWbwjF9Tg+1agdc/bOMTR87GmDhX0xy
7jbSvqDMl8GTdv9/gDKC2bPRKS6BPDviU3QTCugXux0DR1eUL+Srtrfr69Eb/70U
RiRb2xQa4wvjMQVVFUYaAdVooqC8LtN9CQ3Ot2PadUAs4mrFOc9MAoq3ka2vRwgk
MItlGKmfu0c=
=TyHh
-----END PGP SIGNATURE-----

Message #21 received at 28412-close@bugs.debian.org (full text, mbox, reply):

From: Philippe Troin <phil@fifi.org>

To: 28412-close@bugs.debian.org

Subject: Bug#28412: fixed in libpng 1.0.3-1

Date: 5 Oct 1999 19:05:28 -0000

We believe that the bug you reported is fixed in the latest version of
libpng, which has been installed in the Debian FTP archive:
libpng2-dev_1.0.3-1_i386.deb
  to dists/potato/main/binary-i386/graphics/libpng2-dev_1.0.3-1.deb
  replacing libpng2-dev_1.0.2b-0.1.deb
libpng_1.0.3-1.dsc
  to dists/potato/main/source/libs/libpng_1.0.3-1.dsc
  replacing libpng_1.0.2b-0.1.dsc
libpng2_1.0.3-1_i386.deb
  to dists/potato/main/binary-i386/libs/libpng2_1.0.3-1.deb
  replacing libpng2_1.0.2b-0.1.deb
libpng_1.0.3.orig.tar.gz
  to dists/potato/main/source/libs/libpng_1.0.3.orig.tar.gz
  replacing libpng_1.0.2b.orig.tar.gz
libpng_1.0.3-1.diff.gz
  to dists/potato/main/source/libs/libpng_1.0.3-1.diff.gz
  replacing libpng_1.0.2b-0.1.diff.gz

Note that this package is not part of the released stable Debian
distribution.  It may have dependencies on other unreleased software,
or other instabilities.  Please take care if you wish to install it.
The update will eventually make its way into the next released Debian
distribution.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 28412@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Philippe Troin <phil@fifi.org> (supplier of updated libpng package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----

Format: 1.6
Date: Mon,  4 Oct 1999 18:59:42 -0700
Source: libpng
Binary: libpng2 libpng2-dev
Architecture: source i386
Version: 1.0.3-1
Distribution: unstable
Urgency: low
Maintainer: Philippe Troin <phil@fifi.org>
Description: 
 libpng2    - PNG library - runtime
 libpng2-dev - PNG library - development
Closes: 28412 31523 31690 31870 46333
Changes: 
 libpng (1.0.3-1) unstable; urgency=low
 .
   * New upstream version (1.0.3); Closes: #31870, #46333.
   * Maintainer upload, closes NMU bugs; Closes: #28412, #31523, #31690.
   * FHS compliant.
   * New standard-version 3.0.1.
   * Lintian clean.
   * Removed temporary zlib1g line in control file (used to be a bug in
     zlib1g).
   * Moved the documentation file to the -dev package.
   * Register documentation file to doc-base.
   * Fontified man pages with addformat script; Closes #38680.
Files: 
 38e043a86c8a5a50251739eae94090b7 581 libs optional libpng_1.0.3-1.dsc
 06be53a1c46c4093c5c6b471cd9e4187 232899 libs optional libpng_1.0.3.orig.tar.gz
 d75a6d7c1e43e40bba611abfaba62bd9 13168 libs optional libpng_1.0.3-1.diff.gz
 3bacdbbfe0a4531aa99a217069b2e1ff 89950 libs optional libpng2_1.0.3-1_i386.deb
 2d10c62c3282b9f127335f567c544662 171996 graphics optional libpng2-dev_1.0.3-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3a
Charset: noconv

iQB1AwUBN/m3mJWBzwQ+5+3NAQGAdgL/WEsV512g6lSgpNaVXymG52EsALXK5/ZO
Plrcq5K5fjv4JplyexnsB9GAPeU4L8cYrbUyo1v9q22Ot5wwep9oAqUYw6ew2H9R
QjMWRUun4j7hrq+ese4uQRhLUcGIArhM
=LDxi
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.