Debian Bug report logs - #31508
parsechangelog broken?

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Christian Hudon" <chrish@debian.org>

To: submit@bugs.debian.org

Subject: parsechangelog broken?

Date: Tue, 5 Jan 1999 22:35:36 -0500

[Message part 1 (text/plain, inline)]

Package: dpkg-dev
Version: 1.4.1
Severity: important

Without the attached patch, I am unable to build packages with
dpkg-buildpackage.

  Christian

[dpkg.diff (text/plain, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #10 received at 31508@bugs.debian.org (full text, mbox, reply):

From: jdg@maths.qmw.ac.uk (Julian Gilbey)

To: chrish@debian.org, 31508@bugs.debian.org, wakkerma@debian.org

Subject: Bug#31508: parsechangelog broken?

Date: Fri, 15 Jan 1999 01:17:15 +0000 (GMT)

> Package: dpkg-dev
> Version: 1.4.1
> Severity: important
> 
> Without the attached patch, I am unable to build packages with
> dpkg-buildpackage.
> 
>   Christian
> [...]

You've got a bug all right, but the problem was that you were using a
non-English locale and controllib.pl assumes that you will get English
error messages.  The following patch will fix the problem.

Wichert or someone else: could you please rebuild dpkg and upload it
with this patch?  It is a bit much for me to download for such a small
bug.

   Julian

--- controllib.pl.orig	Fri Jan 15 01:08:51 1999
+++ controllib.pl	Fri Jan 15 01:10:15 1999
@@ -1,3 +1,4 @@
+use POSIX qw(:errno_h);
 
 $parsechangelog= 'dpkg-parsechangelog';
 
@@ -101,7 +102,7 @@
                 $substvar{$1}= $';
             }
             close(SV);
-        } elsif ($! !~ m/no such file or directory/i) {
+        } elsif ($! != ENOENT) {
             &error("unable to open substvars file $varlistfile: $!");
         }
     }

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

            Julian Gilbey             Email: J.D.Gilbey@qmw.ac.uk
       Dept of Mathematical Sciences, Queen Mary & Westfield College,
                  Mile End Road, London E1 4NS, ENGLAND
      -*- Finger jdg@goedel.maths.qmw.ac.uk for my PGP public key. -*-

Message #15 received at 31508@bugs.debian.org (full text, mbox, reply):

From: jdg@maths.qmw.ac.uk (Julian Gilbey)

To: chrish@debian.org, 31508@bugs.debian.org, wakkerma@debian.org

Subject: Bug#31508: parsechangelog broken?

Date: Fri, 15 Jan 1999 12:52:43 +0000 (GMT)

On second thoughts, Christian's original patch avoids the need to look
at debian/substvars if it is not needed, so could be used *in
addition* to mine.  The full patch looks like this:

--- controllib.pl.orig  Fri Jan 15 01:08:51 1999
+++ controllib.pl       Fri Jan 15 01:10:15 1999
@@ -1,3 +1,4 @@
+use POSIX qw(:errno_h);
 
 $parsechangelog= 'dpkg-parsechangelog';
 
@@ -91,7 +91,7 @@
 sub outputclose {
     my ($dosubstvars) = @_;
     for $f (keys %f) { $substvar{"F:$f"}= $f{$f}; }
-    if (length($varlistfile)) {
+    if (length($varlistfile) and $dosubstvars) {
         $varlistfile="./$varlistfile" if $varlistfile =~ m/\s/;
         if (open(SV,"< $varlistfile")) {
             while (<SV>) {
@@ -101,7 +102,7 @@
                 $substvar{$1}= $';
             }
             close(SV);
-        } elsif ($! !~ m/no such file or directory/i) {
+        } elsif ($! != ENOENT) {
             &error("unable to open substvars file $varlistfile: $!");
         }
     }


=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

            Julian Gilbey             Email: J.D.Gilbey@qmw.ac.uk
       Dept of Mathematical Sciences, Queen Mary & Westfield College,
                  Mile End Road, London E1 4NS, ENGLAND
      -*- Finger jdg@goedel.maths.qmw.ac.uk for my PGP public key. -*-

Send a report that this bug log contains spam.