Debian Bug report logs - #31620
dpkg: don't use hard coded ENOENT

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: brinkmd@debian.org

To: submit@bugs.debian.org

Subject: dpkg: don't use hard coded ENOENT

Date: Fri, 8 Jan 1999 17:38:24 +0100

Package: dpkg
Version: 1.4.1

Hello,

from update-alternatives & dpkg-divert:

#use POSIX; &ENOENT;
sub ENOENT { 2; }
# Sorry about this, but POSIX.pm isn't necessarily available

I am sorry about this, too, but the Hurd has a different ENOENT (somewhat
like 1673646). Do not hard code error values, please. Either include POSIX
in perl-base (it's about 100kB uncompressed), or rewrite the script avoiding
such klugdes (for example testing the existence with "-e" if an error
occurs. Just a remark, but the program flow of this script is obscure, so a
rewrite would not harm.

I would like to set the severity level to important, but this affects only
one port, which is not to be released. But still this prevents these scripts
from working at all on non-Linux systems, and it should be fixed.

Marcus

-- System Information
Debian Release: 2.1
Kernel Version: Linux flora 2.0.32 #1 Mit Jul 22 22:52:29 CEST 1998 i586 unknown

Versions of the packages dpkg depends on:
ii  libc6           2.0.7v-1       The GNU C library version 2 (run-time files)
ii  libstdc++2.8    2.90.29-2      The GNU stdc++ library (old egcs version)
hi  ncurses3.4      1.9.9g-8.10    Video terminal manipulation - shared librari

Message #14 received at 31620@bugs.debian.org (full text, mbox, reply):

From: Bart Schuller <schuller@lunatech.com>

To: debian-dpkg@lists.debian.org, debian-devel@lists.debian.org

Cc: 31620@bugs.debian.org

Subject: ENOENT (was Re: [PATCH] added --force-* options for conffile handling)

Date: Tue, 12 Oct 1999 10:41:15 +0200

On Tue, Oct 12, 1999 at 03:19:18AM +0200, Wichert Akkerman wrote:
> Previously Marcus Brinkmann wrote:
> > #31620:
> >   * scripts/dpkg-divert and update-alternatives: Don't hardcode ENOENT!
> 
> Where do you propose we get ENOENT for? POSIX might not be available
> and we have to get it somewhere..

We could perhaps include $CPAN/modules/by-module/Errno/ in perl-base or
whatever it's called nowadays.

From the README:

    This distribution generates a Errno package which will define and
    optionally export all E* constants defined in your system <errno.h>
    file.

-- 
The idea is that the first face shown to people is one they can readily
accept - a more traditional logo. The lunacy element is only revealed
subsequently, via the LunaDude. [excerpted from the Lunatech Identity Manual]

Message #19 received at 31620@bugs.debian.org (full text, mbox, reply):

From: Wichert Akkerman <wakkerma@cs.leidenuniv.nl>

To: Bart Schuller <schuller@lunatech.com>, submit@bugs.debian.org

Cc: debian-dpkg@lists.debian.org, debian-devel@lists.debian.org, 31620@bugs.debian.org

Subject: Re: ENOENT (was Re: [PATCH] added --force-* options for conffile handling)

Date: Tue, 12 Oct 1999 13:14:49 +0200

[Message part 1 (text/plain, inline)]

Package: perl-5.005-base

Excellent idea, lets file a bugreport.

To the perl maintainer: this is needed to add proper HURD support to
dpkg, since right now there is no way to get ENOENT in perl.

Wichert.

Previously Bart Schuller wrote:
> On Tue, Oct 12, 1999 at 03:19:18AM +0200, Wichert Akkerman wrote:
> > Previously Marcus Brinkmann wrote:
> > > #31620:
> > >   * scripts/dpkg-divert and update-alternatives: Don't hardcode ENOENT!
> > 
> > Where do you propose we get ENOENT for? POSIX might not be available
> > and we have to get it somewhere..
> 
> We could perhaps include $CPAN/modules/by-module/Errno/ in perl-base or
> whatever it's called nowadays.
> 
> >From the README:
> 
>     This distribution generates a Errno package which will define and
>     optionally export all E* constants defined in your system <errno.h>
>     file.
> 
> -- 
> The idea is that the first face shown to people is one they can readily
> accept - a more traditional logo. The lunacy element is only revealed
> subsequently, via the LunaDude. [excerpted from the Lunatech Identity Manual]
> 
> 
> --  
> To UNSUBSCRIBE, email to debian-dpkg-request@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

-- 
==============================================================================
This combination of bytes forms a message written to you by Wichert Akkerman.
E-Mail: wakkerma@cs.leidenuniv.nl
WWW: http://www.wi.leidenuniv.nl/~wichert/

[Message part 2 (application/pgp-signature, inline)]

Message #24 received at 31620@bugs.debian.org (full text, mbox, reply):

From: "Kurt D. Starsinic" <kstar@chapin.edu>

To: Bart Schuller <schuller@lunatech.com>

Cc: debian-dpkg@lists.debian.org, debian-devel@lists.debian.org, 31620@bugs.debian.org

Subject: Re: ENOENT (was Re: [PATCH] added --force-* options for conffile handling)

Date: Tue, 12 Oct 1999 11:29:09 -0400

On Tue, Oct 12, 1999 at 10:41:15AM +0200, Bart Schuller wrote:
> On Tue, Oct 12, 1999 at 03:19:18AM +0200, Wichert Akkerman wrote:
> > Previously Marcus Brinkmann wrote:
> > > #31620:
> > >   * scripts/dpkg-divert and update-alternatives: Don't hardcode ENOENT!
> > 
> > Where do you propose we get ENOENT for? POSIX might not be available
> > and we have to get it somewhere..
> 
> We could perhaps include $CPAN/modules/by-module/Errno/ in perl-base or
> whatever it's called nowadays.

    Please forgive me if the answer is obvious, but why is dpkg-divert
checking for ENOENT _in addition to_ checking for a successful lstat()?
It seems to me that all possible failure modes of lstat() should have the
same significance in dpkg-divert.  It also seems that update-alternatives
is checking for ENOENT after the fact where -e or -l before the fact would
more correctly and portably fulfill the intention.

    I'm not arguing for/against adding Errno to perl-5.005-base, nor am
I criticizing the dpkg team's code; I'd just like to understand if there
are deeper issues I'm missing here.

    Peace,
* Kurt Starsinic (Kurt.Starsinic@isinet.com) --------- Technical Specialist *
|    `The future masters of technology will have to be lighthearted and     |
|     intelligent.  The machine easily masters the grim and the dumb.'      |
|                            -- Marshall McLuhan                            |
Institute for Scientific Information                   http://www.isinet.com/

Message #29 received at 31620@bugs.debian.org (full text, mbox, reply):

From: Stephen Zander <gibreel@debian.org>

To: Bart Schuller <schuller@lunatech.com>

Cc: debian-dpkg@lists.debian.org, debian-devel@lists.debian.org, 31620@bugs.debian.org

Subject: Re: ENOENT (was Re: [PATCH] added --force-* options for conffile handling)

Date: 12 Oct 1999 13:13:42 -0700

>>>>> "Bart" == Bart Schuller <schuller@lunatech.com> writes:
    Bart> We could perhaps include $CPAN/modules/by-module/Errno/ in
    Bart> perl-base or whatever it's called nowadays.

Ah, why?
$ dpkg -L perl-5.005-base
[snip]
/usr/lib/perl5/5.005/i386-linux/auto/POSIX/POSIX.so
[snip]
/usr/lib/perl5/5.005/i386-linux/POSIX.pm
[snip

POSIX support is in the base system.  And ENOENT is in POSIX.(pm|so).

-- 
Stephen

"Farcical aquatic ceremonies are no basis for a system of government!"

Message #34 received at 31620@bugs.debian.org (full text, mbox, reply):

From: Stephen Zander <gibreel@debian.org>

To: Wichert Akkerman <wakkerma@cs.leidenuniv.nl>

Cc: Bart Schuller <schuller@lunatech.com>, debian-dpkg@lists.debian.org, debian-devel@lists.debian.org, 31620@bugs.debian.org

Subject: Re: ENOENT (was Re: [PATCH] added --force-* options for conffile handling)

Date: 12 Oct 1999 13:14:45 -0700

>>>>> "Wichert" == Wichert Akkerman <wakkerma@cs.leidenuniv.nl> writes:
    Wichert> To the perl maintainer: this is needed to add proper HURD
    Wichert> support to dpkg, since right now there is no way to get
    Wichert> ENOENT in perl.

Did you check what's already in perl-*-base?

-- 
Stephen

"Farcical aquatic ceremonies are no basis for a system of government!"

Message #39 received at 31620@bugs.debian.org (full text, mbox, reply):

From: Wichert Akkerman <wichert@liacs.nl>

To: Stephen Zander <gibreel@debian.org>

Cc: Bart Schuller <schuller@lunatech.com>, debian-dpkg@lists.debian.org, debian-devel@lists.debian.org, 31620@bugs.debian.org

Subject: Re: ENOENT (was Re: [PATCH] added --force-* options for conffile handling)

Date: Fri, 15 Oct 1999 04:20:06 +0200

[Message part 1 (text/plain, inline)]

Previously Stephen Zander wrote:
> POSIX support is in the base system.  And ENOENT is in POSIX.(pm|so).

Not all of POSIX is in the base system. ENOENT being one of those
parts.. I'm uploading dpkg 1.4.1.16 which reverts the change to use
POSIX until the errno-codes have been moved into perl-*-base.

Wichert.

-- 
   ________________________________________________________________
 / Generally uninteresting signature - ignore at your convenience  \
| wichert@liacs.nl                    http://www.liacs.nl/~wichert/ |
| 1024D/2FA3BC2D 576E 100B 518D 2F16 36B0  2805 3CB8 9250 2FA3 BC2D |

[Message part 2 (application/pgp-signature, inline)]

Message #44 received at 31620@bugs.debian.org (full text, mbox, reply):

From: Marcus Brinkmann <Marcus.Brinkmann@ruhr-uni-bochum.de>

To: 31620@bugs.debian.org

Subject: perl-base contains Errno.pm, now it's time to move

Date: Fri, 16 Feb 2001 03:21:17 +0100

Hi,

it seems that perl-5.6-base contains Errno.pm since 5.6.0-4, so it's time
for dpkg scripts to use that instead of the hard coded errno, so this bug
can be closed.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de

Message #49 received at 31620@bugs.debian.org (full text, mbox, reply):

From: Wichert Akkerman <wichert@valinux.com>

To: Marcus Brinkmann <Marcus.Brinkmann@ruhr-uni-bochum.de>, 31620@bugs.debian.org

Subject: Re: Bug#31620: perl-base contains Errno.pm, now it's time to move

Date: Fri, 16 Feb 2001 13:36:06 +0100

Previously Marcus Brinkmann wrote:
> it seems that perl-5.6-base contains Errno.pm since 5.6.0-4, so it's time
> for dpkg scripts to use that instead of the hard coded errno, so this bug
> can be closed.

Oh joy, that would mean a Pre-Depends on perl-5.6-base.. I'll have
to talk with Jason to see if apt will handle that properly.

Wichert.

-- 
   ________________________________________________________________
 / Generally uninteresting signature - ignore at your convenience  \
| wichert@cistron.nl                  http://www.liacs.nl/~wichert/ |
| 1024D/2FA3BC2D 576E 100B 518D 2F16 36B0  2805 3CB8 9250 2FA3 BC2D |

Message #54 received at 31620@bugs.debian.org (full text, mbox, reply):

From: Robert Bihlmeyer <robbe@orcus.priv.at>

To: 31620@bugs.debian.org

Cc: apt@packages.debian.org

Subject: Re: Bug#31620: perl-base contains Errno.pm, now it's time to move

Date: 18 Apr 2001 14:39:20 +0200

On 16 Feb 2001, Wichert Akkerman wrote:

> Oh joy, that would mean a Pre-Depends on perl-5.6-base.. I'll have
> to talk with Jason to see if apt will handle that properly.

Any news on that front?

-- 
Robbe

Message #59 received at 31620-close@bugs.debian.org (full text, mbox, reply):

From: Wichert Akkerman <wakkerma@debian.org>

To: 31620-close@bugs.debian.org

Subject: Bug#31620: fixed in dpkg 1.9.0

Date: Fri, 27 Apr 2001 08:53:37 -0400

We believe that the bug you reported is fixed in the latest version of
dpkg, which has been installed in the Debian FTP archive:

dpkg-doc_1.9.0_all.deb
  to pool/main/d/dpkg/dpkg-doc_1.9.0_all.deb
dpkg-1.9.0.tar.gz byhand
dpkg_1.9.0.dsc
  to pool/main/d/dpkg/dpkg_1.9.0.dsc
dpkg-dev_1.9.0_all.deb
  to pool/main/d/dpkg/dpkg-dev_1.9.0_all.deb
dpkg-1.9.0_i386.nondebbin.tar.gz byhand
dpkg_1.9.0_i386.deb
  to pool/main/d/dpkg/dpkg_1.9.0_i386.deb
dpkg_1.9.0.tar.gz
  to pool/main/d/dpkg/dpkg_1.9.0.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 31620@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Wichert Akkerman <wakkerma@debian.org> (supplier of updated dpkg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 26 Apr 2001 12:39:16 +0200
Source: dpkg
Binary: dpkg-dev dpkg-doc dpkg
Architecture: source all i386
Version: 1.9.0
Distribution: unstable
Urgency: low
Maintainer: Wichert Akkerman <wakkerma@debian.org>
Changed-By: Wichert Akkerman <wakkerma@debian.org>
Description: 
 dpkg       - Package maintenance system for Debian
 dpkg-dev   - Package building tools for Debian
 dpkg-doc   - Dpkg Internals Documentation
Closes: 4784 4974 13961 15644 25317 25496 31620 37017 45511 60717 60717 65284 67528 67896 68783 72406 74372 74814 75139 75562 75796 80142 80529 80532 81358 81630 82419 82708 82723 83042 83083 83468 83752 83812 84328 84361 84449 84582 84625 84905 85035 85040 85080 85847 85977 86453 86658 86847 87238 87485 87505 87571 87572 87579 87581 87985 88015 88225 88987 89000 89409 90328 90516 90722 90982 92908 93559 93873 94474 95023 95088
Changes: 
 dpkg (1.9.0) unstable; urgency=low
 .
   * Things should mostly work OpenBSD 2.8 as well now
   * Added a --status-pipe option.
   * Fixed several memleaks.
   * Profiled dpkg.
     * Reworked lib/parse.c:parsedb().  Instead of using getc(), then
       calling varbufaddc(), it now reads the entire file at once into a
       huge buffer, then moves pointers around, to do the parsing.  This
       gave a speedup of 33% on a dual celeron 333, when reading status and
       available.
     * various other speedups.
   * Removed all --smallmem code, as smallmem and largemem now actually
     use about the same amount of memory, and largemem is faster.  Both
     --largemem and --smallmem are now obselete options, and will print
     a warning if used. Closes: Bug#84905, #67528
   * Initialize unitialized variables.  This should solve several
     segfaults. Closes: Bug#25317(plus 9 others, thru the beauty of
     merges)
   * Found that when working with dependency cycles, and part of the cycle
     was a provide, the provider was not being considered, so the cycle
     could not be broken. Closes: Bug#87985(and 3 others)
   * Update German translation, Closes: Bug#80529,#80532,#87581
   * Update French translation, Closes: Bug#65284,#85035,#87238
   * Update Japanese translation, Closes: Bug#93873
   * Updated all other translations (but no bugs filed)
   * Add Danish translation
   * Remove spurious '%s' in Polish translation, Closes: Bug#74814
   * Add French manpages, courtesy of Philippe Batailler
   * Ingore vim swapfiles in dpkg-source, Closes: Bug#81630
   * remove --import option from dpkg-statoverride, Closes: Bug#81358
   * Replace nfmalloc implementation with obstack. Added obstack.[ch] to
     optlib, for non-GNU systems.
   * dpkg-divert only allows absolute filenames now. Closes: Bug#82419
   * Handle diffs from non-existing files to existing files. Closes: Bug#82708,
     #90982.
   * Small fixes to the buildsystem. Closes: Bug#84361
   * Fix dpkg-statoverride --update for things other then plain files.
     Closes: Bug#84449
   * Fix race with source directory disappearing in dpkg-source.
     Closes: Bug#45511
   * Fix manpage for dpkg-gencontrol. Closes: Bug#84625
   * Add -n option for dpkg-gencontrol to specify a filename. Closes: Bug#75796
   * Use POSIX glob instead of regexp in debian/rules. Closes: Bug#83042,
     #84582
   * fix typo in usage message for dpkg-divert, Closes: Bug#85977
   * Use full path for argv[0] when calling scripts. Closes: Bug#68783
   * Add ia64 support to dpkg-architecture.
   * Minor script changes, Closes: Bug#87485
   * Stop dpkg-genchanges from complaining about missing packages
     when doing a source-only build. Closes: Bug#87571,#15644,#25496
   * Various dpkg-architecture cleanups. Closes: Bug#87505
   * Modify dpkg-architecture to handle gcc versions containing letters.
     Closes: Bug#83083
   * dpkg-buildpackage updates: Closes: Bug#87572,#85847
     + make -C work properly
     + fix test for gpg secret keyring
     + improve source messages
     + skip signing pause when building unsigned packages
     + test for invalid signinterface. Closes: Bug#87579
     + remove debsign support, it's useless and doesn't work
     + Use correct architecture when naming .changes file. Closes: Bug#88015
   * Fix wording in dpkg-statoverride manpage for --add. Closes: Bug#85080
   * Fix typo in start-stop-daemon manpage. Closes: Bug#88225
   * Add dpkg-checkbuilddeps to check if build dependencies are satisfied
     and modify dpkg-buildpackage to call it if wanted.
     Closes: Bug#86453,#83812,#60717,#74372,#67896,#60717,#13961
   * dpkg-parsechangelog can read a changelog from stdin now. Closes: Bug#80142
   * Fix confusing wording for dpkg-buildpackage -uc option in manpage.
     Closes: Bug#83468
   * dpkg-statoverride now exits with exitcode 1 if we do a --list but don't
     output anything. Closes: Bug#84328
   * Remove Linux reference from all scripts, they should run fine on
     other OSes as well.
   * Mark last argument in dpkg-scanpackages usage info as optional.
     Closes: Bug#86658
   * Fix cache in dpkg-scanpackages version comparison. Closes: Bug#90722
   * Fix formatting error in dpkg-source.1. Closes: Bug#82723
   * Change dpkg-gencontrol to fix comma-related syntax errors after
     processing substvars. Closes: Bug#92908
   * Verify package signatures if debsig-verify is installed. Closes: Bug#37017
   * Handle window resize in dselect main menu. Closes: Bug#93559
   * Initialize all parts of the package record.  This should fix several
     segfaults people have been seeing in dpkg.  Closes: Bug#90328.
   * Apply patch from bug#86847, that escapes intl chars in filenames.
     Closes: Bug#83752, #85040, #86847, #89000.
   * Errors during dpkg -s(and other similiar commands) are now printed
     on stderr.  Closes: Bug#88987.
   * Add a --retry option to start-stop-daemon. Closes: Bug#75139
   * Fix regeps to extract Closes magic from a changelog so the #
     is really optional. Closes: Bug#94474
   * Remove useless statement from dpkg-shlibdeps. Closes: Bug#90516
   * Make the debian changelog parser identify itself with $progname.
     Closes: Bug#89409
   * Give a syntax error when we get an unexpected PGP signature in control
     files. Closes: Bug#75562
   * Change dpkg manpage to reflect that --force-statoveride is no enabled
     by default. Closes: Bug#95023
   * Handle dangling symlinks, by ignoring error code 1 from find, when
     processing --recursive. Closes: Bug#4784
   * dpkg -L, -S, -l, -s, and -p now return an error code if any package
     does not exist. Closes: Bug#4974, #72406
   * dselect has a configuration file as well now
   * Get ENOENT value at runtime in dpkg-divert instead of hardcoding it.
     Closes: Bug# 31620
   * Fix wrong ENOENT test in dpkg-divert. Closes: Bug#95088
   * Add support for more SuperH variants (sh[34]{,eb}-linux-gnu)
   * Fix formating and a typo in the dpkg manpage
   * Document the dpkg.cfg configuration file in dpkg(8)
Files: 
 2c6e367d8f9b51cf417ccfb35b858190 618 base required dpkg_1.9.0.dsc
 5c2b99e664b04c744eb93f079b51aef5 1288818 base required dpkg_1.9.0.tar.gz
 91767f85b979ebc86769149d8bb323cc 1018776 base required dpkg_1.9.0_i386.deb
 ea12da65ab5292cdb2b5d95d6b684dcc 1008856 byhand - dpkg-1.9.0_i386.nondebbin.tar.gz
 7f3f84fc919a122d7c492a1712f0b081 99710 devel important dpkg-dev_1.9.0_all.deb
 60bda539ece505c4eb2f7784be118571 10648 doc extra dpkg-doc_1.9.0_all.deb
 5c2b99e664b04c744eb93f079b51aef5 1288818 byhand - dpkg-1.9.0.tar.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iEYEARECAAYFAjrobwYACgkQPLiSUC+jvC3kEgCfX2M/zG64KdWbAfJ2QMjdWi3y
wq8An246QZUfICOMkw3TcI1zsNgSqnig
=OR1+
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.