Debian Bug report logs - #4524
controllib.pl doesn't show file name in error msg

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: krs@caos.aamu.edu (Karl Sackett)

To: submit@bugs.debian.org

Subject: controllib.pl doesn't show file name in error msg

Date: Thu, 19 Sep 1996 13:12:35 -0500 (CDT)

Package: dpkg-dev
Version: 1.4.0

While tracking down a different bug, I found this typo on line 58 of
/usr/lib/dpkg/controllib.pl:

	&error("unable to open substvars file $varlistvile: $!");
				 	      ^^^^^^^^^^^^

I changed this to '$varlistfile' and now controllib.pl now tells me which
substvars it can't open instead of printing a blank space.
-- 
Karl Sackett                                           krs@caos.aamu.edu
Run silent, run deep

Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: heiko@lotte.sax.de (Heiko Schlittermann)

To: krs@caos.aamu.edu, 4524@bugs.debian.org

Cc: submit@bugs.debian.org

Subject: Re: Bug#4524: controllib.pl doesn't show file name in error msg

Date: Fri, 20 Sep 1996 13:12:54 +0200 (MET DST)

Karl Sackett wrote:
: 
: While tracking down a different bug, I found this typo on line 58 of
: /usr/lib/dpkg/controllib.pl:
: 
: 	&error("unable to open substvars file $varlistvile: $!");

While preparing a 1.4.0.1 (??) package of dpkg I repaired this.
Should now _I_ close the bug report?


Karl, what was the other bug?  Perhaps I could include a fix to make
as many fixes as possible...

    Heiko
--
email : heiko@lotte.sax.de heiko@debian.org heiko@sax.de
pgp   : A1 7D F6 7B 69 73 48 35  E1 DE 21 A7 A8 9A 77 92 
finger: heiko@sax.sax.de         heiko@master.debian.org

Message #18 received at 4524-quiet@bugs.debian.org (full text, mbox, reply):

From: Ian Jackson <ian@chiark.greenend.org.uk>

To: Debian developers list <debian-devel@lists.debian.org>

Cc: 4524-quiet@bugs.debian.org, 4525-quiet@bugs.debian.org, 4554-quiet@bugs.debian.org

Subject: dpkg changes and queries - the answers to your questions

Date: Sun, 22 Sep 96 20:01 BST

I've just read debian-devel, and:

0. Yes, all existing packages should now be converted to the new
source format, and new packages should be in this format too.

1. Yes, dpkg-source doesn't work with hardlinks.  I think that
hardlinks in source packages are evil.  Perhaps they can be made to
work - Heiko's patch seems reasonable (until someone wants a filename
containing the string ` link to ').  However, I'd recommend just
removing the hardlink and replacing it with a symlink (or just
deleting one name).  There is no problem with doing that, and it is
fine wrt our policy about original sources.

2. I don't know what to do about tar doing nasty things to filenames.
If this is a design feature of all tars then dpkg-source should be
changed to unmangle the filename on output from tar.

3. Do NOT use Michael Meskes's patch to quote the argument to
$rootcommand in dpkg-buildpackage.  Instead, RTFM.  Please DO NOT
release a dpkg with Michael Meskes's patch.  Thank you.

4. dpkg-name belongs in the dpkg-dev package.  If anyone is releasing
a new dpkg they should move it.  See debian/rules.

5. I don't understand the problem with WIFSIGNALED, but this is
definitely a bug in the Perl installation and not in dpkg-source.

6. Karl Sackett's fix for an error message typo (Bug 4524) is good.
Heiko, please close the report if you like but definitely mail me the
patch.

7. Ives Arrouye asked about `Source: php' / `Package: php-module'.
This will work but you have to give dpkg-gencontrol the -p option.
There should be no need to have one of the binary packages named the
same as the source.

8. Regarding dpkg-shlibdeps: every shared library package should
provide a `shlibs' file for the libraries it contains.  This is put in
the DEBIAN directory when the package is built, and will end up in
/var/lib/dpkg/info/<pkg>.shlibs when it is installed.  dpkg-shlibdeps
looks there (but earlier versions had a bug).  The
/etc/dpkg/shlibs.local file is only there to sort things out with the
most basic packages before they have shlibs files in the shared
library packages.

Documentation for this is available.

If you find that your package needs a shared library package which
doesn't have the dpkg-shlibdeps support why not convert it now ?  See
the section on other-than-usual-maintainer releases in the policy
manual.

9. On permissions of maintainer scripts - this has affected libpng at
least: dpkg-source honours the extracter's umask, unlike tar.  The
debian/rules file should explicitly set the permissions and not rely
on (say) cp to copy them correctly.

10. Re dpkg-buildpackage and the failure to build due to permissions
(bug 4525).  I'm inclined to say "don't build with a umask of 077
then".  I don't think that all packages' debian/rules should be
responsible for fixing the permissions of the created files.

11. Christian Schwartz posted a Perl script that (I presume) produces
much the same output as
 sed -e 's/ +/ /' | sort +2
does on the Maintainers file in the indices subdirectory of the ftp
site.

12. llucius posts a patch to dpkg-buildpackage to make it pass -v, -m
and -C to dpkg-genchanges.  His patch is not in line with my intent,
and won't work when the arguments have spaces.  The call to
dpkg-genchanges needs to read
 withecho dpkg-genchanges $sourcestyle "$@" >"$chg"
instead of the thing in his patch.  (Bug #4554.)

I hope this is enough to keep you going for another week :-).

Ian.

Message #21 received at 4524-quiet@bugs.debian.org (full text, mbox, reply):

From: branderh@iaehv.nl (Erick Branderhorst)

To: ian@chiark.greenend.org.uk (Ian Jackson)

Cc: debian-devel@lists.debian.org, 4524-quiet@bugs.debian.org, 4525-quiet@bugs.debian.org, 4554-quiet@bugs.debian.org

Subject: Re: dpkg changes and queries - the answers to your questions

Date: Mon, 23 Sep 1996 14:00:10 +0100

> 5. I don't understand the problem with WIFSIGNALED, but this is
> definitely a bug in the Perl installation and not in dpkg-source.

So the WIFSIGNALED thing has to do with perl.  Here is some about the
perl I have installed on my system.

Erick

$ dpkg --status perl
Package: perl
Status: install ok installed
Priority: important
Section: devel
Maintainer: Darren Stalder <torin@daft.com>
Source: perl
Version: 5.003-2
Pre-Depends: libc5, libgdbm1, libdb1
Recommends: libc5-dev
Description: Larry Wall's Practical Extracting and Report Language.
 An interpreted scripting language, known among some as "Unix's
 Swiss Army Chainsaw".
 .
 Perl is optimized for scanning arbitrary text files and system 
 administration. It has built-in extended regular expression matching
 and replacement, a dataflow mechanism to improve security with
 setuid scripts and is extendible via modules that can interface
 to C libraries.

$ ls -l /bin/perl
lrwxrwxrwx   1 root     root           15 Jul  3 11:29 /bin/perl -> ../usr/bin/perl
$ /usr/bin/perl -v

This is perl, version 5.003 with EMBED
	built under linux at Jul  1 1996 10:21:20
	+ suidperl security patch

Copyright 1987-1996, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5.0 source kit.

$ /usr/bin/perl -V
Summary of my perl5 (5.0 patchlevel 3 subversion 0) configuration:
  Platform:
    osname=linux, osver=2.0.0, archname=i486-linux
    uname='linux perv 2.0.0 #2 tue jun 11 01:31:01 pdt 1996 i486 '
    hint=recommended, useposix=true, d_sigaction=define
  Compiler:
    cc='cc', optimize='-O2 -fomit-frame-pointer', gccversion=2.7.2
    cppflags='-Dbool=char -DHAS_BOOL -I/usr/include/db -I/usr/local/include'
    ccflags ='-Dbool=char -DHAS_BOOL -I/usr/include/db -I/usr/local/include'
    stdchar='char', d_stdstdio=define, usevfork=false
    voidflags=15, castflags=0, d_casti32=define, d_castneg=define
    intsize=4, alignbytes=4, usemymalloc=n, randbits=31
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lndbm -lgdbm -ldbm -ldb -ldl -ldld -lm -lc
    libc=/lib/libc.so.5.2.18, so=so
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=, ccdlflags='-rdynamic'
    cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib'

@INC: /usr/lib/perl5/i486-linux/5.003 /usr/lib/perl5 /usr/local/lib/site_perl/i486-linux /usr/local/lib/site_perl .
$ 

Message #26 received at 4524@bugs.debian.org (full text, mbox, reply):

From: heiko@lotte.sax.de (Heiko Schlittermann)

To: 4524@bugs.debian.org

Subject: Re: Bug#4524: controllib.pl doesn't ...

Date: Sat, 21 Sep 1996 21:03:19 +0200 (MET DST)

I've corrected it for dpkg_1.4.0.1.

    Heiko
--
email : heiko@lotte.sax.de heiko@debian.org heiko@sax.de
pgp   : A1 7D F6 7B 69 73 48 35  E1 DE 21 A7 A8 9A 77 92 
finger: heiko@sax.sax.de         heiko@master.debian.org

Message #29 received at 4524-quiet@bugs.debian.org (full text, mbox, reply):

From: heiko@lotte.sax.de (Heiko Schlittermann)

To: ian@chiark.greenend.org.uk (Ian Jackson)

Cc: debian-devel@lists.debian.org, 4524-quiet@bugs.debian.org, 4525-quiet@bugs.debian.org, 4554-quiet@bugs.debian.org

Subject: Re: dpkg changes and queries - the answers to your questions

Date: Mon, 23 Sep 1996 21:42:05 +0200 (MET DST)

Ian Jackson wrote:
: 
: 1. Yes, dpkg-source doesn't work with hardlinks.  I think that
: hardlinks in source packages are evil.  Perhaps they can be made to
: work - Heiko's patch seems reasonable (until someone wants a filename
: containing the string ` link to ').  However, I'd recommend just

hmm ... but this seems not too often, at least less often then
the occurence of real hard links.

: removing the hardlink and replacing it with a symlink (or just
: deleting one name).  There is no problem with doing that, and it is
: fine wrt our policy about original sources.

The dpkg-source -b should scan for hardlinks and convert 'em.


: 2. I don't know what to do about tar doing nasty things to filenames.
: If this is a design feature of all tars then dpkg-source should be
: changed to unmangle the filename on output from tar.

I've done it.  

cpio returns iso conformant file names (e.g. with real umlauts), tar
doesn't -- it converts such umlauts to their octal representation.

A line 

        /\\/ and eval "\$_ = \"$_\"";

does the job on the mangeled (?) names from tar's output.


: 3. Do NOT use Michael Meskes's patch to quote the argument to
: $rootcommand in dpkg-buildpackage.  Instead, RTFM.  Please DO NOT
: release a dpkg with Michael Meskes's patch.  Thank you.

Hmm, I've changed it.  The default root command is now `eval',
the lines are now read as:

        withecho $rootcommand "debian/rules clean"

If I did no mistakes it worked for me.
(I've running a patched su (using SUPASS env., similar to PGPPASS).
(sudo needs absolute path names, super -- I don't know)

: 4. dpkg-name belongs in the dpkg-dev package.  If anyone is releasing
: a new dpkg they should move it.  See debian/rules.

Done.

: 6. Karl Sackett's fix for an error message typo (Bug 4524) is good.
: Heiko, please close the report if you like but definitely mail me the
: patch.

Ok, I'll mail you a diff 1.4.0.1 against 1.4.0, including this
patch too.

: 10. Re dpkg-buildpackage and the failure to build due to permissions
: (bug 4525).  I'm inclined to say "don't build with a umask of 077
: then".  I don't think that all packages' debian/rules should be
: responsible for fixing the permissions of the created files.

The only files created by the debian tools (dpkg-*) are debian/files
and debian/substvars.  I've changed dpkg-* so now 
these files are chowned to getlogin().getgrnam(getlogin()).  I believe,
it's the most approbiate setting. (???)

: 12. llucius posts a patch to dpkg-buildpackage to make it pass -v, -m
: and -C to dpkg-genchanges.  His patch is not in line with my intent,
: and won't work when the arguments have spaces.  The call to
: dpkg-genchanges needs to read
:  withecho dpkg-genchanges $sourcestyle "$@" >"$chg"
: instead of the thing in his patch.  (Bug #4554.)

I'll have a look at it.

: I hope this is enough to keep you going for another week :-).

 :-) not yet.


    Heiko
--
email : heiko@lotte.sax.de heiko@debian.org heiko@sax.de
pgp   : A1 7D F6 7B 69 73 48 35  E1 DE 21 A7 A8 9A 77 92 
finger: heiko@sax.sax.de         heiko@master.debian.org

Message #34 received at 4524-maintonly@bugs.debian.org (full text, mbox, reply):

From: remco@blaakmeer.student.utwente.nl (Remco Blaakmeer)

To: 4524-maintonly@bugs.debian.org

Subject: Old bugs need to be looked at

Date: Sun, 1 Feb 1998 12:23:04 +0100 (CET)

This is an automated message sent to all bugs older than one year.

This bug is very old. Please take a look at it and see if you can fix it.
If it has already been fixed, please close it.

If you have problems fixing it or if you don't have the time to fix it,
please ask the people on debian-devel@lists.debian.org for help, so that
at least the oldest bugs can be solved before Debian 2.0 is released.

Remco Blaakmeer

Send a report that this bug log contains spam.