Debian Bug report logs - #5571
dpkg-buildpackage & dpkg-genchanges do not honor "-sd"

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Brian C. White" <bcwhite@verisim.com>

To: Debian Bugs <submit@bugs.debian.org>

Subject: dpkg-buildpackage & dpkg-genchanges do not honor "-sd"

Date: Fri, 22 Nov 1996 15:51:06 -0500

Package: dpkg-dev
Version: 1.4.0.3

I tried to build 'wine', but hate uploading the large source file when
it is basically pointless to do so (it is in "experimental" and it changes
often).  The man page for "dpkg-buildpackage" says:

              -sa forces the inclusion of  the  original  source;
              -sd  forces  its  exclusion  and  includes only the
              diff.

I tried this, but it did not work...

callandor:~/build/wine-961117# dpkg-buildpackage -sd
dpkg-buildpackage: source package is wine
dpkg-buildpackage: source version is 961117-alpha-1
dpkg-buildpackage: build architecture is i386
 debian/rules clean
[...]
 dpkg-source -b wine-961117
dpkg-source: warning: source directory `./wine-961117' is not <sourcepackage>-<upstreamversion> `wine-961117-alpha'
dpkg-source: building wine in wine_961117-alpha.tar.gz
dpkg-source: building wine in wine_961117-alpha-1.dsc
[...]
 dpkg-genchanges -sd
dpkg-genchanges: including full source code in upload


What was not included is the diff file.

                                          Brian
                                 ( bcwhite@verisim.com )
                                             
-------------------------------------------------------------------------------
    In theory, theory and practice are the same.  In practice, they're not.

Message #10 received at 5571@bugs.debian.org (full text, mbox, reply):

From: Dale Scheetz <dwarf@polaris.net>

To: "Brian C. White" <bcwhite@verisim.com>, 5571@bugs.debian.org

Cc: debian-bugs-dist@lists.debian.org, Ian Jackson <ian@chiark.greenend.org.uk>

Subject: Re: Bug#5571: dpkg-buildpackage & dpkg-genchanges do not honor "-sd"

Date: Sat, 23 Nov 1996 22:27:46 -0500 (EST)

On Fri, 22 Nov 1996, Brian C. White wrote:

> Package: dpkg-dev
> Version: 1.4.0.3
> 
> I tried to build 'wine', but hate uploading the large source file when
> it is basically pointless to do so (it is in "experimental" and it changes
> often).  The man page for "dpkg-buildpackage" says:
> 
>               -sa forces the inclusion of  the  original  source;
>               -sd  forces  its  exclusion  and  includes only the
>               diff.
> 
> I tried this, but it did not work...
> 
> callandor:~/build/wine-961117# dpkg-buildpackage -sd
> dpkg-buildpackage: source package is wine
> dpkg-buildpackage: source version is 961117-alpha-1
> dpkg-buildpackage: build architecture is i386
>  debian/rules clean
> [...]
>  dpkg-source -b wine-961117
> dpkg-source: warning: source directory `./wine-961117' is not <sourcepackage>-<upstreamversion> `wine-961117-alpha'
> dpkg-source: building wine in wine_961117-alpha.tar.gz
> dpkg-source: building wine in wine_961117-alpha-1.dsc
> [...]
>  dpkg-genchanges -sd
> dpkg-genchanges: including full source code in upload
> 
> 
> What was not included is the diff file.
> 
Your version number has no revision number. This declares the package to
be "Debian only" and thus not in need of a diff. Change it to 961117-1 and
things should work as you expect.
Even though you tried to use -sd, source inclusion is forced on a version
roll over. No version is considered equivalent to roll-over and includes
source in the changes file.
I think that what you have seen is expected and correct.

Luck,

Dwarf

------------                                          --------------

aka   Dale Scheetz                   Phone:   1 (904) 877-0257
      Flexible Software              Fax:     NONE 
      Black Creek Critters           e-mail:  dwarf@polaris.net

------------ If you don't see what you want, just ask --------------

Message #15 received at 5571@bugs.debian.org (full text, mbox, reply):

From: "Brian C. White" <bcwhite@verisim.com>

To: Dale Scheetz <dwarf@polaris.net>, 5571@bugs.debian.org

Subject: Re: Bug#5571: dpkg-buildpackage & dpkg-genchanges do not honor "-sd"

Date: Mon, 25 Nov 1996 12:51:49 -0500

> Your version number has no revision number. This declares the package to
> be "Debian only" and thus not in need of a diff. Change it to 961117-1 and
> things should work as you expect.
> Even though you tried to use -sd, source inclusion is forced on a version
> roll over. No version is considered equivalent to roll-over and includes
> source in the changes file.
> I think that what you have seen is expected and correct.

Okay, I can see that.  Perhaps this situation could produce an appropriate
error message?
                                             
                                          Brian
                                 ( bcwhite@verisim.com )
                                             
-------------------------------------------------------------------------------
     Searching for something?  Look to us!  http://www.verisim.com/ferret/

Message #20 received at 5571@bugs.debian.org (full text, mbox, reply):

From: Dale Scheetz <dwarf@polaris.net>

To: "Brian C. White" <bcwhite@verisim.com>

Cc: 5571@bugs.debian.org

Subject: Re: Bug#5571: dpkg-buildpackage & dpkg-genchanges do not honor "-sd"

Date: Mon, 25 Nov 1996 13:18:06 -0500 (EST)

On Mon, 25 Nov 1996, Brian C. White wrote:

> > Your version number has no revision number. This declares the package to
> > be "Debian only" and thus not in need of a diff. Change it to 961117-1 and
> > things should work as you expect.
> > Even though you tried to use -sd, source inclusion is forced on a version
> > roll over. No version is considered equivalent to roll-over and includes
> > source in the changes file.
> > I think that what you have seen is expected and correct.
> 
> Okay, I can see that.  Perhaps this situation could produce an appropriate
> error message?
>                                              
So, it should consider -sd an illegal for a Debian-only package? This is
going to be non-trivial, as the options are validated at the beginning,
and it will only be know that the package is Debian-only after parsing the
changes file.

Luck,

Dwarf

------------                                          --------------

aka   Dale Scheetz                   Phone:   1 (904) 877-0257
      Flexible Software              Fax:     NONE 
      Black Creek Critters           e-mail:  dwarf@polaris.net

------------ If you don't see what you want, just ask --------------

Message #25 received at 5571@bugs.debian.org (full text, mbox, reply):

From: "Brian C. White" <bcwhite@verisim.com>

To: Dale Scheetz <dwarf@polaris.net>

Cc: 5571@bugs.debian.org

Subject: Re: Bug#5571: dpkg-buildpackage & dpkg-genchanges do not honor "-sd"

Date: Mon, 25 Nov 1996 14:28:54 -0500

> So, it should consider -sd an illegal for a Debian-only package? This is
> going to be non-trivial, as the options are validated at the beginning,
> and it will only be know that the package is Debian-only after parsing the
> changes file.

Perhaps when you notice it being a "debian-only" package and -sd has been
specified, you produce the message then:

Error: This is a debian-only package (known because there is no debian
       revision number at the end of the version number) and thus cannot
       be built with the "-sd" option.
                                             
                                          Brian
                                 ( bcwhite@verisim.com )
                                             
-------------------------------------------------------------------------------
 Generated by Signify v1.01.  For this and more, visit http://www.verisim.com/

Message #30 received at 5571-maintonly@bugs.debian.org (full text, mbox, reply):

From: remco@blaakmeer.student.utwente.nl (Remco Blaakmeer)

To: 5571-maintonly@bugs.debian.org

Subject: Old bugs need to be looked at

Date: Sun, 1 Feb 1998 12:25:09 +0100 (CET)

This is an automated message sent to all bugs older than one year.

This bug is very old. Please take a look at it and see if you can fix it.
If it has already been fixed, please close it.

If you have problems fixing it or if you don't have the time to fix it,
please ask the people on debian-devel@lists.debian.org for help, so that
at least the oldest bugs can be solved before Debian 2.0 is released.

Remco Blaakmeer

Message #37 received at 5571@bugs.debian.org (full text, mbox, reply):

From: Frank Lichtenheld <djpig@debian.org>

To: 5571@bugs.debian.org

Subject: Patch

Date: Sun, 24 Jul 2005 18:50:05 +0200

tags 5571 patch
thanks

djpig@debian.org--2005/dpkg--devel--1.13--patch-12:

--- orig/ChangeLog
+++ mod/ChangeLog
@@ -1,5 +1,8 @@
 2005-07-24  Frank Lichtenheld  <djpig@debian.org>

+       * scripts/dpkg-genchanges.pl: Give a warning when one tries
+       to use -sd on a native Debian package.
+
        * scripts/controllib.pl (capit): uppercase all letters that
        come after a minus ('-')



--- orig/debian/changelog
+++ mod/debian/changelog
@@ -21,6 +21,9 @@
   * Make the default behaviour for mangling field names
     "nicer" by uppercasing all letter that come after a
     minus ('-') (Frank Lichtenheld). Closes: #306474
+  * Let dpkg-genchanges print a warning if someone tries to
+    use -sd with a native Debian package (Frank Lichtenheld).
+    Closes: #5571

  --



--- orig/scripts/dpkg-genchanges.pl
+++ mod/scripts/dpkg-genchanges.pl
@@ -290,6 +290,9 @@
         $origsrcmsg= "not including original source code in upload";
         @sourcefiles= grep(!m/\.orig\.tar\.gz$/,@sourcefiles);
     } else {
+       if ($sourcestyle =~ m/d/ && !grep(m/\.diff\.gz$/,@sourcefiles)) {
+           &warn("Ignoring -sd option for native Debian package");
+       }
         $origsrcmsg= "including full source code in upload";
     }
 } else {


Gruesse,
-- 
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/

Message #46 received at 5571-close@bugs.debian.org (full text, mbox, reply):

From: Scott James Remnant <scott@netsplit.com>

To: 5571-close@bugs.debian.org

Subject: Bug#5571: fixed in dpkg 1.13.11

Date: Tue, 16 Aug 2005 21:17:04 -0700

Source: dpkg
Source-Version: 1.13.11

We believe that the bug you reported is fixed in the latest version of
dpkg, which is due to be installed in the Debian FTP archive:

dpkg-dev_1.13.11_all.deb
  to pool/main/d/dpkg/dpkg-dev_1.13.11_all.deb
dpkg_1.13.11.dsc
  to pool/main/d/dpkg/dpkg_1.13.11.dsc
dpkg_1.13.11.tar.gz
  to pool/main/d/dpkg/dpkg_1.13.11.tar.gz
dpkg_1.13.11_i386.deb
  to pool/main/d/dpkg/dpkg_1.13.11_i386.deb
dselect_1.13.11_i386.deb
  to pool/main/d/dpkg/dselect_1.13.11_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 5571@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Scott James Remnant <scott@netsplit.com> (supplier of updated dpkg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 17 Aug 2005 04:44:44 +0100
Source: dpkg
Binary: dpkg dselect dpkg-dev
Architecture: source i386 all
Version: 1.13.11
Distribution: unstable
Urgency: low
Maintainer: Scott James Remnant <scott@netsplit.com>
Changed-By: Scott James Remnant <scott@netsplit.com>
Description: 
 dpkg       - package maintenance system for Debian
 dpkg-dev   - package building tools for Debian
 dselect    - user tool to manage Debian packages
Closes: 5571 47404 57194 82407 95570 113626 121173 147574 151651 156319 169928 170869 171762 201848 236733 268639 273489 296026 302229 306474 306874 310306 310390 316470 317760 317770 318376 318473 318659 318745 319781 319784 319816 320925 320952 322359 322361 322362 322595 322917
Changes: 
 dpkg (1.13.11) unstable; urgency=low
 .
   The "Good, clean fun" Release.
 .
   * Fixed the always broken error handling so that only the intended
     cleanup handlers are run, rather than ones that we didn't expect.
     This corrects the bug when a package's postrm fails and the package is
     left in an installed state with no files; the package will now be left
     in a half-installed state, as originally intended.  Found by Marga
     Manterola while documenting the maintainer scripts.  Closes: #296026.
   * Fixed removal of files involved in diversions during upgrade, caused by
     checking whether the "directory" was in use by another package without
     actually checking whether or not it was a directory.  Closes: #310390.
   * Fixed package saving to not disappear packages who divert anything from
     the installing package out of the way.  Closes: #113626.
   * Improved clean-up of unpack failure during install or upgrade, to leave
     the system in exactly the same state as it started in.
     Closes: #47404, #82407, #121173, #170869, #201848, #236733, #268639.
   * Fixed crash when unpacking a package which has an unversioned Replaces
     declared on it by another package previously unpacked in the same run
     (Colin Watson).  Closes: #322595.
 .
   * New install unwinding fixed to ensure we don't leave a version in the
     status db for a not-installed package.
   * Corrected error call when encountering a corrupted filesystem tarfile
     to not print "Success".  Closes: #95570.
   * Fixed castration of potentially unsafe devices to not follow symlinks.
     Closes: #169928.
   * Marked log file descriptor as close-on-exec.  Closes: #320925.
   * Re-worked dpkg-source -x to allow all manner of strange things maintainers
     seem to do, unpacking isn't the right place to enforce sanity; we'll
     do it in -b later on >:-).  Closes: #316470, #317760, #318473, #318745,
     #322359, #322361, #322362.
 .
   * Corrected dselect synopsis line to match consensus.  Closes: #318659.
   * Changed dpkg-name to use a shell redirect rather than the /dev/stderr
     device that may not be writable.  Closes: #318376.
   * Adjusted various dpkg-query options to avoid outputting a trailing
     newline.  Closes: #151651, #319781.
   * Changed references to "statusoverride" file to just "statoverride"
     to make it match reality.  Closes: #320952.
   * Fixed several bugs with the default diff ignore list used by dpkg-source.
   * Added ,,* to the list of default diff ignore list.  Closes: #322917.
 .
   * Fixes to dpkg-dev (Frank Lichtenheld):
     - dpkg-checkbuilddeps will now exit with an error if it is unable to
       parse a dependency field.  Closes: #171762, #302229.
     - dpkg-genchanges will now output a warning if given -sd for a native
       package, as it's going to ignore it.  Closes: #5571.
     - dpkg-source fixed to give a more meaningful error message if given
       a directory as the first argument.  Closes: #306874.
     - dpkg-source fixed to handle being given an absolute path to -b.
       Closes: #147574.
     - Fix controllib.pl to allow whitespace before version operators.
       Closes: #273489, #310306.
     - Fix architecture dependency parsing that sometimes generated wrong
       list of requirements.  Closes: #319816.
     - Make the default control field name mangling behaviour "nicer" by
       upper-casing all letters that come after a dash.  Closes: #306474.
     - Ignore trailing newlines in single paragraph control files.
       Closes: #57194, #156319
   * Documentation:
     - Fixed typo in dpkg-architecture man page.  Closes: #317770.
     - Documented dpkg-deb -W/--show and --showformat.  Closes: #319784.
Files: 
 58e36a37b7b2557cad0ba4ac62ba262f 637 base required dpkg_1.13.11.dsc
 1c270abc1e0eb19a56042ee5c78f2c02 3571530 base required dpkg_1.13.11.tar.gz
 6ee6f8d5a6b35f66b8744e231fe1eb7c 1820772 base required dpkg_1.13.11_i386.deb
 ece1d4861d07e98df7dee3ad919c5ec4 119780 base required dselect_1.13.11_i386.deb
 c5492ff26b9de19da9e817be40a46d97 163106 utils standard dpkg-dev_1.13.11_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFDArWGIexP3IStZ2wRAgJzAJ9M5HGRsZPDFLIMECiIIl3H08QqrwCgmtRV
UcV2WKZcKO/OnP9TmDcRO14=
=LBQZ
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.