Debian Bug report logs - #60319
balsa produces junk output

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: joey@finlandia.Infodrom.North.DE (Martin Schulze)

To: submit@bugs.debian.org

Subject: balsa produces junk output

Date: Mon, 13 Mar 2000 21:47:44 +0100 (CET)

Package: balsa
Version: 0.6.0-1

While testing balsa the following output was generated on the terminal.
I have compiled balsa from source, since the .deb is said to be unusable.
I haven't changed anything, only run rules build until now.

*** Could not load config file .balsarc!

GnomeUI-WARNING **: Could not open help topics file NULL
<opened Inbox>
Locking mailbox 
Unlocking mailbox 
<read a mail>
Locking mailbox Inbox
Unlocking mailbox 
<read a mail>
Locking mailbox Inbox
Unlocking mailbox 
<read a mail>
Locking mailbox Inbox
Unlocking mailbox 
Locking mailbox Inbox
Unlocking mailbox 

It's a nice mail client...

System Information:
Linux finlandia 2.0.36 #12 Tue Jan 26 22:09:07 MET 1999 i686 unknown

Versions of packages balsa depends on:
gdk-imlib1     1.9.8-3        
libart2        1.0.55-2       
libaudiofile0  0.1.9-0.1      
libc6          2.1.3-7        
libesd0        0.2.17-6       
libglib1.2     1.2.7-2        
libgnome32     1.0.55-2       
libgnomesuppor 1.0.55-2       
libgnomeui32   1.0.55-2       
libgnorba27    1.0.55-2       
libgtk1.2      1.2.7-1        
liborbit0      0.5.0-3        
libproplist0   0.9.1-2        
libz1          <none>         
xlib6g         3.3.6-5        
ldso           1.9.11-5       


Regards,

	Joey

-- 
GNU GPL: "The source will be with you... always."

Message #10 received at 60319@bugs.debian.org (full text, mbox, reply):

From: Martin Schulze <joey@finlandia.Infodrom.North.DE>

To: Nicolás Lichtmaier <nick@debian.org>, Jake Griesbach <griesbac@gamera.colorado.edu>, rob <rob@funky-penguin.co.uk>, Richard Braakman <dark@xs4all.nl>

Cc: Debian Bugs <60319@bugs.debian.org>, 58662@bugs.debian.org, 57523@bugs.debian.org, 59128@bugs.debian.org

Subject: Balsa packages

Date: Tue, 14 Mar 2000 04:01:00 +0100

I've finally got even the "double mailboxes" problem fixed.  Please
find fixed packages at.  Please give them a try and test them.  I'll
wait a couple of days before I actually move the files into the
Incoming directory.

http://master.debian.org/~joey/NMU/balsa_0.6.0-1.1.changes
http://master.debian.org/~joey/NMU/balsa_0.6.0-1.1.diff.gz
http://master.debian.org/~joey/NMU/balsa_0.6.0-1.1.dsc
http://master.debian.org/~joey/NMU/balsa_0.6.0-1.1_i386.deb

Regards,

	Joey

-- 
GNU GPL: "The source will be with you... always."

Please always Cc to me when replying to me on the lists.

Message #15 received at 60319@bugs.debian.org (full text, mbox, reply):

From: Martin Schulze <joey@finlandia.Infodrom.North.DE>

To: 60319@bugs.debian.org, 58662@bugs.debian.org, 57523@bugs.debian.org, 59128@bugs.debian.org

Cc: Debian Bugs Control <control@bugs.debian.org>

Subject: alsaBalsaBals

Date: Wed, 15 Mar 2000 16:50:04 +0100

severity 60319 fixed
severity 58662 fixed
severity 57523 fixed
severity 59128 fixed
thanks

I've moved the package into the incoming directory.

Here's the patch:

diff -u -Nur --exclude CVS orig/balsa-0.6.0/debian/changelog balsa-0.6.0/debian/changelog
--- orig/balsa-0.6.0/debian/changelog	Mon Mar 13 22:03:41 2000
+++ balsa-0.6.0/debian/changelog	Tue Mar 14 03:42:02 2000
@@ -1,3 +1,22 @@
+balsa (0.6.0-1.1) frozen unstable; urgency=medium
+
+  * Non-maintainer upload
+  * Removed some useles output (fixes: Bug#60319)
+  * Analyzed Bug#58662: Old .balsarc files seem to break it, workaround:
+    remove the config and restart balsa.
+  * Changed subject to "Forwarded message" if no subject was given in a
+    forwarded mail
+  * Modified algorithm for subject creation for forwarded mails, looks
+    like Mutt these days
+  * Added header and footer for forwarded mails in the same way Mutt adds
+    them
+  * Forwarded mails are not quoted anymore (fixes: Bug#57523)
+  * Removed two leading newlines for mails (replyed and forwarded)
+  * Added stuff to recognize already loaded mailboxes.  This prevents
+    Balsa von displaying mailboxes twice (fixes: Bug#59128)
+
+ -- Martin Schulze <joey@finlandia.infodrom.north.de>  Tue, 14 Mar 2000 03:42:02 +0100
+
 balsa (0.6.0-1) unstable; urgency=low
 
   * New upstream
diff -u -Nur --exclude CVS orig/balsa-0.6.0/libbalsa/libbalsa_private.h balsa-0.6.0/libbalsa/libbalsa_private.h
--- orig/balsa-0.6.0/libbalsa/libbalsa_private.h	Thu Dec  2 07:16:57 1999
+++ balsa-0.6.0/libbalsa/libbalsa_private.h	Mon Mar 13 22:01:23 2000
@@ -7,14 +7,12 @@
   pthread_mutex_lock( &mailbox_lock );\
     if ( !mailbox->lock )\
     {\
-	  fprintf( stderr, "Locking mailbox %s\n", mailbox->name );\
       mailbox->lock = TRUE;\
       pthread_mutex_unlock( &mailbox_lock );\
       break;\
     }\
   else\
     {\
-      fprintf( stderr, "... Mailbox lock collision ..." );\
       pthread_mutex_unlock( &mailbox_lock );\
       usleep( 250 );\
     }\
@@ -25,14 +23,12 @@
   pthread_mutex_lock( &mailbox_lock );\
     if ( !mailbox->lock )\
     {\
-	  fprintf( stderr, "Locking mailbox \n" );\
       mailbox->lock = TRUE;\
       pthread_mutex_unlock( &mailbox_lock );\
       break;\
     }\
   else\
     {\
-      fprintf( stderr, "Mailbox lock collision \n" );\
       pthread_mutex_unlock( &mailbox_lock );\
       usleep( 250 );\
     }\
@@ -40,7 +36,6 @@
 
 #define UNLOCK_MAILBOX(mailbox)\
 do {\
-  fprintf(stderr, "Unlocking mailbox \n" );\
   pthread_mutex_lock( &mailbox_lock );\
   mailbox->lock = FALSE;\
   pthread_mutex_unlock( &mailbox_lock );\
diff -u -Nur --exclude CVS orig/balsa-0.6.0/src/local-mailbox.c balsa-0.6.0/src/local-mailbox.c
--- orig/balsa-0.6.0/src/local-mailbox.c	Thu Nov 18 23:32:26 1999
+++ balsa-0.6.0/src/local-mailbox.c	Tue Mar 14 03:32:31 2000
@@ -47,6 +47,26 @@
   return TRUE;
 }
 
+/* Ok this is a kludge, we need this global variable to find out if a
+ * given mailbox has already been loaded.  This in turn in required to
+ * decide if the mailbox may be displayed or not.  -Joey 2000/3/14
+ */
+gboolean mailbox_already_known;
+static gboolean
+traverse_check (GNode * node, gpointer data)
+{
+  if (!node->data)
+    return FALSE;
+  if (node && (MailboxNode *) node->data && ((MailboxNode *) node->data)->mailbox
+      && MAILBOX_LOCAL (((MailboxNode *) node->data)->mailbox)->path
+      && (strcmp (MAILBOX_LOCAL (((MailboxNode *) node->data)->mailbox)->path, (gchar *) data) == 0))
+    {
+      mailbox_already_known = TRUE;
+      return TRUE;
+    }
+  return FALSE;
+}
+
 static GNode *
 find_my_node (GNode * root,
 	      GTraverseType order,
@@ -97,6 +117,15 @@
       balsa_app.trash->type != MAILBOX_POP3)
     if (strcmp (path, MAILBOX_LOCAL (balsa_app.trash)->path) == 0)
       return;
+
+  if (!isdir)
+    {
+      mailbox_already_known = FALSE;
+
+      g_node_traverse (balsa_app.mailbox_nodes, G_LEVEL_ORDER, G_TRAVERSE_ALL, -1, traverse_check, path);
+      if (mailbox_already_known == TRUE)
+	return;
+    }
 
   if (isdir && type == MAILBOX_UNKNOWN)
     {
diff -u -Nur --exclude CVS orig/balsa-0.6.0/src/main.c balsa-0.6.0/src/main.c
--- orig/balsa-0.6.0/src/main.c	Wed Dec 15 05:02:54 1999
+++ balsa-0.6.0/src/main.c	Tue Mar 14 00:48:14 2000
@@ -133,8 +133,6 @@
 {
   if (config_load (BALSA_CONFIG_FILE) == FALSE)
     {
-      fprintf (stderr, "*** Could not load config file %s!\n",
-	       BALSA_CONFIG_FILE);
       balsa_init_begin ();
       //return;
     }
diff -u -Nur --exclude CVS orig/balsa-0.6.0/src/sendmsg-window.c balsa-0.6.0/src/sendmsg-window.c
--- orig/balsa-0.6.0/src/sendmsg-window.c	Wed Dec 22 02:27:03 1999
+++ balsa-0.6.0/src/sendmsg-window.c	Tue Mar 14 03:30:24 2000
@@ -654,19 +654,17 @@
 
 	if (!message->subject)
 	  {
-	    newsubject = g_strdup ("Fw: ");
-	    break;
+	    if (message->from && message->from->mailbox)
+	      newsubject = g_strdup_printf ("Forwarded message from %s", message->from->mailbox);
+	    else
+	      newsubject = g_strdup ("Forwarded message");
 	  }
-
-
-	tmp = message->subject;
-	if ((strlen (tmp) < 2) ||
-	    (toupper (tmp[0]) != 'F' &&
-	     toupper (tmp[1]) != 'W' &&
-	     tmp[2] != ':'))
+	else
 	  {
-	    newsubject = g_strdup_printf ("Fw: %s", message->subject);
-	    break;
+	    if (message->from && message->from->mailbox)
+	      newsubject = g_strdup_printf ("[%s: %s]", message->from->mailbox, message->subject);
+	    else
+	      newsubject = g_strdup_printf ("Fwd: %s", message->subject);
 	  }
       }
       break;
@@ -735,7 +733,7 @@
   if (type != SEND_NORMAL)
     {
       Body *body = NULL;
-      GString *str = g_string_new ("\n\n");
+      GString *str = g_string_new ("");
       GString *rbdy;
       gchar *tmp;
 
@@ -745,6 +743,25 @@
 	{
 	  body = (Body *) message->body_list->data;
 
+	  if (type == SEND_FORWARD)
+	    {
+	      if (message->from && message->from->personal)
+		{
+		  if (message->from->mailbox)
+		    tmp = g_strdup_printf (_("----- Forwarded message from %s <%s> -----\n\n"),
+					   message->from->personal, message->from->mailbox);
+		  else
+		    tmp = g_strdup_printf (_("----- Forwarded message from %s -----\n\n"), message->from->personal);
+		}
+
+	      else
+		tmp = g_strdup_printf (_("----- Forwarded message -----\n\n"));
+	      str = g_string_append (str, tmp);
+	      g_free (tmp);
+	    }
+	  else
+	    {
+	  
 	  if (message->date)
 	    {
               /* Should use instead something like:
@@ -770,6 +787,7 @@
 
 	  str = g_string_append (str, _(" wrote:\n"));
 
+	    }
 
       if (type != SEND_CONTINUE)
 	    gtk_text_insert (GTK_TEXT (msg->text), NULL, NULL, NULL, str->str, strlen (str->str));
@@ -777,13 +795,22 @@
 
 	  g_string_free (str, TRUE);
 
-      if (type != SEND_CONTINUE)
+	  if ((type != SEND_CONTINUE) && (type != SEND_FORWARD))
 	    rbdy = content2reply (message, balsa_app.quote_str);	/* arp */
 	  else
 	    rbdy = content2reply (message, NULL);	/* arp */
 
 	  gtk_text_insert (GTK_TEXT (msg->text), NULL, NULL, NULL, rbdy->str, strlen (rbdy->str));
 	  g_string_free (rbdy, TRUE);
+
+	  if (type == SEND_FORWARD)
+	    {
+	      tmp = g_strdup_printf (_("\n----- End forwarded message -----\n"));
+	      str = g_string_new (tmp);
+	      gtk_text_insert (GTK_TEXT (msg->text), NULL, NULL, NULL, str->str, strlen (str->str));
+	      g_string_free (str, TRUE);
+	    }
+
 	  gtk_text_insert (GTK_TEXT (msg->text), NULL, NULL, NULL, "\n\n", 2);
 	}
       message_body_unref (message);

Regards,

	Joey

-- 
A mathematician is a machine for converting coffee into theorems.

Please always Cc to me when replying to me on the lists.

Send a report that this bug log contains spam.