Debian Bug report logs - #63376
courier-imap: patches/changes and 0.31 is out

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Miquel van Smoorenburg <miquels@cistron.nl>

To: submit@bugs.debian.org

Subject: courier-imap: patches/changes and 0.31 is out

Date: Mon, 1 May 2000 20:02:41 +0200

Package: courier-imap
Version: 0.30.31pre1-1

The 0.30.31pre1 version is obsolete, 0.31 has been released a few weeks
ago. There is also a 0.31.32pre1 version out that has some important
bugfixes for genuine bugs triggered by for example mutt.

I don't think switching to 0.31.32pre1 is worth it right now, as it
has some substantial changes wrt the authentication stuff and it's
still an alpha/beta.

So, I've extracted just the bugfixes from the 0.31.32pre1 version and
am adding them below as a patch file. This fixes:

o  Minor fixes for gnus and mutt related issues.

Also, could you please add --enable-workarounds-for-imap-client-bugs
to the call to configure in debian/rules .. it makes courier-imap work
with pine and netscape where it didn't before.

I am now running 0.31 succesfully with pine, mutt and netscape.

You might want to consider uploading this for "frozen" as well...
as courier-imap still hasn't reached version 1.0, it should be allowed.

=================== courier-0.32pre1-fixes.patch ==========================
diff -ruN courier-imap-0.31/imap/fetch.c courier-imap-0.31.32pre1/imap/fetch.c
--- courier-imap-0.31/imap/fetch.c	Tue Mar 14 02:14:41 2000
+++ courier-imap-0.31.32pre1/imap/fetch.c	Sun Apr 30 17:19:22 2000
@@ -26,7 +26,7 @@
 #include	<sys/types.h>
 #include	<sys/stat.h>
 
-static const char rcsid[]="$Id: fetch.c,v 1.6 2000/03/14 01:14:41 mrsam Exp $";
+static const char rcsid[]="$Id: fetch.c,v 1.7 2000/04/30 15:19:22 mrsam Exp $";
 
 extern int current_mailbox_ro;
 extern struct imapscaninfo current_mailbox_info;
@@ -835,7 +835,7 @@
 off_t nlines, nbodylines;
 size_t i,j,k,l;
 int	c;
-char	buf[BUFSIZ];
+char	buf[BUFSIZ+2];
 int	goodheader;
 unsigned long skipping;
 unsigned long cnt;
@@ -882,6 +882,8 @@
 				buf[k]=':';
 			}
 		}
+		else if (buf[j] == '\n')
+			goodheader=0;
 
 		for (k=j; k<i; k++)
 			if (buf[k] == '\n')
@@ -898,6 +900,8 @@
 		j=k;
 	}
 
+	buf[l++]='\n';	/* Always append a blank line */
+
 	cnt=l;
 	for (i=0; i<l; i++)
 		if (buf[i] == '\n')	++cnt;
@@ -913,7 +917,7 @@
 	}
 
 	writes("{");
-	writen(cnt+2);	/* BUG */
+	writen(cnt);
 	writes("}\r\n");
 	p=buf;
 	while (skipping)
@@ -953,7 +957,6 @@
 		p += i;
 		cnt -= i;
 	}
-	writes("\r\n");	/* BUG */
 }
 
 struct fetchheaderinfo {
@@ -1037,6 +1040,9 @@
 			if (buf1[0] != '\n' && buf1[0] != '\r' &&
 				!isspace((int)(unsigned char)buf1[0]))
 				goodheader= (*headerfunc)(fi, buf1);
+			else if (buf1[0] == '\n')
+				goodheader=0;
+
 			if (!goodheader)
 			{
 				while (left)
diff -ruN courier-imap-0.31/imap/imapd.c courier-imap-0.31.32pre1/imap/imapd.c
--- courier-imap-0.31/imap/imapd.c	Tue Mar 14 02:00:43 2000
+++ courier-imap-0.31.32pre1/imap/imapd.c	Sun Apr 30 17:20:14 2000
@@ -69,7 +69,7 @@
 
 #define	SHARED	"shared"
 
-static const char rcsid[]="$Id: imapd.c,v 1.28 2000/02/28 05:16:52 mrsam Exp $";
+static const char rcsid[]="$Id: imapd.c,v 1.29 2000/04/30 15:20:14 mrsam Exp $";
 
 extern time_t rfc822_parsedt(const char *);
 extern void fetchflags(unsigned long);
@@ -1879,16 +1879,28 @@
 		}
 
 		mailbox=decode_valid_mailbox(curtoken->tokenbuf, 1);
-		if (mailbox && *mailbox == 0)
-		{
-			free(mailbox);
-			mailbox=0;
-		}
+
 		if (!mailbox)
 		{
 			free(msgset);
+
+			mailbox=valid_mailbox_name(curtoken->tokenbuf, 1);
+			if (mailbox && *mailbox == 0)
+			{
+				free(mailbox);
+				mailbox=0;
+			}
+			if (mailbox && nexttoken()->tokentype == IT_EOL)
+			{
+				free(mailbox);
+				writes(tag);
+				writes(" NO [TRYCREATE] Mailbox does not exist.\r\n");
+				return (0);
+			}
+			if (mailbox)	free(mailbox);
 			return (-1);
 		}
+
 		if (nexttoken()->tokentype != IT_EOL)
 		{
 			free(msgset);
diff -ruN courier-imap-0.31/imap/search.c courier-imap-0.31.32pre1/imap/search.c
--- courier-imap-0.31/imap/search.c	Mon Dec  6 14:33:00 1999
+++ courier-imap-0.31.32pre1/imap/search.c	Thu Apr 20 18:53:06 2000
@@ -24,7 +24,7 @@
 #include	"imaptoken.h"
 #include	"imapscanclient.h"
 
-static const char rcsid[]="$Id: search.c,v 1.3 1999/12/06 13:33:00 mrsam Exp $";
+static const char rcsid[]="$Id: search.c,v 1.4 2000/04/20 16:53:06 mrsam Exp $";
 
 extern time_t rfc822_parsedt(const char *);
 extern struct imapscaninfo current_mailbox_info;
@@ -284,7 +284,6 @@
 		}
 		break;
 	case search_uid:
-		break;
 		if (is_in_set(p->as, current_mailbox_info.msgs[msgnum].uid))
 			p->value=1;
 		break;
diff -ruN courier-imap-0.31/maildir/deliverquota.c courier-imap-0.31.32pre1/maildir/deliverquota.c
--- courier-imap-0.31/maildir/deliverquota.c	Mon Apr 10 02:43:37 2000
+++ courier-imap-0.31.32pre1/maildir/deliverquota.c	Fri Apr 28 01:41:49 2000
@@ -25,7 +25,7 @@
 #define	BUFSIZE	8192
 #endif
 
-static const char rcsid[]="$Id: deliverquota.c,v 1.6 2000/04/10 00:43:08 mrsam Exp $";
+static const char rcsid[]="$Id: deliverquota.c,v 1.7 2000/04/27 23:41:49 mrsam Exp $";
 
 static long deliver(const char *dir, const char *q, long s)
 {
@@ -103,7 +103,8 @@
 				&& errno != EAGAIN)
 			{
 				if (quotafd >= 0)	close(quotafd);
-				exit(75);
+				unlink(tname);
+				exit(77);
 			}
 			maildir_addquota(dir, quotafd, q, ss-s, 1);
 			if (quotafd >= 0)	close(quotafd);
diff -ruN courier-imap-0.31/maildir/maildirpurgetmp.c courier-imap-0.31.32pre1/maildir/maildirpurgetmp.c
--- courier-imap-0.31/maildir/maildirpurgetmp.c	Mon Feb 14 06:08:13 2000
+++ courier-imap-0.31.32pre1/maildir/maildirpurgetmp.c	Tue Apr 25 23:46:30 2000
@@ -55,7 +55,7 @@
 		strcat(strcat(strcpy(z, m), "/"), de->d_name);
 
 		if (stat(z, &stat_buf) == 0
-			&& stat_buf.st_mtime < current_time - nage)
+			&& stat_buf.st_ctime < current_time - nage)
 			unlink(z);
 		free(z);
 	}
=================== courier-0.32pre1-fixes.patch ==========================


Mike.

Message #10 received at 63376@bugs.debian.org (full text, mbox, reply):

From: Steve Haslam <araqnid@debian.org>

To: Miquel van Smoorenburg <miquels@cistron.nl>, 63376@bugs.debian.org

Subject: Re: Bug#63376: courier-imap: patches/changes and 0.31 is out

Date: Tue, 2 May 2000 08:21:42 +0100

[Message part 1 (text/plain, inline)]

On Mon, May 01, 2000 at 08:02:41PM +0200, Miquel van Smoorenburg wrote:
> So, I've extracted just the bugfixes from the 0.31.32pre1 version and
> am adding them below as a patch file. This fixes:

Woo, thanks.

> o  Minor fixes for gnus and mutt related issues.
> 
> Also, could you please add --enable-workarounds-for-imap-client-bugs
> to the call to configure in debian/rules .. it makes courier-imap work
> with pine and netscape where it didn't before.

Oops, thought I'd already done that... will do.

> I am now running 0.31 succesfully with pine, mutt and netscape.
> 
> You might want to consider uploading this for "frozen" as well...
> as courier-imap still hasn't reached version 1.0, it should be allowed.

Yes, having a courier-imap in frozen that didn't work well with two of
the main Linux IMAP clients is a bit poor :|

SRH
-- 
Steve Haslam, Production Engineer, Excite UK     steve.haslam@excitehome.net
            i'm dreaming things you're not supposed to dream and it's no sin

[Message part 2 (application/pgp-signature, inline)]

Message #15 received at 63376-close@bugs.debian.org (full text, mbox, reply):

From: Steve Haslam <araqnid@debian.org>

To: 63376-close@bugs.debian.org

Subject: Bug#63376: fixed in courier-imap 0.31-1

Date: 2 May 2000 11:57:32 -0000

We believe that the bug you reported is fixed in the latest version of
courier-imap, which has been installed in the Debian FTP archive:
courier-imap_0.31.orig.tar.gz
  to dists/potato/main/source/mail/courier-imap_0.31.orig.tar.gz
  replacing courier-imap_0.23.orig.tar.gz
courier-imap_0.31.orig.tar.gz
  to dists/woody/main/source/mail/courier-imap_0.31.orig.tar.gz
  replacing courier-imap_0.30.31pre1.orig.tar.gz
courier-imap_0.31-1.diff.gz
  to dists/potato/main/source/mail/courier-imap_0.31-1.diff.gz
  replacing courier-imap_0.23-3.diff.gz
courier-imap_0.31-1.diff.gz
  to dists/woody/main/source/mail/courier-imap_0.31-1.diff.gz
  replacing courier-imap_0.30.31pre1-1.diff.gz
courier-imap_0.31-1.dsc
  to dists/potato/main/source/mail/courier-imap_0.31-1.dsc
  replacing courier-imap_0.23-3.dsc
courier-imap_0.31-1.dsc
  to dists/woody/main/source/mail/courier-imap_0.31-1.dsc
  replacing courier-imap_0.30.31pre1-1.dsc
courier-imap_0.31-1_i386.deb
  to dists/potato/main/binary-i386/mail/courier-imap_0.31-1.deb
  replacing courier-imap_0.23-3.deb
courier-imap_0.31-1_i386.deb
  to dists/woody/main/binary-i386/mail/courier-imap_0.31-1.deb
  replacing courier-imap_0.30.31pre1-1.deb

Note that this package is not part of the released stable Debian
distribution.  It may have dependencies on other unreleased software,
or other instabilities.  Please take care if you wish to install it.
The update will eventually make its way into the next released Debian
distribution.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 63376@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Steve Haslam <araqnid@debian.org> (supplier of updated courier-imap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----

Format: 1.6
Date: Tue,  2 May 2000 10:46:03 +0100
Source: courier-imap
Binary: courier-imap
Architecture: source i386
Version: 0.31-1
Distribution: unstable frozen
Urgency: low
Maintainer: Steve Haslam <araqnid@debian.org>
Description: 
 courier-imap - IMAP daemon with PAM and Maildir support
Closes: 61674 62607 63376
Changes: 
 courier-imap (0.31-1) unstable frozen; urgency=low
 .
   * New upstream version, with bugfix patches ported from 0.31.32pre1 by
     Miquel van Smoorenburg ("Minor fixes for gnus and mutt related issues")
   * Also added --enable-workarounds-for-imap-client-bugs
     (Closes: #63376, #62607, #61674)
   * Targetted to frozen because previous version did not work well with Netscape,
     Mozilla or mutt- painful.
Files: 
 3bd8f95e6c47463360129c118a0b82dc 680 mail extra courier-imap_0.31-1.dsc
 69b5e171332b097084c134f36cff038c 694806 mail extra courier-imap_0.31.orig.tar.gz
 33a2a7efb63a301b1967cb4be150763b 5668 mail extra courier-imap_0.31-1.diff.gz
 0cea667ddb18bb59120391caa1f52c3e 239198 mail extra courier-imap_0.31-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iQCVAwUBOQ6k+OR5dk1klGYdAQGRywP/YS1k0TeSntf6/f6QdayzkHKFsPPKcsm6
ePPNqn9HUGRrK838DmeY3HbHfC3yLfwItYfL9W80rGBOdbc6o4HxcYRa6XodSlFu
Tu1VdFATGz14OYCZ97KyvrT8Knf9AfZGjgnz96CSCjkdPm5EAfG6cuLTfMZvEL8/
UmkFynw0Gbk=
=PyTH
-----END PGP SIGNATURE-----

Message #20 received at 63376@bugs.debian.org (full text, mbox, reply):

From: Miquel van Smoorenburg <miquels@cistron.nl>

To: 63376@bugs.debian.org

Cc: Brian May <bam@debian.org>

Subject: courier-0.32pre1-fixes.patch as mime attachment

Date: Tue, 2 May 2000 17:47:11 +0200

[Message part 1 (text/plain, inline)]

The same patch (courier-0.32pre1-fixes.patch) but now as MIME
attachment.

[courier-0.32pre1-fixes.patch (text/plain, attachment)]

Send a report that this bug log contains spam.