Debian Bug report logs - #6871
dpkg-dev: dpkg-source and final newlines

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: joey@kite.ml.org (Joey Hess)

To: submit@bugs.debian.org

Subject: dpkg-dev: dpkg-source and final newlines

Date: Mon, 27 Jan 1997 17:02:12 -0500 (EST)

Package: dpkg-dev
Version: 1.4.0.7

I have a upstream source package that is shipped with a file that lacks 
final newline. This presents problems because of the way dpkg-source deals 
with files w/o a final newline. If I try to unpack the package with
dpkg-source, I get this error:

dpkg-source: error: diff contains unknown line `\ No newline at end of file'

I think I have 3 ways to correct this in my package:

1. Ask the upstream maintainer to put out a new version of the package with
all files having a final newline. This seems like imposing debian's
limitations on others, and I'd rather not.

2. Edit the .orig.tar.gz and add the final newline. But then the
.orig.tar.gz will not be original, unmodified source. So I'd prefer not to
do this.

3. Don't modify any files that lack final newlines. Treat them asbinary
files, which can't be touched.

I'm going with option #3 for now, but I'm very unhappy with it. I hope that
dpkg-source can be changed to be more forgiving of this situation.

Message #10 received at 6871@bugs.debian.org (full text, mbox, reply):

From: Rob Browning <osiris@cs.utexas.edu>

To: joey@kite.ml.org (Joey Hess)

Cc: 6871@bugs.debian.org

Subject: Re: Bug#6871: dpkg-dev: dpkg-source and final newlines

Date: 27 Jan 1997 16:33:51 -0600

joey@kite.ml.org (Joey Hess) writes:

[...]

4. Edit the files after you unpack them to add the newlines.  These
newlines will then show up in the debian diff, but will be otherwise
irrelevant...

This is IMO no different than any other change you might have to make
to a package to make it fit Debian's guidelines.

-- 
Rob

Message #15 received at 6871@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joey@kite.ml.org>

To: Rob Browning <osiris@cs.utexas.edu>

Cc: 6871@bugs.debian.org

Subject: Re: Bug#6871: dpkg-dev: dpkg-source and final newlines

Date: Mon, 27 Jan 1997 18:27:49 -0500 (EST)

> 4. Edit the files after you unpack them to add the newlines.  These
> newlines will then show up in the debian diff, but will be otherwise
> irrelevant...
> 
> This is IMO no different than any other change you might have to make
> to a package to make it fit Debian's guidelines.

That's the same as my #2. One problem with doing this is that you have to
go back and fix the newlines everytime there's a new upstream version.

-- 
#!/usr/bin/perl -i$>=0;$<=0;exec"/bin/sh"'>achmod             joey@kite.ml.org
$_="echo '#!/usr/bin/suidperl -U\n$^I 2755aa";s=a= $ENV{HOME}/Imroot;=g;exec$_
# Get root in 30 seconds or less. Fix this hole: upgrade to perl 5.003 today..

Message #20 received at 6871@bugs.debian.org (full text, mbox, reply):

From: Rob Browning <osiris@cs.utexas.edu>

To: Joey Hess <joey@kite.ml.org>

Cc: 6871@bugs.debian.org

Subject: Re: Bug#6871: dpkg-dev: dpkg-source and final newlines

Date: 27 Jan 1997 17:40:09 -0600

Joey Hess <joey@kite.ml.org> writes:

> That's the same as my #2. One problem with doing this is that you have to
> go back and fix the newlines everytime there's a new upstream version.

Well, it sounded like you were talking about modifying the
.orig.tar.gz file so that it wasn't orig anymore, which I guess is not
permitted anyway, but I get your point.

You also could write a simple perl script that runs over the files and
fixes them at build time...

-- 
Rob

Message #25 received at 6871@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joey@kite.ml.org>

To: Rob Browning <osiris@cs.utexas.edu>

Cc: 6871@bugs.debian.org

Subject: Re: Bug#6871: dpkg-dev: dpkg-source and final newlines

Date: Mon, 27 Jan 1997 18:46:30 -0500 (EST)

> You also could write a simple perl script that runs over the files and
> fixes them at build time...

That's actually what I did. I treat the files like binary files (which can
never be modified), copy them to a new file, make the changes I need to
make with a perl script and install this file.

But I'm still not very happy with this. It's pretty obvious that you don't
want to go around editing binary files that are in source packages. It's
far less obvious that editing plain text files that happen to lack a
trailing newline will break things.

-- 
#!/usr/bin/perl -i$>=0;$<=0;exec"/bin/sh"'>achmod             joey@kite.ml.org
$_="echo '#!/usr/bin/suidperl -U\n$^I 2755aa";s=a= $ENV{HOME}/Imroot;=g;exec$_
# Get root in 30 seconds or less. Fix this hole: upgrade to perl 5.003 today..

Message #30 received at 6871-maintonly@bugs.debian.org (full text, mbox, reply):

From: remco@blaakmeer.student.utwente.nl (Remco Blaakmeer)

To: 6871-maintonly@bugs.debian.org

Subject: Old bugs need to be looked at

Date: Sun, 1 Feb 1998 12:30:08 +0100 (CET)

This is an automated message sent to all bugs older than one year.

This bug is very old. Please take a look at it and see if you can fix it.
If it has already been fixed, please close it.

If you have problems fixing it or if you don't have the time to fix it,
please ask the people on debian-devel@lists.debian.org for help, so that
at least the oldest bugs can be solved before Debian 2.0 is released.

Remco Blaakmeer

Message #35 received at 6871@bugs.debian.org (full text, mbox, reply):

From: Adam Di Carlo <apharris@burrito.onshore.com>

To: 6871@bugs.debian.org

Cc: joey@kite.ml.org

Subject: dpkg-dev: dpkg-source and final newlines

Date: 07 Nov 1998 13:32:41 -0500

> But I'm still not very happy with this. It's pretty obvious that you
> don't want to go around editing binary files that are in source
> packages. It's far less obvious that editing plain text files that
> happen to lack a trailing newline will break things.

I'm quite sure the dpkg-source *does* now tolerate cases, i.e., if
file foo has no final newline in the upstream source, but does have
one in the debian version.  No?  Am I wrong?

.....A. P. Harris...apharris@onShore.com...<URL:http://www.onShore.com/>

Message #50 received at 6871-done@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joeyh@debian.org>

To: control@bugs.debian.org

Cc: 6871-done@bugs.debian.org, 7355-done@bugs.debian.org, 9840-done@bugs.debian.org, 10175-done@bugs.debian.org, 12360-done@bugs.debian.org, 64953-done@bugs.debian.org, 65018-done@bugs.debian.org

Subject: fix submitter address

Date: Fri, 30 Jun 2000 17:25:51 -0700

# Cleaning up my really old bug reports. Mostly fixing orignator address
# to a working email, and also just closing some that are fixed now.

close 5712
reopen 5712 !
close 6394
reopen 6394 !
close 8204
reopen 8204 !
close 10106
reopen 10106 !
close 10949
reopen 10949 !
close 10950
reopen 10950 !
close 10964
reopen 10964 !
close 11047
reopen 11047 !
close 11174
reopen 11174 !
close 12254
reopen 12254 !
close 13116
reopen 13116 !
close 13180
reopen 13180 !
close 13884
reopen 13884 !
close 13985
reopen 13985 !
close 5890
reopen 5890 !
close 5956
reopen 5956 !
close 7059
reopen 7059 jmr@everest.radiology.uiowa.edu (Joe Reinhardt)
close 13580
reopen 13580 !
close 57154
reopen 57154 !
close 57504
reopen 57504 !
close 57153
reopen 57153 !

-- 
see shy jo

Send a report that this bug log contains spam.