Re: [Nbd] [patch] Re: nbd timeout on debian jessie, patch testing
- To: Markus Pargmann <mpa@...1897...>
- Cc: "nbd-general@lists.sourceforge.net" <nbd-general@lists.sourceforge.net>, Hermann Lauer <Hermann.Lauer@...1489...>
- Subject: Re: [Nbd] [patch] Re: nbd timeout on debian jessie, patch testing
- From: Michal Belczyk <belczyk@...1274...>
- Date: Thu, 26 Feb 2015 18:44:30 +0100
- Message-id: <20150226174430.GA85254@...1273...>
- In-reply-to: <20150226161146.GF10070@...1897...>
- References: <20141114165219.GD28731@...1273...> <20141118093150.GG20088@...1490...> <20141118100549.GA56582@...1273...> <20141128125554.GH1201@...1490...> <20141215101306.GA31118@...1490...> <CAECXXi773PiE6svgfHTyb2TqaGOtL8-TY4qHMPaQfbW-U_u70Q@...18...> <20150220135249.GC14976@...1490...> <CANZNk82N_Rp9RAH39JwXXczd8AeFa++AC+ss5Qn=xORP0NpbAQ@...18...> <20150224145307.GG23096@...1490...> <20150226161146.GF10070@...1897...>
On Thu, Feb 26, 2015 at 05:11:46PM +0100, Markus Pargmann wrote:
> Hi,
>
> On Tue, Feb 24, 2015 at 03:53:07PM +0100, Hermann Lauer wrote:
> > Dear Markus,
> >
> > On Fri, Feb 20, 2015 at 03:56:15PM +0200, Andrey Utkin wrote:
> > > >>>2015-01-13 21:26 GMT+02:00 Paul Clements <paul.cleme...@...856...>:
> > > >>>> - what are critical bugs or important issues requiring work, if there are
> > > >>>> any.
> > > >>>
> > > >>> There is a network timeout issue, which is probably one of the more
> > > >>> important fixes to get in:
> > > >>>
> > > >>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770479
> > > >>
> > > >>
> > > >>Looking at the proposed patch, it looks quite smart, and looking good
> > > >>as long as it is tested. Going to test that ASAP.
> > > >
> > > > I tested it successfully on a jessie kernel in December,
> > > > what was your result ?
> >
> > tested the mentioned patch (inluded below) with vanilla 3.19 and it works as
> > expected - i.e. breaking a raid1 within the specified timeout of 5s instead of
> > hanging until the disconnected network is reconnecting again.
> >
> > > Sorry, I haven't tested it personally.
> >
> > So now:
> > Tested-By: Hermann Lauer <Hermann.Lauer@...1489...>
>
> First of all thanks for testing this. Unfortunately the included patch
> is missing a Signed-off-by tag (see Documentation/SubmittingPatches), so
> I didn't have a deeper look into it.
> However, I have a testsetup now to reproduce the timeout issues and I
> see the problem. I also started looking at the timeout patch from 2013.
>
> @Michal: Maybe you are interested to resend the patch with your
> signed-off-by so we can discuss it?
I have just resent the patch I had originally sent over in November 2014
with the requested tag added.
--
Michal Belczyk Sr.
Reply to: