Debian Bug report logs - #48312
fsck parallel mode broken

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: root <root@pinky.HealthPartners.com>

To: submit@bugs.debian.org

Subject: fsck parallel mode broken

Date: Mon, 25 Oct 1999 14:36:13 -0500

Package: e2fsprogs
Version: 1.16-1
Severity: critical

Debian: potato
Dependencies: libc6 2.1.2-5, ldso 1.9.11-4


Running fsck in parallel mode causes command to hang after checking
one filesystem on each hard drive.  This is especially bad during
system boot!

Forcing serial mode with -s option works fine.  Previous releases
worked fine.

Problem still exists after boot.  Parallel fsck hangs after checking
one filesystem on each drive.

ex:
# fsck -N  -A -R
Parallelizing fsck version 1.16 (22-Oct-1999)
[/sbin/fsck.ext2 -- /usr] fsck.ext2 /dev/sda5
[/sbin/fsck.ext2 -- /ide] fsck.ext2 /dev/hda1

{command hangs}
^Z
bg
# top
  2:33pm  up 38 min,  2 users,  load average: 1.05, 0.67, 0.28
  37 processes: 35 sleeping, 2 running, 0 zombie, 0 stopped
  CPU states: 95.8% user,  4.1% system,  0.0% nice,  0.0% idle
  Mem:  127632K av,  45884K used,  81748K free,  19272K shrd,   3512K buff
  Swap:  64256K av,      0K used,  64256K free                 33020K cached

  PID USER     PRI  NI  SIZE  RSS SHARE STAT  LIB %CPU %MEM   TIME COMMAND
  412 root      18   0   376  376   328 R       0 95.1  0.2   3:59 fsck




---------------------------< boot message excerpts >-----------------------
Linux version 2.2.12
Detected 99716767 Hz processor.
Memory: 127576k/131072k available
CPU: Intel Pentium 75 - 200 stepping 05
Checking 'hlt' instruction... OK.
PCI: PCI BIOS revision 2.10 entry at 0xfc874
PCI: Using configuration type 1
PIIX: IDE controller on PCI bus 00 dev 38
PIIX: not 100% native mode: will probe irqs later
PIIX: neither IDE port enabled (BIOS)
PIIX: IDE controller on PCI bus 00 dev 39
PIIX: not 100% native mode: will probe irqs later
    ide0: BM-DMA at 0xffa0-0xffa7, BIOS settings: hda:DMA, hdb:pio
    ide1: BM-DMA at 0xffa8-0xffaf, BIOS settings: hdc:DMA, hdd:pio
hda: Maxtor 81081A2, ATA DISK drive
hdc: NEC CD-ROM DRIVE:288, ATAPI CDROM drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
ide1 at 0x170-0x177,0x376 on irq 15
hda: Maxtor 81081A2, 1033MB w/256kB Cache, CHS=525/64/63, DMA
hdc: ATAPI 24X CD-ROM drive, 128kB Cache
Uniform CDROM driver Revision: 2.55
(scsi0) <Adaptec AIC-7850 SCSI host adapter> found at PCI 13/0
(scsi0) Narrow Channel, SCSI ID=7, 3/255 SCBs
(scsi0) Warning - detected auto-termination
(scsi0) Please verify driver detected settings are correct.
(scsi0) If not, then please properly set the device termination
(scsi0) in the Adaptec SCSI BIOS by hitting CTRL-A when prompted
(scsi0) during machine bootup.
(scsi0) Cables present (Int-50 YES, Ext-50 NO)
(scsi0) Downloading sequencer code... 406 instructions downloaded
scsi0 : Adaptec AHA274x/284x/294x (EISA/VLB/PCI-Fast SCSI) 5.1.19/3.2.4
       <Adaptec AIC-7850 SCSI host adapter>
scsi : 1 host.
(scsi0:0:3:0) Synchronous at 10.0 Mbyte/sec, offset 15.
  Vendor: SEAGATE   Model: ST39173N          Rev: 6244
  Type:   Direct-Access                      ANSI SCSI revision: 02
Detected scsi disk sda at scsi0, channel 0, id 3, lun 0
scsi : detected 1 SCSI disk total.
SCSI device sda: hdwr sector= 512 bytes. Sectors= 17783240 [8683 MB] [8.7 GB]

Adding Swap: 64256k swap-space (priority -1)

Parallelizing fsck version 1.16 (22-Oct-1999)

[/sbin/fsck.ext2 -- /usr] fsck.ext2 /dev/sda5        (format inexact ...
[/sbin/fsck.ext2 -- /ide] fsck.ext2 /dev/hda1                no system log)

>>>>>>>>>>>>>>>>>>>>>> system hang <<<<<<<<<<<<<<<<<<<<<<<<<

Message #10 received at 48312@bugs.debian.org (full text, mbox, reply):

From: Yann Dirson <ydirson@altern.org>

To: tytso@mit.edu

Cc: idsfa@poboxes.com, 48312@bugs.debian.org

Subject: Re: Bug#48312: fsck parallel mode broken

Date: Tue, 26 Oct 1999 01:19:44 +0200 (CEST)

Hi Ted,

I was just reported the following problem, which I easily reproduced:

root writes:
 > Running fsck in parallel mode causes command to hang after checking
 > one filesystem on each hard drive.  This is especially bad during
 > system boot!
 > 
 > Forcing serial mode with -s option works fine.  Previous releases
 > worked fine.
 > 
 > Problem still exists after boot.  Parallel fsck hangs after checking
 > one filesystem on each drive.
 > 
 > ex:
 > # fsck -N  -A -R
 > Parallelizing fsck version 1.16 (22-Oct-1999)
 > [/sbin/fsck.ext2 -- /usr] fsck.ext2 /dev/sda5
 > [/sbin/fsck.ext2 -- /ide] fsck.ext2 /dev/hda1
 > 
 > {command hangs}

Playing with gdb, I notice that the instance_list chained list is
circular, which makes device_already_active() loop infinitely.

The following has to be changed in fsck.c::execute():

=====
	for (p = instance_list; p && p->next; p = p->next);

	if (p)
		p->next = instance_list;
	else
		instance_list = inst;
=====
	for (p = instance_list; p && p->next; p = p->next);

	if (p)
		p->next = inst;
	else
		instance_list = inst;
=====

...or we get the single-element circular instance_list I see.

Doing this change fixes the problem for me, as expected.

Regards,
-- 
Yann Dirson    <ydirson@altern.org> |    Why make M$-Bill richer & richer ?
debian-email:   <dirson@debian.org> |   Support Debian GNU/Linux:
                                    | Cheaper, more Powerful, more Stable !
http://www.altern.org/ydirson/      | Check <http://www.debian.org/>

Message #15 received at 48312-close@bugs.debian.org (full text, mbox, reply):

From: Yann Dirson <dirson@debian.org>

To: 48312-close@bugs.debian.org

Subject: Bug#48312: fixed in e2fsprogs 1.16-2

Date: 26 Oct 1999 18:55:15 -0000

We believe that the bug you reported is fixed in the latest version of
e2fsprogs, which has been installed in the Debian FTP archive:
e2fsprogs_1.16-2_i386.deb
  to dists/potato/main/binary-i386/base/e2fsprogs_1.16-2.deb
  replacing e2fsprogs_1.16-1.deb
e2fslibs-dev_1.16-2_i386.deb
  to dists/potato/main/binary-i386/devel/e2fslibs-dev_1.16-2.deb
  replacing e2fslibs-dev_1.16-1.deb
ss-dev_2.0-1.16-2_i386.deb
  to dists/potato/main/binary-i386/devel/ss-dev_2.0-1.16-2.deb
  replacing ss-dev_2.0-1.16-1.deb
e2fsprogs_1.16-2.diff.gz
  to dists/potato/main/source/base/e2fsprogs_1.16-2.diff.gz
  replacing e2fsprogs_1.16-1.diff.gz
uuid-dev_1.2-1.16-2_i386.deb
  to dists/potato/main/binary-i386/devel/uuid-dev_1.2-1.16-2.deb
  replacing uuid-dev_1.2-1.16-1.deb
comerr-dev_2.0-1.16-2_i386.deb
  to dists/potato/main/binary-i386/devel/comerr-dev_2.0-1.16-2.deb
  replacing comerr-dev_2.0-1.16-1.deb
e2fsprogs_1.16-2.dsc
  to dists/potato/main/source/base/e2fsprogs_1.16-2.dsc
  replacing e2fsprogs_1.16-1.dsc

Note that this package is not part of the released stable Debian
distribution.  It may have dependencies on other unreleased software,
or other instabilities.  Please take care if you wish to install it.
The update will eventually make its way into the next released Debian
distribution.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 48312@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yann Dirson <dirson@debian.org> (supplier of updated e2fsprogs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----

Format: 1.6
Date: Tue, 26 Oct 1999 01:17:36 +0200
Source: e2fsprogs
Binary: e2fslibs-dev ss-dev uuid-dev e2fsprogs comerr-dev
Architecture: source i386
Version: 1.16-2
Distribution: unstable
Urgency: low
Maintainer: Yann Dirson <dirson@debian.org>
Description: 
 comerr-dev - The Common Error Description library - headers and static librari
 e2fslibs-dev - The headers and static libraries for ext2fs-aware tools-developme
 e2fsprogs  - The EXT2 file system utilities and libraries.
 ss-dev     - Command-line interface parsing library - headers and static libra
 uuid-dev   - Universally unique id library - headers and static libraries.
Closes: 48312
Changes: 
 e2fsprogs (1.16-2) unstable; urgency=low
 .
   * Fixed build of a link list in fsck.c (Closes: #48312).
Files: 
 bc2d9f87f172675e54f27c6fa625839f 622 base required e2fsprogs_1.16-2.dsc
 574462db5e20a6757ba52135394414bf 15753 base required e2fsprogs_1.16-2.diff.gz
 e8b34f92a3ab6f3eb5212f0123a3040e 183882 base required e2fsprogs_1.16-2_i386.deb
 ff9705b67b73770019919bedb72aedef 82246 devel extra e2fslibs-dev_1.16-2_i386.deb
 364f001ee8134b83396230d648dfdfcf 29272 devel extra comerr-dev_2.0-1.16-2_i386.deb
 be71ebd8d95423ddeb4613654818791c 13404 devel extra ss-dev_2.0-1.16-2_i386.deb
 81e4613e24559fa84134a612ad1b06fe 13210 devel extra uuid-dev_1.2-1.16-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3ia
Charset: noconv

iQB1AwUBOBToDWWBdJ4Do/f1AQEUzQL/aFkLAZhh4a1a1LhFy/HIXRueFmUc0V17
wvqFYlnxK83KBazAPb5gxdyHo3QTV4N4MaJg4GYRnGUY9u7QIYHnmmJO85D534Nz
BgHOUarjpHs/kN5IdOhSD2Nx+rUdi+lx
=DUx7
-----END PGP SIGNATURE-----

Message #20 received at 48312@bugs.debian.org (full text, mbox, reply):

From: "Theodore Y. Ts'o" <tytso@mit.edu>

To: Yann Dirson <ydirson@altern.org>

Cc: idsfa@poboxes.com, 48312@bugs.debian.org

Subject: Re: Bug#48312: fsck parallel mode broken

Date: Tue, 26 Oct 1999 15:24:46 -0400

Yeah, that was a pretty nasty bug.  It was a typo on my part, and a
silly error to boot.  Thanks for catching it.

I've released e2fsprogs 1.17 that has that problem fixed, as well as few
other problems which didn't make 1.16.  

						- Ted

P.S.  I found a clean way to handle the HURD patches that should work
even if the FSF later decides that all Linux systems should define
__GNU__ :-)

Send a report that this bug log contains spam.