[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1031089: marked as done (rocr-runtime: Segfault in hsa_init on Debian-derived systems)

Your message dated Sun, 19 Feb 2023 17:49:12 +0000
with message-id <E1pTnoG-00EbQp-Nb@fasolo.debian.org>
and subject line Bug#1031089: fixed in rocr-runtime 5.2.3-3
has caused the Debian Bug report #1031089,
regarding rocr-runtime: Segfault in hsa_init on Debian-derived systems
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1031089: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1031089
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: rocr-runtime
Version: 5.2.3-2
Severity: important
Tags: ftbfs patch upstream

Let's make that a bug.

Cordell Bloor, on 2023-02-08:
> One of the things that has vexxed me about the 'universe' packages for ROCm
> on Ubuntu is that they simply didn't work. On Ubuntu 22.04 and 22.10, even
> just a simple `rocminfo` invocation would crash with a segfault. I assumed
> that there was something that Ubuntu was doing to the Debian packages that
> was breaking them, but I was wrong.
> 
> I've finally figured out what is happening. This is the static
> initialization order fiasco [1]. Inside libhsa-runtime64, there are two
> variables with static storage duration in different translation units, and
> there is an implicit expectation that one will be initialized before the
> other. That expectation happens to be satisfied when rocr-runtime is built
> for Debian, but the order just happens to be different when the package is
> built for Ubuntu and that expectation is violated. When the variables are
> initialized out-of-order, some data that is copied from one static variable
> to another is copied before it is initialized (including pointers which are
> therefore unexpectedly null).
> 
> This problem technically does not affect the Debian binary package, but only
> by coincidence. Any change to the build toolchain could potentially change
> the initialization order and thereby introduce this defect into the library
> the next time it is built from source.
> 
> I'm not sure what priority this issue is for Debian. In fact, I'm not sure
> if it even is technically a bug on Debian given that it hasn't manifested
> itself yet. Nevertheless, I hope we can upload a fix for this relatively
> quickly given that both Debian [2] and Ubuntu [3] will be freezing packages
> soon.

This is not affecting Debian now so doesn't make the issue
release critical per se, but it sounds like it could later.
If it is to happen on stabilisation of bookworm, it can have
rather concerning consequences.  I think it's well worth an
important bug, which can be fixed during freeze.

> I've prepared a patch to ensure the correct initialization order [4]. If
> there's anything more that I can do to help, please let me know.

Thanks for your patch, the entry will be tagged appropriately.

> Sincerely,
> Cory Bloor
> 
> [1]: https://en.cppreference.com/w/cpp/language/siof
> [2]: https://release.debian.org/bookworm/freeze_policy.html
> [3]: https://discourse.ubuntu.com/t/lunar-lobster-release-schedule/27284
> [4]: https://salsa.debian.org/rocm-team/rocr-runtime/-/commit/b4bfd3e07426034ba65a5f4adf05b41c23c3eb81

Have a nice day,  :)
-- 
Étienne Mollier <emollier@emlwks999.eu>
Fingerprint:  8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
Sent from /dev/pts/1, please excuse my verbosity.

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: rocr-runtime
Source-Version: 5.2.3-3
Done: Cordell Bloor <cgmb@slerp.xyz>

We believe that the bug you reported is fixed in the latest version of
rocr-runtime, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1031089@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cordell Bloor <cgmb@slerp.xyz> (supplier of updated rocr-runtime package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 19 Feb 2023 03:34:29 -0700
Source: rocr-runtime
Architecture: source
Version: 5.2.3-3
Distribution: unstable
Urgency: medium
Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
Changed-By: Cordell Bloor <cgmb@slerp.xyz>
Closes: 1031089
Changes:
 rocr-runtime (5.2.3-3) unstable; urgency=medium
 .
   * Team upload.
 .
   * add 0003-fix-static-initialization-order.patch
     to prevent crash in hsa_init (Closes: #1031089)
   * update d/copyright
   * d/control: update standards version
Checksums-Sha1:
 352ebfc46c35ea318450132ddd3c90a745af1179 2359 rocr-runtime_5.2.3-3.dsc
 0297df2ce3c5f7cb5e51e818ac5e1d64bf1a7214 7380 rocr-runtime_5.2.3-3.debian.tar.xz
 9da7ef44f7cb4d2655c97863af9fe04c1fa229ed 5807 rocr-runtime_5.2.3-3_source.buildinfo
Checksums-Sha256:
 eb977de327018cb7d4df4912a32440fa21de070d25992153f1d62b873c4c4561 2359 rocr-runtime_5.2.3-3.dsc
 fee4b5cda04149ebee3111113256a43173eb7ec722ba059d98036ae1db46e783 7380 rocr-runtime_5.2.3-3.debian.tar.xz
 851ff64b457d2fea201dac8f4ccb254dd1e4853057560985facb4cfa10ecce80 5807 rocr-runtime_5.2.3-3_source.buildinfo
Files:
 7b5cf5b40dabfc6e59eb0f124a0e84ac 2359 video optional rocr-runtime_5.2.3-3.dsc
 55250859ef6bd02ba29e15347bf8e9f4 7380 video optional rocr-runtime_5.2.3-3.debian.tar.xz
 ca92114824bcf78ebb821391f0f9f64a 5807 video optional rocr-runtime_5.2.3-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQZ9+mkfDq5UZ8bCjOZU6N95Os2sFAmPyWjkACgkQOZU6N95O
s2tMNg//c8nvsY/hNsIXCxQSglR1XNKLcL9onCAcS3IWTWgJ8FPsMqeLq4xBLwNc
kMYFXk5+ECfG9P14YMnIqWQbDUvwWYBBZ9VcyfKVJRG+M34iskrE0fU9m6XAsxY6
7c5Y4t6q4x9VGsKlpTtwNlkt/bYS9/zfXnl9V932AKUvnljcuEhpkwhmUNXrg/MI
5ElNeFa/l6XsqLvk1QChOjHAuoH9k4eCqhkTHjPY7JNIQsXLM7YkFSxYdHzQFVEz
UxKRZnUv74WOIfumO69PfSmsl+FR7H/uv1LAHQ8GropEiQX7GK4yq19fLoP3rVz7
yQ2vqF2lbcRkcfQ5qWhIMmk7tMNwfObN7ZGynF/9TMMXynH5SpuJMJ4OKcOk5VW3
rQVSEo8fL0X3gvT5j5Q/x4I5F/f408LjAxf3Ch4GYDhBVy8NddoJNdiDzAg7Z9Uh
hgFLBF/d/4ctvceLB1bkRU3j3iqDoyhlcTV6r0FRjZnq7ricgt58BPE+Jre77Olp
2p0E4j6nB3giXYLHMaCjbK4BoV/nZKe5HleQRjDxn6RFBesUpoheq/5oGPkruxnF
ZhJyKqNbzP7yp2Q2MpVhBajkC1x4PUN21w6VLlXeiAU3sBqNuqyAdz3IA/3P0/k0
CPFr3nUpDSv79f+dYNjWpEedNKjERX0YjBxpOI0EYdOrPYZmcoo=
=0ea2
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: