[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: About that Alpha kernel bug mentioned in beta3 errata



On Sun, 4 Apr 2004, Herbert Xu wrote:

> Bjoern Brill <brill@fs.math.uni-frankfurt.de> wrote:
> >
> > The symlink gets created in drivers/cdrom/cdrom.c:register_cdrom():
> >
> >                if (pos >= 0) {
> >                        char vname[16];
> >                        sprintf (vname, "cdrom%d", cdi->number);
> >                        strncpy (rname + pos, "../", 3);
> >                        devfs_mk_symlink (devfs_handle, vname,
> >                                          DEVFS_FL_DEFAULT,
> >                                          rname + pos, &slave, NULL);
> >                        devfs_auto_unregister (cdi->de, slave);
> >                }
> >
> > That piece of code is shared by all kinds of cdroms, and all
> > architectures... so how can it be broken on alpha and not on x86,
> > and with SCSI but not IDE? I think the strncpy (rname + pos, "../", 3);
> > call fails, and strncpy is arch specific. This would mean that, in the
> > end, alpha stxncpy.S is broken again. I don't know enough alpha assembly
>
> Good catch.
>
> Can you either build a new kernel with stxncpy.S disabled, or try
> the image from
>
> http://gondor.apana.org.au/~herbert/debian/kernel/binary/2.4.25/alpha-generic/
>
> and see if the problem goes away?
>
> If it does, then I'll turn stxncpy off until it's fixed.
>

Bingo.

I've put your test kernel and the initrd.gz from the same installer
CD as before (sarge-alpha-businesscard.iso, Mar 31 daily build) somewhere
in my /boot partition and pointed aboot to them, together with the
installer's default boot arguments (ramdisk_size=16384 root=/dev/ram
devfs=mount,dall), while having the installer CD in the drive. This
should ensure nothing has changed except replacing the 2.4.25-1-generic
kernel with your test kernel.

Result: CD drive is properly detected, symlink in /dev/cdroms looks alright.
(Should it matter: this is on a EV5 machine.)


Regards,

Bjoern
--
Bj"orn Brill <brill@fs.math.uni-frankfurt.de>
Frankfurt am Main, Germany



Reply to: