[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#830308: d-i.debian.org: l10n-sync script breaks headers in individual package files in some situations



Quoting Steve McIntyre (steve@einval.com):

> Arg, sorry. :-( It's very easy to make mistakes when editing large
> numbers of files like this by hand. I double-checked the diffs,
> even. Could we add some commit-time checking to run msgfmt etc. and
> warn on errors?

Yes, this is exactly what I did in l10n-sync before reverting the
changes. It has been tested locally with the "broken" files in place
and the script stopped as expected before committing.

Indeed, the breakage happened when the 5 "sublevels" PO files for
Banish and Belarusian are temporarily concatenated into one single PO
file, which "msgcat". The single PO file is then used for synchronize
the PO files in individual packages.

The "msgcat" command (line 585 in l10n-sync) was indeed not protected
by error handling in our scripts, while most gettext commands are.

The fix I committed added a prior test of merged PO files with "msgfmt
-c" (and exiting if that fails) and I just added one more error
handling in the "msgcat" command itself.


Attachment: signature.asc
Description: PGP signature


Reply to: