Hi, Diederik de Haas <didi.debian@cknow.org> (2023-04-30): > I suggest we stick to `brcmfmac43455-sdio.raspberrypi,4-model-b.txt` as that > is its name in the upstream repo: > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git Yes please. > > And a nitpick: the way this appears in the hw-detect prompt screen in the > > installer is a bit odd, because spaces in the filenames are replaced with > > newlines. That might be nice to fix at the same time if we can. > > AFAIC it's a bit more then a nitpick as it identified a/several bugs in the > script. Run it through `shellcheck` and you'll see a whole bunch of*: > SC2086 (info): Double quote to prevent globbing and word splitting. > https://www.shellcheck.net/wiki/SC2086 > > And that's exactly what happens or will happen. Even though the RPi4 filename > doesn't contain spaces, there are several in the `brcm` directory that do. > I didn't check other directories, but I'd expect that filenames with a space is > NOT an anomaly. > > *) and several other warnings/suggestions We won't rewrite hw-detect for bookworm, nor will we make it “shellcheck compliant”. Now is definitely not the time to deal with such things, and yes I'm going to call system files (e.g. package-shipped) with spaces an anomaly. People are much than welcome to put energy into making hw-detect more robust in the future, but even knowing some bits about it, it's some kind of a maze and I *really* don't want to lose any feature for the generic cases (non-crazy filenames). It's easy enough to just not use spaces in filenames in the first place. Cheers, -- Cyril Brulebois (kibi@debian.org) <https://debamax.com/> D-I release manager -- Release team member -- Freelance Consultant
Attachment:
signature.asc
Description: PGP signature