[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH reproducible-notes] Remove non-sense wireguard note



On Tue, Jan 21, 2020 at 5:25 PM Sam Hartman <hartmans@debian.org> wrote:
>
> >>>>> "Jonathan" == Jonathan Carter <jcc@debian.org> writes:
>
>     Jonathan> On 2020/01/21 16:43, Jason A. Donenfeld wrote:
>     >> This note doesn't make sense. It's either entirely invalid or so poorly
>     >> written that it's useless. As the author of the code in question, I've
>     >> been unable to ascertain what the note is about, and an email to the note
>     >> author hasn't yielded any understanding.
>
>     Jonathan> Well, if that's the way you approach them then you shouldn't at all be
>     Jonathan> surprised if you don't get a response.
>
> It might promote a better community to provide constructive advice
> rather than just telling people they are doing a bad job.
>
> To that end, the original commit message might be improved by saying
> something like "I could not understand the note and didn't get
> clarification when I reached out to the author." rather than including
> worgs like "completely wrong" or "useless".

Okay.

Anyway, here's a patch. I suppose you can now choose to commit this to
the repo, justify the existence of the lines it removes, or simply
ignore this email thread entirely.


Reply to: