[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#32191: dpkg-dev: dpkg-buildpackage options have to be in a certain order



On Wed, Jan 20, 1999 at 08:01:30PM +0100, brinkmd@debian.org wrote:
> Package: dpkg-dev
> Version: 1.4.1
> 
> Hi,
> 
> dpkg-buildpackage will not correctly pass "-B" option to dpkg-genchanges, if
> it is not at the end of the command line:
> 
> dpkg-buildpackage -ahurd-i386 -B -rfakeroot -nc
> [...]
> dpkg-genchanges will complain about some package of architecture All which
> is in control but not in files file.
> 
> dpkg-buildpackage -ahurd-i386 -rfakeroot -nc -B
> 
> will work without problems.
> 
> Note that this is a subtle problem. I don't know enough shell programming to
> fix it. dpkg-buildpackage should probably add the options to a shell
> variable array and pass that to dpkg-genchanges instead doing some
> incomprehensible magic.
> 
> "man bash" has some promising text in section "Arrays".


Ooooops.  This one's my fault, I broke -b/-B when I added -nc.  Here's
a patch.

Dan

/--------------------------------\  /--------------------------------\
|       Daniel Jacobowitz        |__|     CMU, CS class of 2002      |
|   Debian GNU/Linux Developer    __   Part-Time Systems Programmer  |
|         dan@debian.org         |  |        drow@cs.cmu.edu         |
\--------------------------------/  \--------------------------------/
--- /usr/bin/dpkg-buildpackage	Sun Nov  1 12:50:45 1998
+++ ./dpkg-buildpackage	Wed Jan 20 15:51:10 1999
@@ -73,7 +73,7 @@
 	-sa)	sourcestyle=-sa ;;
 	-sd)	sourcestyle=-sd ;;
 	-tc)	cleansource=true ;;
-	-nc)	noclean=true; binaryonly=-b ;;
+	-nc)	noclean=true; if test "X$binaryonly" = "X"; then binaryonly=-b; fi ;;
 	-b)	binaryonly=-b ;;
 	-B)	binaryonly=-B; binarytarget=binary-arch ;;
 	-v*)	since="$value" ;;

Reply to: