[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#762906: krb5-auth-dialog debug output



On Mon, Oct 20, 2014 at 03:23:24PM +0200, Wolfgang Schweer wrote:
> On Mon, Oct 20, 2014 at 10:14:35AM +0200, Guido Günther wrote:
> > > Thanks. I can reproduce it here now (you just have to clear the
> > > principal names from the preferences). The bug doesn't seem to be in
> > > krb5-auth-dialog itself since we get the prompt passed in from the
> > > Kerberos libs and it's already lacking the username. I'll investigate
> > > further.
> > 
> > The attached patch should fix this.
> >  -- Guido
> 
> > diff --git a/src/ka-kerberos.c b/src/ka-kerberos.c
> > index fc6d63f..a17dee3 100644
> > --- a/src/ka-kerberos.c
> > +++ b/src/ka-kerberos.c
> > @@ -649,6 +649,10 @@ ka_parse_name (KaApplet *applet, krb5_context krbcontext,
> >          krb5_free_principal (krbcontext, *kprinc);
> >  
> >      g_object_get (applet, KA_PROP_NAME_PRINCIPAL, &principal, NULL);
> > +    if (principal[0] == '\0') {
> > +        g_free (principal);
> > +        principal = g_strdup (g_get_user_name());
> > +    }
> >      ret = krb5_parse_name (krbcontext, principal, kprinc);
> >  
> >      g_free (principal);
> 
> With the patch applied, the tray icon now disappears if clicked.
> 
> krb5-auth-dialog (with patch) compiled again with '--enable-debug' and 
> running it out of a terminal shows that the reason is a segmentation 
> fault.

Can you get me a backtrace with gdb (gdb -c core
src/krb5-auth-dialog)? I can only assume that principal is NULL which
shouldn't happen. I doesn't crash here of course.
Cheers,
 -- Guido


Reply to: