[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#286416: marked as done (php-elisp: Wrong indentation of switch())

Your message dated Thu, 26 Sep 2019 20:32:37 -0400
with message-id <20190927003226.GA5803@DigitalMercury.dynalias.net>
and subject line Re: Bug#286416: php-elisp: Wrong indentation of switch()
has caused the Debian Bug report #286416,
regarding php-elisp: Wrong indentation of switch()
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
286416: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=286416
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: php-elisp
Version: 1.1.0-2
Severity: normal

I think php-elisp makes wrong indentation of the switch/case
statements when switch() is used inside any curly braces like for() or
function().


First example, switch is aligned on the first column, php-elisp makes
a correct indentation:

switch ($country) {
 case 'France':
   $phone_prefix=33;
   break;
}


Second example, switch is used inside a function() and is not aligned
on the first column, php-elisp makes an _incorrect_ indentation:

function foo()
{
  switch ($country) {
  case 'France':
    $phone_prefix=33;
    break;
  }
}

The second example should be indented as:

function foo()
{
  switch ($country) {
    case 'France':
      $phone_prefix=33;
      break;
  }
}

I hope I was clear.  Please do not hesitate to ask me some more
information if you can't reproduce it.

Thanks.

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.9-1-686
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages php-elisp depends on:
ii  emacs21-nox [emacsen]         21.3+1-8   The GNU Emacs editor (without X su

-- no debconf information

-- 
Cyril Bouthors

Attachment: pgp614EFvgoHU.pgp
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Hi Cyril,

On Tue, Feb 05, 2019 at 01:44:43AM -0700, Nicholas D Steeves wrote:
> Hi,
> 
> The Debian Emacsen Team just adopted this package.  If you're running
> Debian 10 (Stretch) or newer, would you please consider testing an
> updated version of php-elisp and confirming whether 1.21.0-1 is still
> affected?
> 

Upstream writes:

    If you change the php-style to drupal you should be able to
    achieve the desired indendation: M-x php-set-style and then select
    drupal. (https://github.com/emacs-php/php-mode/issues/138)

I'm closing this bug, because it's from 2004, has not received a
follow-up from you since then, and because upstream has provided a
workaround.

Regards,
Nicholas

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: