[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1069908: elpa-debian-el: X-Debbugs-Cc: is weirdly overpopulated with duplicate or broken entries



Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> Control: tags 1069908 - moreinfo
>
> Hi Xiyue Deng--
>
> On Wed 2024-05-08 19:13:37 -0700, Xiyue Deng wrote:
>> For this issue, it looks like debian-bug.el is passing "--list-cc=none"
>> to reportbug which then becomes part of the message.  This is fixed in
>> [1] and pending sponsoring.
>
> thanks for this analysis and work!
>

Sure thing!

>> I cannot seem to reproduce this.  debian-bug.el tries to get full name
>> and email from several sources, such as user-full-name,
>> user-mail-address, envvars like DEBFULLNAME, DEBNAME, NAME, DEBEMAIL,
>> EMAIL, REPORTBUGEMAIL, etc.  So there may be something unconventional
>> that triggered this.  Can you check if your configuration set those info
>> in multiple places?  What happens if you clear some of them?
>
> Here are the plausibly relevant env vars i have set (generated by
> running `M-1 M-! printenv` from within emacs itself and then manually
> pruning for things that include either my name or e-mail address):
>
> ```
> DEBFULLNAME=Daniel Kahn Gillmor
> DEBEMAIL=dkg@fifthhorseman.net
> DEBSIGN_MAINT=Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> EMAIL=dkg@fifthhorseman.net
> ```
>
> None of this seems wrong to me; or even if it does, it still ought to be
> able to be correctly interpreted by debian-bug.el, and de-duplicated.
>
> I decided to look in ~/.reportbugrc and i find i have the following settings:
>
> ```
> reportbug_version "5.0"
> mode standard
> ui text
> no-cc
> list-cc-me
> ```
>
> I have no recollection of setting either no-cc or list-cc-me, and i
> confess i don't really understand why these options are distinct.
> Perhaps this was from ancient run (or runs?) of `reportbug --configure`?
>
> Without modifying any env vars, I tried commenting out both the `no-cc`
> and `list-cc-me` options in ~/.reportbugrc, and with both of those
> removed, the generated X-Debbugs-Cc line after a `M-x debian-bug` was
> just:
>
> ```
> X-Debbugs-Cc: none, Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> ```
>

Thanks for testing.  So what's happening is that the info debian-bug get
from the envvars are your full name and your email address.  On the
other hand with "list-cc-me" you only get the email part there.  So from
debian-bug point of view those are different info so the de-duplication
doesn't happen (if both have the same info debian-el will dedup though).

Ideally there should be a way to let reportbug ignore the configuration
files and only process options passing through command line so that user
configuration doesn't change its behavior, but as far as I can tell
there is no option to do that (yet)[1].  Hopefully it will be
implemented eventually.

> So perhaps with the fix you have pending, this will be resolved.
>

Sounds good.

> Thanks!
>
>         --dkg
>

[1] https://salsa.debian.org/reportbug-team/reportbug/-/blob/master/reportbug/utils.py?ref_type=heads#L1458
-- 
Xiyue Deng

Attachment: signature.asc
Description: PGP signature


Reply to: