[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Transitioning golang-goprotobuf to unstable?



Am 31.01.22 um 20:26 schrieb Peymaneh:
Am 31.01.22 um 14:45 schrieb Shengjing Zhu:
On Mon, Jan 31, 2022 at 9:32 AM Peymaneh <peymaneh@posteo.net> wrote:

Yes, it is not a direct dependency, Caddy requires
1. golang-github-google-cel-go-dev, which requires
2. golang-github-google-cel-spec-dev, which requires
3. golang-goprotobuf-dev (>= 1.4.3~)

I see there are 2 problems.

1. For golang-github-google-cel-spec-dev, if you follow the rule that
we should not use generated files provided by upstream(as they are not
in preferred form of modification) , then you can get rip of the
dependency of golang-goprotobuf-dev. Because when you regenerate pb.go
files by the new protoc-gen-go,  the result pb.go only depends
golang-google-protobuf-dev.
2. For golang-github-google-cel-go-dev, I think the cel-server package
can be dropped. When I read the upstream readme, I think it's mainly a
library. IMO The included server binary has little value for normal
users. After dropping the cel-server part, then there's no dependency
on golang-github-google-cel-spec-dev.
But I was wrong about the dependencies. Removing the dependency on golang-github-google-cel-spec works out fine, but turns out golang-github-google-cel-go still has indirect build-deps to golang-goprotobuf 1.4.1 via golang-google-genproto (>=0.0~git20210726.e7812ac-1~exp0), which is in experimental. I did not realize this dependency because the dependency on golang-github-google-cel-spec-dev would pull it in anyway.

(There is also some *pb.go files depending on golang-goprotobuf that need to be regenerated, but I could not test this because protoc-gen-go will not install alongside golang-goprotobuf, which is pulled in by golang-google-genproto.)

So this newer version of golang-google-genproto requires golang-goprotobuf-dev (>= 1.4.1~), but if I understand correctly, then from looking at its source that's not strictly necessary, because its *pb.go files, that cause the dependency on golang-goprotobuf, could be regenerated during build with protoc-gen-go?

Would seem to me that instead of getting golang-goprotobuf into unstable, most straightforward would be to get rid of golang-google-genproto's dependency on golang-goprotobuf? Do I get this right?

If yes, after going through the upstream docs, I think/hope I understand the matter sufficiently to try fix this myself if wished

Kind regards,
Peymaneh

[1] https://lists.debian.org/debian-go/2021/08/msg00061.html

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: