[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Attempt to build package golang-github-mvdan-sh for apptainer



Hi,

thanks a lot for all the hints I've got.  Regarding including vendored
copies I agree in the actual case with Nilesh to package it separately.

Am Mon, Feb 14, 2022 at 02:44:09PM +0530 schrieb Nilesh Patra:
> On 2/14/22 2:12 PM, Andreas Tille wrote:
> > Hi,
> > 
> > Unfortunately the build of this
> > package breaks as you can see in salsa-ci[4].  (BTW, the
> > debian/gitlab-ci.yaml file which is automatically created by
> > dh-make-golang is not really helpful to spot build time errors and thus
> > I replaced this.)
> 
> You can add a build pipeline in salsa-ci.yml with some workarounds in addition
> with our golang one.
> But, I guess better do so centrally - need to check with Alois/Faust.

This would be helpful.
 
> > Any idea how to fix this build?
> 
> I pushed a fix. BTW, source package name and binary package names are wrong (again)
> It should be golang-mvdan-sh, in accordance with for example this[1], and this[2]

My problem is that I simply use `dh-make-golang` as is and I now take
away the message that this is not safe regarding package names.  In
a previous case Shengjing Zhu gave me the hint[3] to rather use

   dh-make-golang -allow_unknown_hoster

and may be in the given case this would have helped as well - but I need
to admit I have no idea how to do it properly (nor to verify whether I
did it properly.  I checked the team policy[4] but it is not very
verbose about the problem I have.

I think I need to package the following projects:

  https://github.com/apptainer/container-key-client
  https://github.com/apptainer/sif

I'm wondering whether I should give dh-make-golang another chance or
should I rather copy the debian/ dir of apptainer and work from there
(keeping these packages in hpc team might make sense anyway).

Kind regards

     Andreas.

> [1]: https://tracker.debian.org/pkg/golang-mvdan-editorconfig
> [2]: https://tracker.debian.org/pkg/golang-mvdan-gofumpt
[3] https://lists.debian.org/debian-go/2022/02/msg00011.html 
[4] https://go-team.pages.debian.net/packaging.html#_using_dh_make_golang



-- 
http://fam-tille.de


Reply to: