[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1064298: marked as done (libhamlib4t64: ineffective replaces due to /usr-move)

Your message dated Thu, 29 Feb 2024 10:01:18 +0000
with message-id <E1rfdE6-00Ag8O-19@fasolo.debian.org>
and subject line Bug#1064298: fixed in hamlib 4.5.5-3.2
has caused the Debian Bug report #1064298,
regarding libhamlib4t64: ineffective replaces due to /usr-move
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1064298: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064298
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libhamlib4t64
Version: 4.5.5-3.1~exp1
Severity: serious
Tags: patch
User: helmutg@debian.org
Usertags: dep17p1
Control: affects -1 + libhamlib4
X-Debbugs-Cc: vorlon@debian.org, mwhudson@debian.org

libhamlib4t64 introduced Replaces for libhamlib4 to take over its files
and in that process it also takes over
/usr/lib/udev/rules.d/60-libhamlib4.rules. This file also is in
libhamlib4 in an aliased location. Moving a file from / to /usr and
between packages causes file loss (DEP17 P1). Hence, I'm extending the
existing mitigation for DEP17 P7 (M-A:same shared file loss) to cover
the new P1 problem introduced by time64. See my attched patch. The
protective diversion will be kept beyond postinst and stay around. Since
the earlier diversion in libhamlib4 was removed in postinst, there
cannot be any conflict on diversions. I tested the upgrade using
piuparts.

Helmut

diff --minimal -Nru hamlib-4.5.5/debian/changelog hamlib-4.5.5/debian/changelog
--- hamlib-4.5.5/debian/changelog	2024-02-17 04:43:05.000000000 +0100
+++ hamlib-4.5.5/debian/changelog	2024-02-19 19:50:40.000000000 +0100
@@ -1,3 +1,11 @@
+hamlib (4.5.5-3.1~exp1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Extend DEP17 P7 mitigation (protective diversion for udev rules) to also
+    cover P1 (package rename). (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 19 Feb 2024 19:50:40 +0100
+
 hamlib (4.5.5-3.1~exp1) experimental; urgency=medium
 
   * Non-maintainer upload.
diff --minimal -Nru hamlib-4.5.5/debian/libhamlib4t64.lintian-overrides hamlib-4.5.5/debian/libhamlib4t64.lintian-overrides
--- hamlib-4.5.5/debian/libhamlib4t64.lintian-overrides	2024-02-17 04:43:05.000000000 +0100
+++ hamlib-4.5.5/debian/libhamlib4t64.lintian-overrides	2024-02-19 19:50:40.000000000 +0100
@@ -1,4 +1,4 @@
 # protective diversion for upgrades of files moved from / to /usr
 # see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1056692
-libhamlib4t64: diversion-for-unknown-file lib/udev/rules.d/60-libhamlib4t64.rules [preinst:14]
+libhamlib4t64: diversion-for-unknown-file lib/udev/rules.d/60-libhamlib4.rules [preinst:*]
 libhamlib4t64: package-name-doesnt-match-sonames libhamlib4
diff --minimal -Nru hamlib-4.5.5/debian/libhamlib4t64.postinst hamlib-4.5.5/debian/libhamlib4t64.postinst
--- hamlib-4.5.5/debian/libhamlib4t64.postinst	2024-02-17 04:43:05.000000000 +0100
+++ hamlib-4.5.5/debian/libhamlib4t64.postinst	2024-02-19 13:56:14.000000000 +0100
@@ -7,17 +7,6 @@
 
 rm -f /etc/udev/rules.d/60-libhamlib4.rules
 
-# begin-remove-after: released:forky
-# protective diversion of files moved from / to /usr, to avoid file loss.
-# Only for upgrades.
-if [ "$1" = "configure" ]; then
-    # At this point, the package will have installed the same file in */usr*.
-    dpkg-divert --package usr-is-merged --no-rename \
-        --divert /lib/udev/rules.d/60-libhamlib4.rules.usr-is-merged \
-        --remove /lib/udev/rules.d/60-libhamlib4.rules
-fi
-# end-remove-after
-
 #DEBHELPER#
 
 exit 0
diff --minimal -Nru hamlib-4.5.5/debian/libhamlib4t64.postrm hamlib-4.5.5/debian/libhamlib4t64.postrm
--- hamlib-4.5.5/debian/libhamlib4t64.postrm	2024-02-17 04:43:05.000000000 +0100
+++ hamlib-4.5.5/debian/libhamlib4t64.postrm	2024-02-19 13:56:50.000000000 +0100
@@ -5,16 +5,13 @@
 
 dpkg-maintscript-helper rm_conffile /etc/udev/60-libhamlib4.rules -- "$@"
 
-# begin-remove-after: released:forky
 # protective diversion of files moved from / to /usr, to avoid file loss.
 # Only for upgrades.
 if [ "$1" = "remove" ] && [ "$DPKG_MAINTSCRIPT_PACKAGE_REFCOUNT" = "1" ]; then
-    # Cleanup in case package is removed before upgrade is finished (postinst ran).
     dpkg-divert --package usr-is-merged --no-rename \
         --divert /lib/udev/rules.d/60-libhamlib4.rules.usr-is-merged \
         --remove /lib/udev/rules.d/60-libhamlib4.rules
 fi
-# end-remove-after
 
 #DEBHELPER#
 
diff --minimal -Nru hamlib-4.5.5/debian/libhamlib4t64.preinst hamlib-4.5.5/debian/libhamlib4t64.preinst
--- hamlib-4.5.5/debian/libhamlib4t64.preinst	2024-02-17 04:43:05.000000000 +0100
+++ hamlib-4.5.5/debian/libhamlib4t64.preinst	2024-02-19 13:55:31.000000000 +0100
@@ -5,15 +5,13 @@
 
 dpkg-maintscript-helper rm_conffile /etc/udev/60-libhamlib4.rules -- "$@"
 
-# begin-remove-after: released:forky
 # protective diversion of files moved from / to /usr, to avoid file loss.
-# Only for upgrades.
-if [ "$1" = "upgrade" ]; then
+if [ "$1" = upgrade ] || [ "$1" = install ]; then
+    # The diversion should be removed after trixie is released.
     dpkg-divert --package usr-is-merged --no-rename \
         --divert /lib/udev/rules.d/60-libhamlib4.rules.usr-is-merged \
         --add /lib/udev/rules.d/60-libhamlib4.rules
 fi
-# end-remove-after
 
 #DEBHELPER#

--- End Message ---
--- Begin Message --- 
Source: hamlib
Source-Version: 4.5.5-3.2
Done: Lukas Märdian <slyon@debian.org>

We believe that the bug you reported is fixed in the latest version of
hamlib, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1064298@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Lukas Märdian <slyon@debian.org> (supplier of updated hamlib package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 29 Feb 2024 08:17:32 +0000
Source: hamlib
Architecture: source
Version: 4.5.5-3.2
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Lukas Märdian <slyon@debian.org>
Closes: 1064090 1064298
Changes:
 hamlib (4.5.5-3.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Helmut Grohne ]
   * Extend DEP17 P7 mitigation (protective diversion for udev rules) to also
     cover P1 (package rename). (Closes: #1064298)
 .
 hamlib (4.5.5-3.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Rename libraries for 64-bit time_t transition.  Closes: #1064090
Checksums-Sha1:
 f357a29ab85a23c7c965acb5a4266de4cf9cbc8d 3125 hamlib_4.5.5-3.2.dsc
 d12e276a0f31773a9a79359e00bcdfd12e44d986 28224 hamlib_4.5.5-3.2.debian.tar.xz
 4a650431b31c3d25c2b6696e4ddcc49fbc7b5b32 12299 hamlib_4.5.5-3.2_source.buildinfo
Checksums-Sha256:
 cfb0da20939718b2b507641ec02a69fe27dc8b13e0592a05c67adcd9921b66b9 3125 hamlib_4.5.5-3.2.dsc
 549283dbdd48dc45007d321790731c83958933e7687ad606f53d8b7574b485dd 28224 hamlib_4.5.5-3.2.debian.tar.xz
 a106594941b32e89a7063bd5e482eb72a26655295b69519804bca35042f5db15 12299 hamlib_4.5.5-3.2_source.buildinfo
Files:
 639077f866720ce29d98088310430c6d 3125 hamradio optional hamlib_4.5.5-3.2.dsc
 59c636d440ad5b41ff74066526ced2ab 28224 hamradio optional hamlib_4.5.5-3.2.debian.tar.xz
 f01a86e90ff6ffd39c152e0220a41a1c 12299 hamradio optional hamlib_4.5.5-3.2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE496GmCL5m2y8NfJ5v322IrMDrIsFAmXgQfARHHNseW9uQGRl
Ymlhbi5vcmcACgkQv322IrMDrIu+ThAAn6GcER6EwDkcELBt1n9H6gGuaHEbFMvD
Hz9sDyOtYM3ycVAi3QsyVY4oqFkvuugVUJtXWX1oSC2crOympNzPs+782cgc86Xz
2k4iX4VMgdeRFykOv0YkySI6PZ47SoDL9PiEwN0S+NsCOvasfp7f8XiJeY+u7SK8
Ba6Nyb3wAtLV74d94PiUN4L/pRPjhQGQEkMEbsjYOfHwIdW43/oJmOv47u0+DpPE
7MUZDROAs3fJ/rxmQDa5U7R3i5ijTg+pyLHdy/ycRY3U87WXb5MZWOfJeW9xVwSm
4y5NEJAgc3ezQRBKS56xNAu9p95AFGGpdH9LDdE3JLsjf/tUvNYbPTVtdgo36UW2
YBR6sX7bsMbBYLdN+2nWzqQjEmRIMVTejhOMZBIbl9raFWydoXkdhrWF04ADZRkn
s4OZZke3Mi3BDpRuEAm6u5nMonHTI/m0yBK/sBwH8e7fvsj0JXtj6QytH+JtJ6Rb
oO55tOvqr7kWFrZcDzue0qkhCRqCYDx0zTEvGcTq5sNkIP6UxtMFKoAbnAKM4AU4
v5uamMDMQajmgZIIZGDzS2d5cbNrn09LBzARqq0bRBMiQw3M2MTi2EAq0hmCXOIg
J5GLglfLZ5KypIvJdfYa3l0YPALPVKhFZRIYC3Uk9jnXxRUEgCNCLifvFWngbqcC
Kt1nLUE+ZBA=
=eDBO
-----END PGP SIGNATURE-----

Attachment: pgp9i0KjFFIS3.pgp
Description: PGP signature


--- End Message ---
Reply to: