[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1066215: marked as done (soundmodem: FTBFS: kisspkt.c:762:9: error: implicit declaration of function ‘fchmod’ [-Werror=implicit-function-declaration])

Your message dated Mon, 25 Mar 2024 05:17:29 +0000
with message-id <E1roci9-00BXN8-TT@fasolo.debian.org>
and subject line Bug#1066215: fixed in soundmodem 0.20-7
has caused the Debian Bug report #1066215,
regarding soundmodem: FTBFS: kisspkt.c:762:9: error: implicit declaration of function ‘fchmod’ [-Werror=implicit-function-declaration]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1066215: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066215
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: soundmodem
Version: 0.20-6
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/libxml2  -I../matlib -I../libmisc -I../directx/include -I../directx/include/directx6  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -c -o audiofilein.o audiofilein.c
> kisspkt.c: In function ‘kiss_input’:
> kisspkt.c:505:14: warning: pointer targets in assignment from ‘unsigned char *’ to ‘char *’ differ in signedness [-Wpointer-sign]
>   505 |         endp = chan->pkt.kiss.ibuf + chan->pkt.kiss.ibufptr;
>       |              ^
> kisspkt.c:514:38: warning: pointer targets in passing argument 2 of ‘kiss_decode’ differ in signedness [-Wpointer-sign]
>   514 |                 kiss_decode(chan, cp1+1, cp2-cp1-1);
>       |                                   ~~~^~
>       |                                      |
>       |                                      char *
> kisspkt.c:451:62: note: expected ‘u_int8_t *’ {aka ‘unsigned char *’} but argument is of type ‘char *’
>   451 | static void kiss_decode(struct modemchannel *chan, u_int8_t *b, int len)
>       |                                                    ~~~~~~~~~~^
> kisspkt.c: In function ‘p3dreceive’:
> kisspkt.c:597:22: warning: unused variable ‘i’ [-Wunused-variable]
>   597 |         unsigned int i;
>       |                      ^
> kisspkt.c: In function ‘pktinit’:
> kisspkt.c:762:9: error: implicit declaration of function ‘fchmod’ [-Werror=implicit-function-declaration]
>   762 |         fchmod(slave, 0660);
>       |         ^~~~~~
> gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/libxml2  -I../matlib -I../libmisc -I../directx/include -I../directx/include/directx6  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -c -o chansim.o chansim.c
> gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/libxml2  -I../matlib -I../libmisc -I../directx/include -I../directx/include/directx6  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -c -o ptt.o ptt.c
> audioio.c: In function ‘iotransmitstop’:
> audioio.c:669:25: warning: unused variable ‘j’ [-Wunused-variable]
>   669 |         unsigned int i, j;
>       |                         ^
> audioio.c:669:22: warning: unused variable ‘i’ [-Wunused-variable]
>   669 |         unsigned int i, j;
>       |                      ^
> audioio.c:668:15: warning: unused variable ‘sbuf’ [-Wunused-variable]
>   668 |         short sbuf[256];
>       |               ^~~~
> alsaio.c: In function ‘open_alsa’:
> alsaio.c:256:9: warning: ‘snd_pcm_sw_params_set_xfer_align’ is deprecated [-Wdeprecated-declarations]
>   256 |         err = snd_pcm_sw_params_set_xfer_align(pcm_handle, swparams, 1);
>       |         ^~~
> In file included from /usr/include/alsa/asoundlib.h:56,
>                  from alsaio.c:55:
> /usr/include/alsa/pcm.h:1389:5: note: declared here
>  1389 | int snd_pcm_sw_params_set_xfer_align(snd_pcm_t *pcm, snd_pcm_sw_params_t *params, snd_pcm_uframes_t val) __attribute__((deprecated));
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> audioio.c: In function ‘iotxend’:
> audioio.c:293:9: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   293 |         read(audioio->audiofd, &s, sizeof(s));
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> audioio.c: In function ‘iotxstart’:
> audioio.c:302:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   302 |                 write(audioio->audiofd, &s, sizeof(s));
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ptt.c: In function ‘pttinit_sysfsgpio’:
> ptt.c:134:25: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   134 |                         write(fd, "low", 3);
>       |                         ^~~~~~~~~~~~~~~~~~~
> ptt.c: In function ‘pttsetptt’:
> ptt.c:397:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   397 |                 write(state->u.fd, state->ptt ? "1" : "0", 1);
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/libxml2  -I../matlib -I../libmisc -I../directx/include -I../directx/include/directx6  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2 -c -o pktberr.o pktberr.c
> ptt.c: In function ‘pttinit’:
> ptt.c:207:17: warning: ‘__builtin_strncpy’ specified bound 512 equals destination size [-Wstringop-truncation]
>   207 |                 strncpy(state->u.rig_ptr->state.rigport.pathname, path, FILPATHLEN);
>       |                 ^
> rm -f libcommon.a
> ar cru libcommon.a simd.o snprintpkt.o 
> ar: `u' modifier ignored since `D' is the default (see `U')
> ranlib libcommon.a
> rm -f liblog.a
> ar cru liblog.a log.o 
> ar: `u' modifier ignored since `D' is the default (see `U')
> ranlib liblog.a
> rm -f libpttio.a
> ar cru libpttio.a ptt.o 
> ar: `u' modifier ignored since `D' is the default (see `U')
> ranlib libpttio.a
> rm -f libaudioio.a
> ar cru libaudioio.a audioio.o alsaio.o audiofilein.o chansim.o 
> ar: `u' modifier ignored since `D' is the default (see `U')
> ranlib libaudioio.a
> gcc  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2  -Wl,-z,relro -o chansim simd.o pktsimple.o main.o ../afsk/libafsk.a ../fsk/libfsk.a ../pammodem/libpam.a ../pskmodem/libpsk.a ../newqpsk/libnewqpsk.a ../p3dmodem/libp3d.a liblog.a libaudioio.a libpttio.a ../matlib/libmat.a ../libmisc/libmisc.a -lxml2   -lpthread -lutil  -laudiofile  -lhamlib -lasound -lm -ldl -lpthread -lm
> gcc  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -O2  -Wl,-z,relro -o chansimberr simd.o pktberr.o main.o ../afsk/libafsk.a ../fsk/libfsk.a ../pammodem/libpam.a ../pskmodem/libpsk.a ../newqpsk/libnewqpsk.a ../p3dmodem/libp3d.a liblog.a libaudioio.a libpttio.a ../matlib/libmat.a ../libmisc/libmisc.a -lxml2   -lpthread -lutil  -laudiofile  -lhamlib -lasound -lm -ldl -lpthread -lm
> kisspkt.c:750:9: warning: ‘__builtin_strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
>   750 |         strncpy(chan->pkt.kiss.ifname, file, sizeof(chan->pkt.kiss.ifname));
>       |         ^
> kisspkt.c: In function ‘pktinitmkiss’:
> kisspkt.c:844:9: warning: ‘__builtin_strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
>   844 |         strncpy(chan->pkt.kiss.ifname, params[0], sizeof(chan->pkt.kiss.ifname));
>       |         ^
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:604: kisspkt.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/soundmodem_0.20-6_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

--- End Message ---
--- Begin Message --- 
Source: soundmodem
Source-Version: 0.20-7
Done: tony mancill <tmancill@debian.org>

We believe that the bug you reported is fixed in the latest version of
soundmodem, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1066215@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
tony mancill <tmancill@debian.org> (supplier of updated soundmodem package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 24 Mar 2024 20:58:03 -0700
Source: soundmodem
Architecture: source
Version: 0.20-7
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: tony mancill <tmancill@debian.org>
Closes: 1022903 1066215
Changes:
 soundmodem (0.20-7) unstable; urgency=medium
 .
   * Team upload
 .
   [ Antoine Beaupré ]
   * Start service only when a config file is present (Closes: #1022903)
 .
   [ tony mancill ]
   * Add patch for implicit-declaration warning (Closes: #1066215)
Checksums-Sha1:
 7f85b07353edae814c6a112a2cfc8335cb4e099d 2059 soundmodem_0.20-7.dsc
 94374e3b93b3f1af179ff1ddd91203d70102fde6 9960 soundmodem_0.20-7.debian.tar.xz
 97846933f1c4a8795c36939485fd467ed5736462 12475 soundmodem_0.20-7_amd64.buildinfo
Checksums-Sha256:
 18d2f996b94c1c611c7f990c4f15d8eed2e8812c9989c9d9ac03ba929dc40ce2 2059 soundmodem_0.20-7.dsc
 aeba0e55cfc1d5f0290c702695ab9afd5831c0df150e8dad7144e1256fb95626 9960 soundmodem_0.20-7.debian.tar.xz
 5c7961cb4e8206e075d4392655de5e850b89e75c178d81cc2203a5a7d855d633 12475 soundmodem_0.20-7_amd64.buildinfo
Files:
 487ed26288c64dcea045c348b65ecbfd 2059 hamradio optional soundmodem_0.20-7.dsc
 f3d1a3c243f4945a13040fe038e07476 9960 hamradio optional soundmodem_0.20-7.debian.tar.xz
 0e12ca80fde6f81d629090703a17a494 12475 hamradio optional soundmodem_0.20-7_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmYA/FQUHHRtYW5jaWxs
QGRlYmlhbi5vcmcACgkQIdIFiZdLPpYw6g//ejDZ8fztmVA47x1wUOYRtp6xyLeg
RjGud0N1Vo+BfdEtwZo0fPCwlLOaM+KmGI0prnL58l2/KLqUsXAiSr1FrledDllY
RVO1S7+uwH5geVhaJnwXB6G1VLg57ETPW8W9W/yqU8LULbj50IgXqZdkypDuPtx4
/S3mosA11++yQEAcZILcWRqfi4B7nLXh9lJwfO6NwBAVcP76aVoJcyFkoNGzY1+Q
9FvWNdmSKfey0AbF/QiZuIRFAJzM+9Tb2+oWu+SGai07g596oZ/IVcWWLLB+wNst
CCmTNPXkheM9NMtjRijL7LRO8HGFpDR446AdVRcEdE83RnrDi3NHOHZ56awYOZn6
g7LjtbrbSl+jKxvcUeGE15kB4Ot82vU2erAtedEDeDbax//PLYLsiyn1zd7p3kuO
aKZXjFtH0IbIBE9XXUJk/W4u8STdd8HIO32VS7lUy3VR3hESoLxhbczmoS1egphJ
5KOqM+P2TeHCJ3Bh0IotC5GDIGj4r+ewc2vzuJfHZ8+MkteOomhIWtP/DKSBSOyV
PbRJgK3lKHoDV/FNThOkNOIbKq1gblZEBLtrGDjIq+D3/58DV/GMgtsm5cIfYZW5
ZuY/8CfZ9zIv0yRyf9/DnAtmHGoYLj+ybOzuCmSeZqzfCRKRk7wJOr0HC12X5WBl
Ghhtx4CBpst8Z4Y=
=7W2T
-----END PGP SIGNATURE-----

Attachment: pgp3V4yrXCHS5.pgp
Description: PGP signature


--- End Message ---
Reply to: