Re: rrdtool: FTBFS on hurd-386 (for review)
Hi, any feedback so far?
On Tue, 2012-09-11 at 19:55 +0200, Svante Signell wrote:
> Source: rrdtool
> Version: 1.4.7-2
> Severity: important
> Tags: patch
> Usertags: hurd
> User: debian-hurd@lists.debian.org
>
> Hello,
>
> Attached is a somewhat large patch for rrtool to successfully build on
> GNU/Hurd, since PATH_MAX is not defined. This is fully compliant with
> POSIX, see
> http://pubs.opengroup.org/onlinepubs/007904875/basedefs/limits.h.html
>
> Dynamic allocation is used all over to avoid defining constant values of
> buffer lengths. Since the patch is non-trivial the best would be if
> upstream could have a look at the proposed changes, in addition to the
> Debian package maintainer.
>
> In the patch there are a few FIXME statements I need comments on, as
> well as the whole patch. At least rrddaemon, rrdtool and librrd4
> install properly, but the clients should be tried out too. Maybe also
> some of the changes should be #ifdef'ed on e.g. _POSIX_VERSION >=
> 200809L, etc. Let me know your opinion.
>
> Thanks!
Reply to: