Re: PATCH: Hurd FTBFS with perl 5.22
Svante Signell, on Mon 04 Jan 2016 23:09:00 +0100, wrote:
> On Mon, 2016-01-04 at 22:50 +0100, Samuel Thibault wrote:
> > Svante Signell, on Mon 04 Jan 2016 22:02:02 +0100, wrote:
> > > - @val = @{$canned_values{$hz}};
> > > - if (!defined(@val)) {
> > > - @val = compute_values($hz);
> > > - }
> > > + @val = compute_values($hz);
> >
> > Don't we want to still try to use canned_values?
>
> As I wrote in IRC you should solve this, not me.
Me taking the time to solve it means I have less time to solve other
issues. I already took time for the Hurd the other day to track the
difficult pfinet crash we've been having for years. I can't spend all my
free time on the Hurd.
> Obviously the !defined(@val) is
> no longer allowed, and I don't know how to rewrite that condition.
Perhaps juste !@val?
I have no idea, I don't know perl. But probably worth trying and
investigating, and I believe you can do it.
> The suggestion when it failed was: Can't use 'defined(@array)' (Maybe
> you should just omit the defined()?) at /.../timeconst.pl line 373.
Which means omitting the call, but not the parameter.
Samuel
Reply to: