Re: Bug#1029097: pam: FTBFS on hurd-i386
Hello,
Svante Signell, le mar. 17 janv. 2023 23:15:32 +0100, a ecrit:
> On Tue, 2023-01-17 at 18:49 +0000, Sam Hartman wrote:
> > > > > > > "Svante" == Svante Signell <svante.signell@gmail.com>
> > > > > > > writes:
> > Svante> modules_pam_nologin_tst-pam_nologin-retval.c.diff
> > disabling
> > Svante> two subtests failing on GNU/Hurd. -
> >
> > Why do these subtests fail?
> >
> tst-pam_nologin-retval.c:185: Assertion failed: PAM_SYSTEM_ERR (0x4) ==
> pam_authenticate(pamh, 0) (0x6)
> tst-pam_nologin-retval.c:189: Assertion failed: PAM_SYSTEM_ERR (0x4) ==
> pam_acct_mgmt(pamh, 0) (0x6)
He didn't ask how they failed, but why, i.e. investigate what that
PAM_PERM_DENIED (6) value is coming from, to determine whether
it's actually expected to be that error instead of PAM_SYSTEM_ERR
(4). Possibly it just is (the test is apparently about nologin), but
then the test should be set to check for PAM_PERM_DENIED instead of
PAM_SYSTEM_ERR.
> > Svante>
> > Svante> debian_libpam-modules-bin.install.hurd-i386.patch
> > creating
> > Svante> an install file for Hurd excluding two systemd-specific
> > Svante> files not needed.
> >
> > Why is installing these files harmful?
> > I'm reluctant to take this patch unless it actually breaks something
> > and there's no other way to do it.
> > If I take this patch, then I'll have to remember to update the hurd
> > install list every time something changes.
>
> I did not say they are harmful. They just weren't built/available in
> the build tree during the installation of libpam-modules-bin,
Which is not really surprising since it's about namespaces, which are
linux-only.
> (I've tried to add stuff like (arch=!hurd-any) ... to the .install
> file. It seems like that such attempts does not work, as they for e.g.
> .symbol files.)
That's not how that works indeed, one has to use dh-exec instead. See
the attached patch, plus one has to run
chmod +x debian/libpam-modules-bin.install
Thanks for the patches,
Samuel
--- debian/control.original 2023-05-06 09:56:31.000000000 +0000
+++ debian/control 2023-05-06 09:56:33.000000000 +0000
@@ -4,7 +4,7 @@
Uploaders: Sam Hartman <hartmans@debian.org>
Maintainer: Steve Langasek <vorlon@debian.org>
Standards-Version: 4.6.0
-Build-Depends: debhelper-compat (= 13), dh-exec, quilt, flex, libdb-dev, libcrypt-dev, libselinux1-dev [linux-any], po-debconf, dh-autoreconf, autopoint, libaudit-dev [linux-any] <!stage1>, pkg-config, libfl-dev, libfl-dev:native, docbook-xsl, docbook-xml, xsltproc, libxml2-utils, w3m
+Build-Depends: debhelper-compat (= 13), dh-exec, quilt, flex, libdb-dev, libcrypt-dev, libselinux1-dev [linux-any], po-debconf, dh-autoreconf, autopoint, libaudit-dev [linux-any] <!stage1>, pkg-config, libfl-dev, libfl-dev:native, docbook-xsl, docbook-xml, xsltproc, libxml2-utils, w3m, dh-exec
Build-Conflicts-Indep: fop
Build-Conflicts: libdb4.2-dev, libxcrypt-dev
Vcs-Browser: https://salsa.debian.org/vorlon/pam
--- debian/libpam-modules-bin.install.original 2023-05-06 09:56:45.000000000 +0000
+++ debian/libpam-modules-bin.install 2023-05-06 09:57:00.000000000 +0000
@@ -1,9 +1,10 @@
+#!/usr/bin/dh-exec
sbin/unix_chkpwd sbin
sbin/unix_update sbin
sbin/mkhomedir_helper sbin
-sbin/pam_namespace_helper
+[linux-any] sbin/pam_namespace_helper
sbin/pwhistory_helper
sbin/pam_timestamp_check usr/sbin
sbin/faillock usr/sbin
modules/pam_faillock/faillock.8 usr/share/man/man8
-usr/lib/systemd/system/pam_namespace.service
+[linux-any] usr/lib/systemd/system/pam_namespace.service
Reply to: