Bug#1029112: Surprise build issue with ibus-libzhuyin

[Osamu Aoki <osamu@debian.org>]

Hi,

Debian official packages are required to build without downloading external
files during their build.  (Builddd is in isolated network environment only with
access to the Debian package repository.


> Tags: ftbfs

So if it requires wget file access, it is ftbfs.  Don't make build script to do
this.   ... (continue to the bottom).

> Making all in model
> make[4]: Entering directory '/<<PKGBUILDDIR>>/data/model'
> wget http://downloads.sourceforge.net/libzhuyin/models/model13.text.tar.gz
> /bin/bash: line 1: wget: command not found
> 
> And yes, it's true that wget is not included in Build-Depends. But 
> previously that has not been needed. This is from the buildlog for the 
> latest successful build:
> 
> Making all in model
> make[4]: Entering directory '/<<PKGBUILDDIR>>/data/model'
> rm -f phrase_index.bin pinyin_index.bin addon_phrase_index.bin 
> addon_pinyin_index.bin bigram.db tsi.bin
> gen_binary_files --table-dir ../../data/model
> import_interpolation --table-dir ../../data/model < 
> ../../data/model/interpolation2.text
> gen_unigram --table-dir ../../data/model
> 
> or just:
> 
> Making check in model
> make[3]: Entering directory '/<<PKGBUILDDIR>>/data/model'
> make[3]: Nothing to be done for 'check'.
> 
> I have not found any code changes which would explain the new behavior. 
> And when trying (in an Ubuntu PPA) to add wget to Build-Depends, it 
> failed to resolve the download URL. (It builds fine on my harddisk, though.)
> 
> I figured out that this patch would help it build successfully:
> 
> --- a/data/Makefile.am
> +++ b/data/Makefile.am
> @@ -27,7 +27,6 @@
> 
>    SUBDIRS = \
>            icons \
> -        model \
>            $(NULL)
> 
>    appdatadir = @datadir@/appdata
> 
> But since I don't know how that would affect the functionality of the 
> package, I have left it in its failed state for now.
> 
> In other words: I need help to solve this.


If I were you, I will build package "without this mod in an environment with
wget included as Build-dep" and "with this mod only without wget in chroot". 
Then I will check resulting binary packages.

If these generated packages contain different model data, then you need to
modify code to use pre-existing data and download such model data in advance to
be included in debian/ directory.  Of course, you need to check license terms of
such model data and document it.

If these contain same model data, your proposed fix should be OK.

Regards,

Osamu