On 03/19/2014 02:16 AM, Emmanuel Bourg wrote: > Le 18/03/2014 05:11, tony mancill a écrit : > >> Uploaded with a few minor changes. >> >> 1) I needed to include tomcat-util-scan.jar to the package to get >> tomcat8 to start - otherwise it would fail with the following error: >> >> java.lang.NoClassDefFoundError: org/apache/tomcat/util/digester/Rule >> >> 2) I dropped the debian/NEWS file. >> >> 3) I pruned debian/changelog. > > Hi Tony, > > Thank you for the review and the upload. I thought it was interesting to > preserve the old changelog entries, it keeps an history showing where > tomcat8 diverged from tomcat7. Hi Emmanuel, To my eyes, it just looked a little odd to see the different source package name there in the changelog. (Also, I see that tomcat7 included the tomcat6 entries, so there was already precedent.) I'm not opposed to restoring it in subsequent upload - either that or maybe just a single entry that lists the version of tomcat7 at which tomcat8 diverged, and maybe the Vcs URL for tomcat7 for those curious. Thanks for packaging it. tony
Attachment:
signature.asc
Description: OpenPGP digital signature