[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#635653: [linux-2.6] Please pick: iwlagn: check for !priv->txq in iwlagn_wait_tx_queue_empty



> > [1] https://patchwork.kernel.org/patch/1005892/
> 
> The replies on that page say that the bug was in mac80211, not iwlagn.

Yeah iwlagn reacted badly to being called here, that's how we found the bug.

> It seems that the correct fix is:
> 
> commit 94f9b97be5b3bf67392e43fb7f567721b09142c2
> Author: Johannes Berg <johannes.berg@intel.com>
> Date:   Thu Jul 14 16:48:54 2011 +0200
> 
>     mac80211: be more careful in suspend/resume
> 
> Johannes, is that fix also suitable for 3.0?  Shouldn't it go to stable@kernel.org?

I wasn't aware that the problem with iwlagn existed in 3.0, it was a fairly recent issue as well.

The fix itself is suitable for 3.0, but I think the part of the patch fixing the coverage class issue there might not apply/compile on 3.0. Given the bug report, it looks like it should go there, do you want to give it a try?

johannes

--------------------------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland 
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

Reply to: