[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#790536: FTBFS with GCC 5: comparison of constant '-1' with boolean expression is always false



On Mon, 2015-08-03 at 20:22 +0200, Cyril Brulebois wrote:
> Control: reassign -1 src:linux-tools 4.0.2-1
> Control: tag -1 fixed-upstream patch
> 
> Hi,
> 
> Martin Michlmayr <tbm@hp.com> (2015-06-29):
> > Package: linux-tools
> > Version: 4.0.2-1
> > Severity: important
> > User: debian-gcc@lists.debian.org
> > Usertags: ftbfs-gcc-5
> 
> This should have been “Source: linux-tools” rather than “Package:
> linux-tools”, reassigning.
> 
> Looking upstream, it seems this has been fixed as a side effect of a
> performance improvement:
> > commit fefd2d9619de3bf0bf02a8622e9f445c3d19cc3f
> > Author: He Kuang <hekuang@huawei.com>
> > Date:   Sun Feb 15 10:33:37 2015 +0800
> > 
> >     perf report: Fix branch stack mode cannot be set
> 
> > > builtin-report.c: In function 'cmd_report':
> > > builtin-report.c:769:23: error: comparison of constant '-1' with boolean expression is always false [-Werror=bool-compare]
> > >       branch_call_mode == -1) {
> > >                        ^
> > > cc1: all warnings being treated as errors
> > > Makefile.perf:693: recipe for target '/«PKGBUILDDIR»/debian/build/tools/perf/out/builtin-report.o' failed
> 
> diff:
> >         if (((branch_mode == -1 && has_br_stack) || branch_mode == 1) &&
> > -           branch_call_mode == -1) {
> > +           !branch_call_mode) {
> >                 sort__mode = SORT_MODE__BRANCH;
> >                 symbol_conf.cumulate_callchain = false;
> >         }
> 
> I'm attaching a source debdiff generated after having added a quilt
> patch and generated an updated source package. I suppose some stripping
> might be needed before committing that to svn…

Thanks, but that fix was included in 4.1 and I'm about to upload 4.1
packages to unstable at last.  No cherry-picking is required.

Ben.

-- 
Ben Hutchings
Unix is many things to many people,
but it's never been everything to anybody.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: