[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH v3] deb-pkg: add source package



On Fri, Aug 21, 2015 at 11:08:44AM +0200, Ben Hutchings wrote:
> I've gone through this with Riku and found a couple of problems:
> 
> - The 'clean' rule in the generated debian/rules calls 'make clean',
>   but scripts/package/Makefile includes debian/ in clean-dirs.
>   Currently that directory does not get removed for some reason, but I
>   think that's a bug and the clean rule in debian/rules should guard
>   against removal.

Good catch. make clean is indeed supposed to delete the debian/
directory.


> - Building of the 'orig' tarball uses git, i.e. it depends on the
>   kernel source being in a git repository and not simply unpacked from
>   a tarball (or from other VCS).  The rpmpkg target doesn't have this 
>   same restriction.

Right. make rpm uses the KBUILD_ALLDIRS to generate the tarball. It's
not perfect, but it behaves consistently.

Michal


Reply to: