[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#797361: initramfs-tools: hooks/fsck includes too many tools



Package: initramfs-tools
Severity: normal
Version: 0.120
Tags: patch

Hello,

Initramfs tools hooks/fsck includes fsck utils for / and /usr, but it
doesn't take `pass' field into account, specifically when it's not set
or set to 0 (as per fstab(5) fsck should not be run against those
filesystems. Specifically one would set that to zero for filesystems
that don't require fsck to be run, like btrfs and xfs.

See attached proposed patch.

>From 3ebe2c4c3c7df2fddb2e15b438363e8f95d80962 Mon Sep 17 00:00:00 2001
From: Dimitri John Ledkov <dimitri.j.ledkov@intel.com>
Date: Sat, 29 Aug 2015 23:59:07 +0100
Subject: [PATCH] Do not include fsck tools for fstab entries with empty or 0
 pass field.

Those fstab entries request not to have fsck run against them, e.g. btrfs & xfs.
---
 hooks/fsck | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hooks/fsck b/hooks/fsck
index 6c90996..4483e3b 100755
--- a/hooks/fsck
+++ b/hooks/fsck
@@ -27,6 +27,11 @@ _read_fstab_entry () {
 	fstab_files | while read file; do
 		if [ -f "$file" ]; then
 			while read MNT_FSNAME MNT_DIR MNT_TYPE MNT_OPTS MNT_FREQ MNT_PASS MNT_JUNK; do
+				case "$MNT_PASS" in
+				  ""|"0")
+					continue;
+					;;
+				esac
 				case "$MNT_FSNAME" in
 				  ""|\#*)
 					continue;
-- 
2.5.0

Regards,

Dimitri.

Reply to: