Re: [PATCH] kbuild: Do not use hyphen in exported variable name
On Tue, Apr 18, 2017 at 02:00:11AM +0100, Ben Hutchings wrote:
> This definition in Makefile.dtbinst:
>
> export dtbinst-root ?= $(obj)
>
> should define and export dtbinst-root when handling the root dts
> directory, and do nothing in the subdirectories. However, the
> variable does not reliably get exported to the environment, perhaps
> because its name contains a hyphen.
>
> Rename the variable to dtbinst_root.
Exported environment variables are usually in UPPPER CASE.
And also listed in: Documentation/kbuild/kbuild.txt
There are deviations from this already, so not something
that is followed by all of kbuild.
Sam
Reply to: