[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#904086: Add fsck.xfs and xfs_repair to the initramfs



Control: reassign -1 xfsprogs

On Thu, 2018-07-19 at 11:30 +0000, Marcos Mello wrote:
> Package: initramfs-tools-core
> Version: 0.130
> Severity: normal
> 
> Default passno for XFS in fstab is 0:
> 
> https://salsa.debian.org/installer-team/partman-xfs/blob/63/fstab.d/xfs#L24
> 
> Because of this, fsck hook does not add fsck.xfs. Fine up to xfsprogs 4.15.1, since fsck.xfs does nothing.
> 
> However, starting with xfsprogs 4.16.0, fsck.xfs runs xfs_repair when called with -f (forcefsck|fsck.mode=force):
> 
> https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/commit/?id=7c3e94a3001292946521fb4cfac841e9ac32691b
> https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/commit/?id=04a2d5dcdc0486e2b0c9903428a17313b8c92b7d
> 
> So having fsck.xfs and xfs_repair in the initramfs is useful now. passno must stay 0 because verification is only done in force mode.
> 
> (xfsprogs is outdated in sid right now)

I think xfsprogs should take responsibility for adding the necessary
files to the initramfs.  It doesn't make sense for initramfs-tools to
have to know about quirks like this.  (There is precedent for this;
btrfs-progs installs its own initramfs-tools hook.)

Ben.

-- 
Ben Hutchings
[W]e found...that it wasn't as easy to get programs right as we had
thought. I realized that a large part of my life from then on was going
to be spent in finding mistakes in my own programs.
                                                 - Maurice Wilkes, 1949

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: