[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#988430: marked as done (nfs-utils: nfs-common does not restart services on upgrade)

Your message dated Thu, 24 Feb 2022 03:41:56 +0100
with message-id <d42a2f496d96e38279c319e7a0f2d5306d09c838.camel@decadent.org.uk>
and subject line Re: nfs-utils: nfs-common does not restart services on upgrade
has caused the Debian Bug report #988430,
regarding nfs-utils: nfs-common does not restart services on upgrade
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
988430: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988430
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: nfs-utils
Version: 1:1.3.4-5
Severity: normal                                                                
                                                                               
Dear Maintainer,                                                                
while testing a fix for rpc.gssd, part of nfs-common, I discovered that this service (and others) is not restarted as part of the upgrade.

Further troubleshooting led me to the nfs-utils.service service, which is not enabled nor started at package install time. >From d/rules:

    dh_systemd_enable -p nfs-common nfs-client.target
    dh_systemd_enable -p nfs-kernel-server nfs-server.service
    dh_installinit -pnfs-common -R
    dh_systemd_start -p nfs-common --restart-after-upgrade nfs-utils.service
    dh_systemd_start -p nfs-kernel-server --restart-after-upgrade nfs-server.service

nfs-utils.service is a "fake" service, meant to coordinate all the different processes that make up an NFS server nowadays. It can't be enabled, and r/rules doesn't even attempt to enable it:
$ sudo systemctl enable nfs-utils.service
The unit files have no installation config (WantedBy, RequiredBy, Also, Alias
settings in the [Install] section, and DefaultInstance for template units).
This means they are not meant to be enabled using systemctl.
Possible reasons for having this kind of units are:
1) A unit may be statically enabled by being symlinked from another unit's
   .wants/ or .requires/ directory.
2) A unit's purpose may be to act as a helper for some other unit which has
   a requirement dependency on it.
3) A unit may be started when needed via activation (socket, path, timer,
   D-Bus, udev, scripted systemctl call, ...).
4) In case of template units, the unit is meant to be enabled with some
   instance name specified.

Problem is, it also won't be started on install, so the dh_systemd_start calls won't do anything. This can be seen while installing the package:
"""
nfs-utils.service is a disabled or a static unit, not starting it.
"""
And the same thing happens on upgrades, it's not restarted, and as such rpc.gssd and at least /usr/sbin/blkmapd will not be restarted.


--- End Message ---
--- Begin Message --- 
Version: 1:2.6.1-1~exp1

I belive this was fixed in the above version by this commit:

commit f14b78512a7f36417b70e217e62ad3c5f5c7e670
Author: Romain Perier <romain.perier@gmail.com>
Date:   Sat Aug 24 20:00:54 2019 +0200
 
    debian/rules: Modernize the packaging rules

All installed systemd services are now restarted on upgrade (though
maybe it would be cleaner to exclude nfs-utils.service from this?).

Ben.

-- 
Ben Hutchings
Nothing is ever a complete failure;
it can always serve as a bad example.

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
Reply to: