[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1006149: linux-image-5.16.0-1-686: Fails to boot on T41 Thinkpads



Hi Petra and Axel,

On Thursday, 28 April 2022 09:56:29 CEST Salvatore Bonaccorso wrote:
> Now this gives us probably a good hint!
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=215909
> 
> d6b88ce2eb9d ("ACPI: processor idle: Allow playing dead in C3 state")
> and a followup commit bfe55a1f7fd6 ("ACPI: processor: idle: fix lockup
> regression on 32-bit ThinkPad T40") were both applied to 5.15.35. I
> suspect the former is the one so which causes the regression as well
> for you.

It was a good hint, but apparently not (yet) the solution.
Francesco reported that the issue was fixed for him in 5.17.0-2-686 which 
corresponds to 5.17.6 upstream kernel.
Petra & Axel: can you verify whether it is also fixed for you?

Looking through the changes between 5.17.5 and 5.17.6, I found the following:

- 14defb873c1dc4cef1e7e7951f47f019821734fc titled:
Revert "ACPI: processor: idle: fix lockup regression on 32-bit ThinkPad T40"
Secondary commit message:
"  commit 20e582e16af24b074e583f9551fad557882a3c9d upstream.
    
    This reverts commit bfe55a1f7fd6bfede16078bf04c6250fbca11588.
    
    This was presumably misdiagnosed as an inability to use C3 at
    all when I suspect the real problem is just misconfiguration of
    C3 vs. ARB_DIS.
"
- b3b0ca1c324982fcc005063af045439670e16aa3 titled:
ACPI: processor: idle: Avoid falling back to C3 type C-states
Secondary commit message:
"  commit fc45e55ebc58dbf622cb89ddbf797589c7a5510b upstream.
    
    The "safe state" index is used by acpi_idle_enter_bm() to avoid
    entering a C-state that may require bus mastering to be disabled
    on entry in the cases when this is not going to happen.  For this
    reason, it should not be set to point to C3 type of C-states, because
    they may require bus mastering to be disabled on entry in principle.
    
    This was broken by commit d6b88ce2eb9d ("ACPI: processor idle: Allow
    playing dead in C3 state") which inadvertently allowed the "safe
    state" index to point to C3 type of C-states.
    
    This results in a machine that won't boot past the point when it first
    enters C3. Restore the correct behaviour (either demote to C1/C2, or
    use C3 but also set ARB_DIS=1).
    
    I hit this on a Fujitsu Siemens Lifebook S6010 (P3) machine.
"

The rest of the commits between .5 and .6 don't appear relevant for this bug 
to *me*, but I can ofc be wrong.

Cheers,
  Diederik

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: