Bug#1035282: firmware-brcm80211: broken symlinks: /lib/firmware/brcm/brcmfmac4356-sdio.*,*.txt -> brcmfmac4356-sdio.AP6356S.txt

[Salvatore Bonaccorso <carnil@debian.org>]

Hi,

On Sun, Apr 30, 2023 at 03:18:08AM +0200, Andreas Beckmann wrote:
> Package: firmware-brcm80211
> Version: 20230210-4
> Severity: serious
> User: debian-qa@lists.debian.org
> Usertags: piuparts
> 
> Hi,
> 
> during a test with piuparts I noticed your package ships (or creates)
> a broken symlink.
> 
> >From the attached log (scroll to the bottom...):
> 
> 0m14.9s ERROR: WARN: Broken symlinks:
>   /lib/firmware/brcm/brcmfmac4356-sdio.khadas,vim2.txt -> brcmfmac4356-sdio.AP6356S.txt (firmware-brcm80211)
>   /lib/firmware/brcm/brcmfmac4356-sdio.vamrs,rock960.txt -> brcmfmac4356-sdio.AP6356S.txt (firmware-brcm80211)
> 
> Severity serious, since this likely means that the kernel cannot find
> the firmware at the expected location.

Seems to be a consequence of upstream's change in 4ffcf980a535 ("brcm:
rename Rock960 NVRAM to AP6356S and link devices to it") in 20220411.

In the Debian packaging adding the nvram for 96boards Rock960,
happened in 20210208-1, so at least stable users indeed might suffer
from a problem switching from bullseye to bookworm. For the one with
khadas VIM2's WiFi,s there is no regreession at least as the symlink
was added in 20210511-1~exp1.

Will have a look.

Regards,
Salvatore