[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes



Source: firmware-nonfree
Followup-For: Bug #1035505
X-Debbugs-Cc: didi.debian@cknow.org, 1029843@bugs.debian.org, kibi@debian.org

Hey Diederik,

I think that the edits to 'debian/config/brcm80211/defines' may be the cause
of the space-escaping issue (noticed that in your fork on Salsa).

Building locally without modifications from firmware-nonfree_20230210-5 I get:

  $ debian/rules debian/control-real
  mkdir -p debian/build
  printf >debian/build/version-info 'Source: %s\nVersion: %s\n' firmware-nonfree 20230210-5
  ./copy-firmware.sh debian/build/install
  debian/bin/gencontrol.py /usr/src/linux-support-6.1.0-8
  W: brcm80211: unused files: .defines.swp
  md5sum debian/bin/gencontrol.py debian/build/version-info debian/templates/control.binary.in debian/templates/control.extra.in debian/templates/control.source.in debian/templates/metainfo.xml.firmware.in debian/templates/metainfo.xml.in debian/templates/metainfo.xml.modalias.in debian/templates/postinst.initramfs-tools.in debian/templates/preinst.license.in debian/templates/templates.license.in debian/config/defines debian/config/amd-graphics/defines debian/config/atheros/defines debian/config/bnx2/defines debian/config/bnx2x/defines debian/config/brcm80211/defines debian/config/cavium/defines debian/config/intel-sound/defines debian/config/ipw2x00/defines debian/config/ivtv/defines debian/config/iwlwifi/defines debian/config/libertas/defines debian/config/misc-nonfree/defines debian/config/myricom/defines debian/config/netronome/defines debian/config/netxen/defines debian/config/qcom-soc/defines debian/config/qlogic/defines debian/config/realtek/defines debian/config/samsung/defines debian/config/siano/defines debian/config/ti-connectivity/defines debian/modinfo.json > debian/control.md5sum
  
  This target is made to fail intentionally, to make sure
  that it is NEVER run during the automated build. Please
  ignore the following error, the debian/control file has
  been generated SUCCESSFULLY.
  
  exit 1
  make: *** [debian/rules:61: debian/control-real] Error 1
  $ ls -l debian/build/install/brcm/brcmfmac43455-sdio.*
  -rw-r--r-- 1 jka jka 1723 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.acepc-t8.txt
  -rw-r--r-- 1 jka jka 1475 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.AW-CM256SM.txt
  lrwxrwxrwx 1 jka jka   33 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.beagle,am5729-beagleboneai.txt -> brcmfmac43455-sdio.AW-CM256SM.txt
  lrwxrwxrwx 1 jka jka   31 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.bin -> ../cypress/cyfmac43455-sdio.bin
  lrwxrwxrwx 1 jka jka   36 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.clm_blob -> ../cypress/cyfmac43455-sdio.clm_blob
  -rw-r--r-- 1 jka jka 2510 May  4 18:45 'debian/build/install/brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt'
  lrwxrwxrwx 1 jka jka   33 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.pine64,pinebook-pro.txt -> brcmfmac43455-sdio.AW-CM256SM.txt
  lrwxrwxrwx 1 jka jka   33 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.pine64,pinephone-pro.txt -> brcmfmac43455-sdio.AW-CM256SM.txt
  lrwxrwxrwx 1 jka jka   33 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.pine64,quartz64-b.txt -> brcmfmac43455-sdio.AW-CM256SM.txt
  lrwxrwxrwx 1 jka jka   49 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt -> brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
  -rw-r--r-- 1 jka jka 1884 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt
  -rw-r--r-- 1 jka jka 1883 May  4 18:45  debian/build/install/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt
  lrwxrwxrwx 1 jka jka   44 May  4 18:45 'debian/build/install/brcm/brcmfmac43455-sdio.Raspberry Pi Foundation-Raspberry Pi 4 Model B.txt' -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt
  lrwxrwxrwx 1 jka jka   44 May  4 18:45 'debian/build/install/brcm/brcmfmac43455-sdio.Raspberry Pi Foundation-Raspberry Pi Compute Module 4.txt' -> brcmfmac43455-sdio.raspberrypi,4-model-b.txt


So I think the symlinks are created.. but then lost when the .deb is built?


Reply to: