[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://udev/{udev.templates}



Please find, for review, the debconf templates of udev.

This review will last from Thursday, April 12, 2007 to Sunday, April 22, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:

--- ../udev.old/debian/udev.templates	2007-04-07 18:08:54.815829004 +0200
+++ debian/udev.templates	2007-04-12 12:56:32.815323927 +0200
@@ -1,24 +1,26 @@
 Template: udev/reboot_needed
-Type: note
+Type: error

Will guarantee that the note is displayed. Part of my Jihad against
Evil Debconf Notes..:-). Debconf will show it in different colors
(when using the dialog interface) which will bring the extra attention
needed.

 _Description: Reboot needed after this upgrade
  You are currently upgrading udev using an incompatible kernel version. A
- compatible version is installed or being installed on your system, but 
+ compatible version is installed or being installed on the system, but 
  you need to reboot using this new kernel as soon as the upgrade is 
  complete.
  .
- Without a reboot with this new kernel version, your system may become 
+ Without a reboot with this new kernel version, the system may become 
  UNUSABLE.

s/your system/the system: neutral style and, after all, the system is
not always "my" system.

 
 Template: udev/new_kernel_needed
 Type: boolean
 Default: false
-_Description: Proceed with the upgrade nevertheless?
- You are currently upgrading udev using an incompatible kernel version.
+_Description: Proceed with the udev upgrade despite the kernel incompatibility?
+ You are currently upgrading udev to a version that is not
+ compatible with the currently running kernel.
+ .
  You MUST install a compatible kernel version (2.6.15 or more) before
- proceeding with the upgrade, otherwise your system may become UNUSABLE.
+ upgrading, otherwise the system may become UNUSABLE.
  Packages with a name starting with "linux-image-2.6-" provide a kernel
  image usable with this new udev version.
  .
- If you choose to upgrade udev nevertheless, you should install a 
- compatible kernel and reboot on it as soon as possible. You have been 
- warned.
+ If you choose to upgrade udev nevertheless, you should install a
+ compatible kernel and reboot with that kernel as soon as
+ possible.

Try giving mor emeaning to the short description in case it is
displayed alone (happens with the Gnome interface of debconf).

Split paragraphs to give the important fact more obvious to see. The
first sentence is reworded for clarity.

Remove the "You have been warned". Stay factual..:-)


--- ../udev.old/debian/control	2007-04-07 18:08:54.815829004 +0200
+++ debian/control	2007-04-12 12:59:57.489020310 +0200
@@ -7,13 +7,14 @@
 
 Package: udev
 Architecture: any
-Pre-Depends: debconf (>= 0.5) | debconf-2.0
+Pre-Depends: debconf (>= 1.4.69) | debconf-2.0

Motivated by using "error" which is supported only since debconf 1.4.69


 Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 3.0-6)
 Replaces: initramfs-tools (<= 0.41)
 Conflicts: hotplug, initscripts (<< 2.85-16), lvm-common (<< 1.5.13), module-init-tools (<< 3.2.2-1), initramfs-tools (<< 0.39), hal (<< 0.5.6-2), makedev (<< 2.3.1-80), klibc-utils (<= 1.4.19-1)
 Description: /dev/ and hotplug management daemon
  udev is a daemon which dynamically creates and removes device nodes from
- /dev/, handles hotplug events and loads drivers at boot time.
+ /dev/, handles hotplug events and loads drivers at boot time. It replaces
+ the hotplug package and requires a 2.6.12 or later kernel.

Consistency with the udeb description

 
 Package: libvolume-id0
 Section: libs
@@ -40,6 +41,6 @@
 Description: /dev/ and hotplug management daemon
  udev is a daemon which dynamically creates and removes device nodes from
  /dev/, handles hotplug events and loads drivers at boot time. It replaces
- the hotplug package and requires a kernel not older than 2.6.12.
+ the hotplug package and requires a 2.6.12 or later kernel.
  .
  This is a minimal version for use in debian-installer.

My feeling is that this sounds better.....:)

-- 


Template: udev/reboot_needed
Type: error
_Description: Reboot needed after this upgrade
 You are currently upgrading udev using an incompatible kernel version. A
 compatible version is installed or being installed on the system, but 
 you need to reboot using this new kernel as soon as the upgrade is 
 complete.
 .
 Without a reboot with this new kernel version, the system may become 
 UNUSABLE.

Template: udev/new_kernel_needed
Type: boolean
Default: false
_Description: Proceed with the udev upgrade despite the kernel incompatibility?
 You are currently upgrading udev to a version that is not
 compatible with the currently running kernel.
 .
 You MUST install a compatible kernel version (2.6.15 or more) before
 upgrading, otherwise the system may become UNUSABLE.
 Packages with a name starting with "linux-image-2.6-" provide a kernel
 image usable with this new udev version.
 .
 If you choose to upgrade udev nevertheless, you should install a
 compatible kernel and reboot with that kernel as soon as
 possible.
--- ../udev.old/debian/udev.templates	2007-04-07 18:08:54.815829004 +0200
+++ debian/udev.templates	2007-04-12 12:56:32.815323927 +0200
@@ -1,24 +1,26 @@
 Template: udev/reboot_needed
-Type: note
+Type: error
 _Description: Reboot needed after this upgrade
  You are currently upgrading udev using an incompatible kernel version. A
- compatible version is installed or being installed on your system, but 
+ compatible version is installed or being installed on the system, but 
  you need to reboot using this new kernel as soon as the upgrade is 
  complete.
  .
- Without a reboot with this new kernel version, your system may become 
+ Without a reboot with this new kernel version, the system may become 
  UNUSABLE.
 
 Template: udev/new_kernel_needed
 Type: boolean
 Default: false
-_Description: Proceed with the upgrade nevertheless?
- You are currently upgrading udev using an incompatible kernel version.
+_Description: Proceed with the udev upgrade despite the kernel incompatibility?
+ You are currently upgrading udev to a version that is not
+ compatible with the currently running kernel.
+ .
  You MUST install a compatible kernel version (2.6.15 or more) before
- proceeding with the upgrade, otherwise your system may become UNUSABLE.
+ upgrading, otherwise the system may become UNUSABLE.
  Packages with a name starting with "linux-image-2.6-" provide a kernel
  image usable with this new udev version.
  .
- If you choose to upgrade udev nevertheless, you should install a 
- compatible kernel and reboot on it as soon as possible. You have been 
- warned.
+ If you choose to upgrade udev nevertheless, you should install a
+ compatible kernel and reboot with that kernel as soon as
+ possible.
--- ../udev.old/debian/control	2007-04-07 18:08:54.815829004 +0200
+++ debian/control	2007-04-12 12:59:57.489020310 +0200
@@ -7,13 +7,14 @@
 
 Package: udev
 Architecture: any
-Pre-Depends: debconf (>= 0.5) | debconf-2.0
+Pre-Depends: debconf (>= 1.4.69) | debconf-2.0
 Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 3.0-6)
 Replaces: initramfs-tools (<= 0.41)
 Conflicts: hotplug, initscripts (<< 2.85-16), lvm-common (<< 1.5.13), module-init-tools (<< 3.2.2-1), initramfs-tools (<< 0.39), hal (<< 0.5.6-2), makedev (<< 2.3.1-80), klibc-utils (<= 1.4.19-1)
 Description: /dev/ and hotplug management daemon
  udev is a daemon which dynamically creates and removes device nodes from
- /dev/, handles hotplug events and loads drivers at boot time.
+ /dev/, handles hotplug events and loads drivers at boot time. It replaces
+ the hotplug package and requires a 2.6.12 or later kernel.
 
 Package: libvolume-id0
 Section: libs
@@ -40,6 +41,6 @@
 Description: /dev/ and hotplug management daemon
  udev is a daemon which dynamically creates and removes device nodes from
  /dev/, handles hotplug events and loads drivers at boot time. It replaces
- the hotplug package and requires a kernel not older than 2.6.12.
+ the hotplug package and requires a 2.6.12 or later kernel.
  .
  This is a minimal version for use in debian-installer.
Source: udev
Section: admin
Priority: important
Maintainer: Marco d'Itri <md@linux.it>
Build-Depends: debhelper (>> 4.2), bzip2, libselinux1-dev (>= 1.28-1), po-debconf
Standards-Version: 3.7.2.2

Package: udev
Architecture: any
Pre-Depends: debconf (>= 1.4.69) | debconf-2.0
Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 3.0-6)
Replaces: initramfs-tools (<= 0.41)
Conflicts: hotplug, initscripts (<< 2.85-16), lvm-common (<< 1.5.13), module-init-tools (<< 3.2.2-1), initramfs-tools (<< 0.39), hal (<< 0.5.6-2), makedev (<< 2.3.1-80), klibc-utils (<= 1.4.19-1)
Description: /dev/ and hotplug management daemon
 udev is a daemon which dynamically creates and removes device nodes from
 /dev/, handles hotplug events and loads drivers at boot time. It replaces
 the hotplug package and requires a 2.6.12 or later kernel.

Package: libvolume-id0
Section: libs
Architecture: any
Depends: ${shlibs:Depends}
Description: libvolume_id shared library
 This library is used to detect the type of a file system and read its
 metadata.

Package: libvolume-id-dev
Section: libdevel
Priority: optional
Architecture: any
Depends: ${shlibs:Depends}, libvolume-id0 (= ${Source-Version})
Description: libvolume_id development headers
 This package provides the static libraries and header files needed
 to link programs with libvolume_id.

Package: udev-udeb
XC-Package-Type: udeb
Section: debian-installer
Architecture: any
Depends: ${shlibs:Depends}
Description: /dev/ and hotplug management daemon
 udev is a daemon which dynamically creates and removes device nodes from
 /dev/, handles hotplug events and loads drivers at boot time. It replaces
 the hotplug package and requires a 2.6.12 or later kernel.
 .
 This is a minimal version for use in debian-installer.

Attachment: signature.asc
Description: Digital signature


Reply to: