[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r257 - in trunk: private testset testset/libbaz testset/libbaz/debian



Author: jeroen
Date: 2004-05-05 03:33:15 +0200 (Wed, 05 May 2004)
New Revision: 257

Modified:
   trunk/private/TODO
   trunk/testset/libbaz/Makefile
   trunk/testset/libbaz/debian/rules
   trunk/testset/tags.libbaz
Log:
Add a quite faulty library package, still some tests to write though. PIC
turns out to not work indeed


Modified: trunk/private/TODO
===================================================================
--- trunk/private/TODO	2004-05-04 23:28:32 UTC (rev 256)
+++ trunk/private/TODO	2004-05-05 01:33:15 UTC (rev 257)
@@ -35,6 +35,8 @@
 - go through the test suite and organise it more cleanly
 - update doc/CREDITS file
 - Fix experimental support back in
+- Go through testset/libbaz/debian/rules, and make sure all TODO's are
+  lintian-detected
 
 old todo list
 =============

Modified: trunk/testset/libbaz/Makefile
===================================================================
--- trunk/testset/libbaz/Makefile	2004-05-04 23:28:32 UTC (rev 256)
+++ trunk/testset/libbaz/Makefile	2004-05-05 01:33:15 UTC (rev 257)
@@ -5,16 +5,23 @@
 
 OBJS=baz.o extra.o
 
-all: libbaz2.a libbaz2.so
+all: libbaz1.a libbaz2.a libbaz1.so.1.0.3b libbaz2.so
 
 libbaz2.so: libbaz2.so.1.0
 	ln -sf $^ $@
 libbaz2.so.1.0: libbaz2.so.1.0.3b
 	ln -sf $^ $@
 
+# Oops, forget the soname altogether
+libbaz1.so.1.0.3b: $(OBJS)
+	$(CC) -o $@ -shared $^ -lc
+
 libbaz2.so.1.0.3b: $(OBJS:%.o=%.sho)
 	$(CC) -o $@ -shared -Wl,-soname,libbaz2.so.1.0 $^ -lc
 
+#%.o-noreentrant: %.c
+#	$(CC) $(CFLAGS) -o $@ -c $<
+
 %.sho: %.c
 	$(CC) $(CFLAGS) -D_REENTRANT -fPIC -o $@ -c $<
 
@@ -25,5 +32,9 @@
 	ar cq $@ $(OBJS)
 	ranlib $@
 
+# The pic one in the .a (wrong), no archive table
+libbaz1.a: $(OBJS:%.o=%.sho)
+	ar cqS $@ $^
+
 clean:
 	rm -f *.a *.o *.so* *.sho

Modified: trunk/testset/libbaz/debian/rules
===================================================================
--- trunk/testset/libbaz/debian/rules	2004-05-04 23:28:32 UTC (rev 256)
+++ trunk/testset/libbaz/debian/rules	2004-05-05 01:33:15 UTC (rev 257)
@@ -15,9 +15,50 @@
 	rm -f debian/files debian/substvars
 	rm -rf $(lib_tmp) $(dev_tmp)
 
-binary-arch: build
+# Now the correct libbaz2-dev package
+binary-correct:
+	install -d debian/libbaz2-dev/usr/lib
+	cp -a libbaz2.a libbaz2.so debian/libbaz2-dev/usr/lib
+	# usually, I'd also include some .h files to /usr/include
+	
+	# Now the correct libbaz2 package
+	install -d debian/libbaz2/usr/lib
+	cp -a libbaz2.so.* debian/libbaz2/usr/lib
+	chmod a-x debian/libbaz2/usr/lib/*
+	
+	# General stuff that is tested in other testsets:
+	dh_installchangelogs -plibbaz2 -plibbaz2-dev
+	dh_installdocs -plibbaz2 -plibbaz2-dev
+	dh_compress -plibbaz2 -plibbaz2-dev
+
+	# Okay, if either line is omitted, it should be noted
+	dh_strip -plibbaz2 -plibbaz2-dev
+	dh_makeshlibs -plibbaz2 -plibbaz2-dev
+	dh_shlibdeps -plibbaz2 -plibbaz2-dev
+
+	# and again, regular packaging stuff
+	dh_installdeb -plibbaz2 -plibbaz2-dev
+	dh_gencontrol -plibbaz2 -plibbaz2-dev
+	dh_builddeb -plibbaz2 -plibbaz2-dev
+
+# and the incorrect one
+binary-arch: build binary-correct
 	# first, the lib package
 	install -d $(lib_tmp)/usr/lib
+	# resp. no soname (check) &no-pic (TODO) and wrong soname (check)
+	cp -a libbaz1.so.1.0* $(lib_tmp)/usr/lib
+	cp -a libbaz2.so.1.0.3b $(lib_tmp)/usr/lib/libfoo2.so.1.0.3b
+	# let's include the .a in the non-dev too (TODO)
+	# Also, libbaz1.a hasn't a symbol table (TODO)
+	cp -a *.a $(lib_tmp)/usr/lib
+	# And a wrong .so symlink (wrong, only in -dev, TODO)
+	ln -s libfoo3.so.0.9 $(lib_tmp)/usr/lib/libfoo3.so
+	# And a wrong .so.X symlink (wrong, should point to a real existing shlib,
+	# TODO)
+	ln -s libfoo.so.0.9.1 $(lib_tmp)/usr/lib/libfoo.so.0.9
+	# And a plain .so (wrong, TODO)
+	touch $(lib_tmp)/usr/lib/libbar2.so
+	#
 	install -d $(lib_tmp)/usr/share/doc/$(LIB)
 	install -m 644 debian/copyright $(lib_tmp)/usr/share/doc/$(LIB)
 	install -m 644 debian/changelog $(lib_tmp)/usr/share/doc/$(LIB)
@@ -32,6 +73,11 @@
 
 	# now the -dev package
 	install -d $(dev_tmp)/usr/include
+	install -d $(lib_tmp)/usr/lib
+	# let's also install the .so at the same time... (wrong, TODO)
+	cp -a *.a *.so.* $(lib_tmp)/usr/lib
+	# and fuck up permission (TODO)
+	chmod a+x $(lib_tmp)/usr/lib/*.a
 	install -d $(dev_tmp)/usr/share/doc
 	ln -s $(LIB) $(dev_tmp)/usr/share/doc/$(DEV) 
 	install -d $(dev_tmp)/DEBIAN
@@ -40,31 +86,7 @@
 	dpkg-gencontrol -isp -p$(DEV) -P$(dev_tmp)
 	dpkg --build $(dev_tmp) ..
 
-	# Now the correct libbaz2-dev package
-	install -d debian/libbaz2-dev/usr/lib
-	cp -a *.a *.so debian/libbaz2-dev/usr/lib
-	# usually, I'd also include some .h files to /usr/include
-	
-	# Now the correct libbaz2 package
-	install -d debian/libbaz2/usr/lib
-	cp -a *.so.* debian/libbaz2/usr/lib
-	chmod a-x debian/libbaz2/usr/lib/*
-	
-	# General stuff that is tested in other testsets:
-	dh_installchangelogs -plibbaz2 -plibbaz2-dev
-	dh_installdocs -plibbaz2 -plibbaz2-dev
-	dh_compress -plibbaz2 -plibbaz2-dev
 
-	# Okay, if either line is omitted, it should be noted
-	dh_strip -plibbaz2 -plibbaz2-dev
-	dh_makeshlibs -plibbaz2 -plibbaz2-dev
-	dh_shlibdeps -plibbaz2 -plibbaz2-dev
-
-	# and again, regular packaging stuff
-	dh_installdeb -plibbaz2 -plibbaz2-dev
-	dh_gencontrol -plibbaz2 -plibbaz2-dev
-	dh_builddeb -plibbaz2 -plibbaz2-dev
-
 binary: binary-arch
 
 .PHONY: build binary-arch binary clean

Modified: trunk/testset/tags.libbaz
===================================================================
--- trunk/testset/tags.libbaz	2004-05-04 23:28:32 UTC (rev 256)
+++ trunk/testset/tags.libbaz	2004-05-05 01:33:15 UTC (rev 257)
@@ -1,8 +1,15 @@
 E: libbaz1-dev: usr-doc-symlink-without-dependency libbaz1
 E: libbaz1: file-directly-in-usr-share-doc usr/share/doc/README.Debian
+E: libbaz1: ldconfig-symlink-missing-for-shlib usr/lib/libbaz2.so.1.0 usr/lib/libfoo2.so.1.0.3b libbaz2.so.1.0
 E: libbaz1: maintainer-shell-script-fails-syntax-check postinst
+E: libbaz1: postinst-must-call-ldconfig usr/lib/libfoo2.so.1.0.3b
+E: libbaz1: sharedobject-in-library-directory-not-actually-a-shlib usr/lib/libbaz1.so.1.0.3b
+E: libbaz1: shlib-with-executable-bit usr/lib/libfoo2.so.1.0.3b 0755
+E: libbaz1: unstripped-binary-or-object ./usr/lib/libbaz1.so.1.0.3b
+E: libbaz1: unstripped-binary-or-object ./usr/lib/libfoo2.so.1.0.3b
 W: libbaz source: ancient-standards-version 3.2.1
 W: libbaz source: changelog-should-mention-nmu
 W: libbaz source: source-nmu-has-incorrect-version-number 1
+W: libbaz1: missing-depends-line
 W: libbaz1: postinst-should-not-set-usr-doc-link
 W: libbaz1: zero-byte-file-in-doc-directory usr/share/doc/README.Debian



Reply to: