[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#350228: lintian: false positive package-uses-deprecated-debhelper-compat-version with cdbs



Package: lintian
Version: 1.23.15
Severity: normal
Tags: patch

If a package uses cdbs and includes debhelper.mk, then it is using a
correct debhelper compatibility version of 4.  If you don't have a
debian/compat file that contains 4 (which cdbs will create
automatically, but may not be in the original sources), you will a
warning such as this one:

W: tiff source: package-uses-deprecated-debhelper-compat-version 1

I believe a sensible fix is to simply recognize that the correct
dhcompatvalue is 4 if cdbs is in use.  The lintian debhelper check
already makes other assumptions based on cdbs.  This one-line patch
should do the job.  It has the unfortunate property of hard-coding the
number "4" as the current debhelper compat version in another place,
but that's easily rectified if desirable.


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15-1-686-smp
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages lintian depends on:
ii  binutils             2.16.1cvs20060117-1 The GNU assembler, linker and bina
ii  diffstat             1.41-1              produces graph of changes introduc
ii  dpkg-dev             1.13.11.1           package building tools for Debian
ii  file                 4.15-2              Determines file type using "magic"
ii  gettext              0.14.5-2            GNU Internationalization utilities
ii  intltool-debian      0.34.1+20050828     Help i18n of RFC822 compliant conf
ii  libparse-debianchang 1.0-1               parse Debian changelogs and output
ii  man-db               2.4.3-3             The on-line manual pager
ii  perl [libdigest-md5- 5.8.7-10            Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information
--- checks/debhelper~	2006-01-19 09:11:59.000000000 -0500
+++ checks/debhelper	2006-01-27 21:58:02.671089168 -0500
@@ -93,6 +93,7 @@
 	$seencommand = 1;
 	$needbuilddepends = 1;
 	$needtomodifyscripts = 1;
+	$needversiondepends = $dhcompatvalue = 4;
     } elsif (/^\s*export\s+DH_COMPAT\s*=\s*(\d+)/) {
 	$needversiondepends = $1;
     } elsif (/^\s*export\s+DH_COMPAT/) {

Reply to: