[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r585 - in trunk: checks debian testset testset/debconf/debian



Author: jeroen
Date: 2006-03-18 03:46:49 +0100 (Sat, 18 Mar 2006)
New Revision: 585

Modified:
   trunk/checks/shared-libs
   trunk/checks/shared-libs.desc
   trunk/debian/changelog
   trunk/testset/debconf/debian/debconf-udeb.postinst
   trunk/testset/tags.debconf
Log:
* checks/shared-libs:
  + [JvW] Added error when udeb postinst calls ldconfig, that must never
    happen (thanks to Frans Pop for noticing, see #203056)


Modified: trunk/checks/shared-libs
===================================================================
--- trunk/checks/shared-libs	2006-03-18 02:19:20 UTC (rev 584)
+++ trunk/checks/shared-libs	2006-03-18 02:46:49 UTC (rev 585)
@@ -326,10 +326,15 @@
     }
 }
 
-tag "postinst-has-useless-call-to-ldconfig", ""
-    if $we_call_postinst and not $must_call_ldconfig;
-tag "postinst-must-call-ldconfig", "$must_call_ldconfig"
-    if not $we_call_postinst and $must_call_ldconfig;
+if ($type eq 'udeb') {
+    tag "udeb-postinst-must-not-call-ldconfig"
+	if $we_call_postinst;
+} else {
+    tag "postinst-has-useless-call-to-ldconfig", ""
+	if $we_call_postinst and not $must_call_ldconfig;
+    tag "postinst-must-call-ldconfig", "$must_call_ldconfig"
+	if not $we_call_postinst and $must_call_ldconfig;
+}
 
 if (-f $prerm) {
     local $_ = slurp_entire_file($prerm);

Modified: trunk/checks/shared-libs.desc
===================================================================
--- trunk/checks/shared-libs.desc	2006-03-18 02:19:20 UTC (rev 584)
+++ trunk/checks/shared-libs.desc	2006-03-18 02:46:49 UTC (rev 585)
@@ -136,6 +136,11 @@
  installed in a directory controlled by the dynamic library loader.
 Ref: policy 8.1.1
 
+Tag: udeb-postinst-must-not-call-ldconfig
+Type: error
+Info: The postinst script calls ldconfig, which is an error in udebs.
+ ldconfig is not available and not needed in debian-installer
+
 Tag: postrm-has-useless-call-to-ldconfig
 Type: warning
 Info: The postrm script calls ldconfig even though no shared libraries are

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2006-03-18 02:19:20 UTC (rev 584)
+++ trunk/debian/changelog	2006-03-18 02:46:49 UTC (rev 585)
@@ -72,6 +72,8 @@
     + [JvW] Consider also the soname version for shlibs checking, preventing
       some bogus 'duplicate' warnings, and actually throw a warning when
       soname version doesn't match
+    + [JvW] Added error when udeb postinst calls ldconfig, that must never
+      happen (thanks to Frans Pop for noticing, see #203056)
 
   * debian/{control,copyright}:
     + [RA] Add Russ Allbery to Uploaders and copyright.

Modified: trunk/testset/debconf/debian/debconf-udeb.postinst
===================================================================
--- trunk/testset/debconf/debian/debconf-udeb.postinst	2006-03-18 02:19:20 UTC (rev 584)
+++ trunk/testset/debconf/debian/debconf-udeb.postinst	2006-03-18 02:46:49 UTC (rev 585)
@@ -4,4 +4,6 @@
 
 . /usr/share/debconf/confmodule
 
+ldconfig
+
 true

Modified: trunk/testset/tags.debconf
===================================================================
--- trunk/testset/tags.debconf	2006-03-18 02:19:20 UTC (rev 584)
+++ trunk/testset/tags.debconf	2006-03-18 02:46:49 UTC (rev 585)
@@ -2,6 +2,7 @@
 E: debconf-test: extended-description-is-empty
 E: debconf-test: mismatch-translated-choices debconf/testmulti choices-de.utf-8
 E: debconf-test: settitle-requires-versioned-depends config
+E: debconf-udeb udeb: udeb-postinst-must-not-call-ldconfig
 W: debconf source: invalid-po-file debian/po/fr.po
 W: debconf source: maintainer-script-lacks-debhelper-token debian/debconf-test.postinst
 W: debconf source: newer-debconf-templates



Reply to: