[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#358523: please add check for broken invoke-rc.d calls caused by debhelper bug



Package: lintian
Version: 1.23.15
Severity: wishlist

Bug #337664 was a debhelper bug that caused a lot of maintainer scripts
to end up being broken like this:

# Automatically added by dh_installinit
if [ -x "/etc/init.d/dbus" ]; then
        if [ -x "`which invoke-rc.d 2>/dev/null`" ]; then
                invoke-rc.d dbus stop || exit 0
        else
                /etc/init.d/dbus stop || exit 0
        fi
fi
# End automatically added section

The bug being the "|| exit 0" which was supposed to be "|| exit $?".
It's pretty certian that anything looking like the above is unintentionally
throwing away the exit code and should be fixed by being rebuilt with
debhelper 5.0.26. This probably affects hundreds of packages. Could a
lintian check be added for this?

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15-1-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages lintian depends on:
ii  binutils             2.16.1cvs20060117-1 The GNU assembler, linker and bina
ii  diffstat             1.41-1              produces graph of changes introduc
ii  dpkg-dev             1.13.16             package building tools for Debian
ii  file                 4.15-2              Determines file type using "magic"
ii  gettext              0.14.5-2            GNU Internationalization utilities
ii  intltool-debian      0.34.1+20050828     Help i18n of RFC822 compliant conf
ii  libparse-debianchang 1.0-1               parse Debian changelogs and output
ii  man-db               2.4.3-3             The on-line manual pager
ii  perl [libdigest-md5- 5.8.8-3             Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: