Bug#359646: check for substvars file in Debian-Diff

[Michael Ablassmeier <abi@grinser.de>]

Package: lintian
Severity: wishlist
Tags: patch

hi,

i somehow managed to have a debian/substvars file in the Debian-Diff
(dont ask ;)).  Lintian did not complain about it, while policy says
those files must be removed by the clean target. Attached diff against
trunk makes Lintian check for substvars files in the Debian-Diff.

bye,
    - michael

Index: checks/debdiff.desc
===================================================================
--- checks/debdiff.desc	(revision 591)
+++ checks/debdiff.desc	(working copy)
@@ -24,6 +24,13 @@
  the reason is the location of the original source tarball. dpkg-source
  searches for this in ../package_upstream-version.orig.tar.gz.
 
+Tag: diff-contains-substvars
+Type: warning
+Info: Lintian found a substvars file in the Debian-diff for this source 
+ Package. The debian/substvars file is usually generated and modified
+ dynamically by debian/rules targets, and must be removed by the clean 
+ target.
+
 Tag: source-tar-is-posix-tar
 Type: error
 Info: The source tar archive of this package is made with tar --posix. This
Index: checks/debdiff
===================================================================
--- checks/debdiff	(revision 591)
+++ checks/debdiff	(working copy)
@@ -50,6 +50,9 @@
     $file = $1;
     tag_warn("patch-failure-file-in-diff", $file)
 	if ($file =~ m/\.(orig|rej)$/);
+
+    tag_warn("diff-contains-substvars", $file)
+	if ($file =~  m/substvars$/);
 }
 close(STAT) or fail("error reading diffstat file: $!");