lintian: r811 - trunk/depcheck

[jaalto@debian.org]

Author: jaalto
Date: 2007-01-30 15:34:49 +0100 (Tue, 30 Jan 2007)
New Revision: 811

Modified:
   trunk/depcheck/deppages.pl
Log:
* depcheck/deppages.pl:
  + [JA]  perl -Istrict -cw corrections.

  Possible unintended interpolation of @logfiles in string at ./depcheck/deppages.pl line 32.
  Global symbol "@archs" requires explicit package name at ./depcheck/deppages.pl line 29.
  Global symbol "$arch" requires explicit package name at ./depcheck/deppages.pl line 47.
  Global symbol "$arch" requires explicit package name at ./depcheck/deppages.pl line 48.
  Global symbol "$arch" requires explicit package name at ./depcheck/deppages.pl line 50.
  Global symbol "$arch" requires explicit package name at ./depcheck/deppages.pl line 50.
  Global symbol "$arch" requires explicit package name at ./depcheck/deppages.pl line 51.
  Global symbol "%bug_used" requires explicit package name at ./depcheck/deppages.pl line 54.
  Global symbol "%bugs" requires explicit package name at ./depcheck/deppages.pl line 55.
  Global symbol "$bugline" requires explicit package name at ./depcheck/deppages.pl line 60.
  Global symbol "@b" requires explicit package name at ./depcheck/deppages.pl line 61.
  Global symbol "$bugline" requires explicit package name at ./depcheck/deppages.pl line 62.
  Global symbol "@b" requires explicit package name at ./depcheck/deppages.pl line 63.
  Global symbol "%bugs" requires explicit package name at ./depcheck/deppages.pl line 65.
  Global symbol "$bugline" requires explicit package name at ./depcheck/deppages.pl line 65.
  Global symbol "@b" requires explicit package name at ./depcheck/deppages.pl line 65.
  Global symbol "$arch" requires explicit package name at ./depcheck/deppages.pl line 104.
  Global symbol "$arch" requires explicit package name at ./depcheck/deppages.pl line 105.
  Global symbol "$bug" requires explicit package name at ./depcheck/deppages.pl line 110.
  Global symbol "%bugs" requires explicit package name at ./depcheck/deppages.pl line 110.
  Global symbol "%bug_used" requires explicit package name at ./depcheck/deppages.pl line 111.
  Global symbol "$bug" requires explicit package name at ./depcheck/deppages.pl line 111.
  Global symbol "$bug" requires explicit package name at ./depcheck/deppages.pl line 112.
  Global symbol "%bugs" requires explicit package name at ./depcheck/deppages.pl line 149.
  Global symbol "%bug_used" requires explicit package name at ./depcheck/deppages.pl line 151.
  Global symbol "$DEPCHECK" requires explicit package name at ./depcheck/deppages.pl line 44.
  Global symbol "$BINARY" requires explicit package name at ./depcheck/deppages.pl line 44.
  Global symbol "$LOG_DIR" requires explicit package name at ./depcheck/deppages.pl line 44.
  Global symbol "$DEPCHECK" requires explicit package name at ./depcheck/deppages.pl line 50.
  Global symbol "$BINARY" requires explicit package name at ./depcheck/deppages.pl line 50.
  Global symbol "$LOG_DIR" requires explicit package name at ./depcheck/deppages.pl line 50.
  Global symbol "$LOG_DIR" requires explicit package name at ./depcheck/deppages.pl line 50.
  Global symbol "$LINTIAN_ROOT" requires explicit package name at ./depcheck/deppages.pl line 57.
  Global symbol "$BINARY" requires explicit package name at ./depcheck/deppages.pl line 126.
  Global symbol "$LOG_DIR" requires explicit package name at ./depcheck/deppages.pl line 135.



Modified: trunk/depcheck/deppages.pl
===================================================================
--- trunk/depcheck/deppages.pl	2007-01-30 13:39:13 UTC (rev 810)
+++ trunk/depcheck/deppages.pl	2007-01-30 14:34:49 UTC (rev 811)
@@ -23,42 +23,45 @@
 
 require './config';
 
+# comes from './config'
+use vars qw( $LOG_DIR );
+
 # lintian binary will define these
-use vars qw( $LINTIAN_DIST $HTML_TMP_DIR $LINTIAN_ARCHIVEDIR);
+use vars qw($LINTIAN_DIST $HTML_TMP_DIR $LINTIAN_ARCHIVEDIR $LINTIAN_ROOT);
 
-@archs = ('i386', 'alpha', 'm68k', 'powerpc', 'sparc', 'arm', 'hurd-i386');
+my @archs = ('i386', 'alpha', 'm68k', 'powerpc', 'sparc', 'arm', 'hurd-i386');
 
-@logfiles = map { "$LOG_DIR/Depcheck-" . $_ } @archs;
+my @logfiles = map { "$LOG_DIR/Depcheck-" . $_ } @archs;
 system("savelog @logfiles >/dev/null") == 0
     or die("cannot rotate logfiles");
 
 # this stuff is most likely broken
-$BINARY = "$LINTIAN_ARCHIVEDIR/dists/$LINTIAN_DIST/main";
+my $BINARY = "$LINTIAN_ARCHIVEDIR/dists/$LINTIAN_DIST/main";
 
 my $libdir   = defined $LINTIAN_ROOT ? "$LINTIAN_ROOT/" : "";
-$DEPCHECKDIR = "${libdir}depcheck";
-$DEPCHECK    = "$DEPCHECKDIR/dependencies.py";
+my $DEPCHECKDIR = "${libdir}depcheck";
+my $DEPCHECK    = "$DEPCHECKDIR/dependencies.py";
 
 $ENV{'PYTHONPATH'} = $DEPCHECKDIR;
 
 system("$DEPCHECK $BINARY/binary-i386/Packages >$LOG_DIR/Depcheck-i386") == 0
     or die("depcheck failed for i386 architecture");
 
-for $arch (@archs) {
+for my $arch (@archs) {
     next if $arch eq 'i386';
 
     system("$DEPCHECK $BINARY/binary-$arch/Packages $LOG_DIR/Depcheck-i386 >$LOG_DIR/Depcheck-$arch") == 0
 	or die("depcheck failed for $arch architecture");
 }
 
-%bug_used = ();
-%bugs = ();
+my %bug_used = ();
+my %bugs = ();
 
 open(BUGS, "$LINTIAN_ROOT/depcheck/buglist") or die("buglist");
 while (<BUGS>) {
     chop;
-    $bugline = $_;
-    @b = ();
+    my $bugline = $_;
+    my @b;
     while ($bugline =~ s/^(\d+)\s//) {
 	push(@b, &make_bugref($1));
     }
@@ -101,13 +104,13 @@
 all cases.<P>
 EOT
 
-for $arch (@archs) {
+for my $arch (@archs) {
     genarch($arch);
 }
 
 close(HTML);
 
-for $bug (keys %bugs) {
+for my $bug (keys %bugs) {
     unless ($bug_used{$bug}) {
 	print STDERR "Unused bugnumber: $bug\n";
     }