[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#409109: lintian: Add E: to check debian/control::Architecture matches dh_* rules in debian/rules::binary-{arch, indep}



merge 409109 119097
thanks

Jari Aalto <jari.aalto@cante.net> writes:

> Package: lintian
> Version: 1.23.27
> Severity: wishlist

> CASE STUDY

>   debian/control:

>    	Package: foo
>    	Architecture: all

>   debian/rules

> 	# Build architecture-dependent files here.
> 	binary-arch: build install
> 		dh_testdir
> 		dh_testroot
> 		dh_installchangelogs

> DESCRIPTION

> There is clear mistake here. The package does not depend in
> architecture, so the rules files shuld have all dh_* calls listed in
> binary-indep:.

> This can easily happend when using dh_make to package interpreted
> programs, like Python, Perl, Ryby etc.

Duplicate of #119097.

> SUGGESTION

> Please treat incorrect debain/rules in respect to
> debian/control::Architecture as an error (E:).

Yup, this is a good idea.  You have to ignore some debian/rules files to
avoid false positives, but the basic idea is sound.  I've thought about
implementing this a few times but haven't gotten around to it.

This is one of the checks I had in mind when I started the new
checks/rules file.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>



Reply to: