lintian: r829 - in trunk: checks debian testset testset/diffs/debian
Author: rra
Date: 2007-02-27 09:47:12 +0100 (Tue, 27 Feb 2007)
New Revision: 829
Modified:
trunk/checks/changelog-file
trunk/checks/changelog-file.desc
trunk/debian/changelog
trunk/testset/diffs/debian/changelog
trunk/testset/tags.diffs
Log:
* checks/changelog-file{.desc,}:
+ [RA] Check for bug closers without a colon after closes, but only if
there are at least six digits in the bug number and no non-digits.
Suggestion from Jari Aalto. (Closes: #373918)
Modified: trunk/checks/changelog-file
===================================================================
--- trunk/checks/changelog-file 2007-02-27 08:29:35 UTC (rev 828)
+++ trunk/checks/changelog-file 2007-02-27 08:47:12 UTC (rev 829)
@@ -280,6 +280,10 @@
tag "wrong-bug-number-in-closes", "l$.:$1" if $2;
}
+ if (/(closes\s*(?:bug)?\#?\s?\d{6,})[^\w]/i) {
+ tag "possible-missing-colon-in-closes", "l$.:$1" if $1;
+ }
+
if (/^(.*)Local\ variables:(.*)$/i) {
$prefix = $1;
$suffix = $2;
Modified: trunk/checks/changelog-file.desc
===================================================================
--- trunk/checks/changelog-file.desc 2007-02-27 08:29:35 UTC (rev 828)
+++ trunk/checks/changelog-file.desc 2007-02-27 08:47:12 UTC (rev 829)
@@ -145,3 +145,10 @@
Type: warning
Info: Bug numbers can only contain digits.
Ref: policy 4.4
+
+Tag: possible-missing-colon-in-closes
+Type: warning
+Info: To close a bug in the Debian changelog, the word "closes" must be
+ followed by a colon. This entry looked like it was intended to close a
+ bug, but there's no colon after "closes".
+Ref: policy 4.4
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2007-02-27 08:29:35 UTC (rev 828)
+++ trunk/debian/changelog 2007-02-27 08:47:12 UTC (rev 829)
@@ -1,5 +1,9 @@
lintian (1.23.28) UNRELEASED; urgency=low
+ * checks/changelog-file{.desc,}:
+ + [RA] Check for bug closers without a colon after closes, but only if
+ there are at least six digits in the bug number and no non-digits.
+ Suggestion from Jari Aalto. (Closes: #373918)
* checks/copyright-file{.desc,}:
+ [JA] Update usr-doc-* test to report user-share-doc-* instead.
New tests added: postinst-should-not-set-usr-doc-link,
Modified: trunk/testset/diffs/debian/changelog
===================================================================
--- trunk/testset/diffs/debian/changelog 2007-02-27 08:29:35 UTC (rev 828)
+++ trunk/testset/diffs/debian/changelog 2007-02-27 08:47:12 UTC (rev 829)
@@ -7,5 +7,9 @@
(Closes: #123nnn)
(Closes: #1, #foo)
(Closes: #1, Bug#2, #bar)
+ (Closes 1 bug)
+ (Closes 456712)
+ (Closes Bug# 123893)
+ (Closes #1239124)
-- Lintian Maintainers <lintian-maint@debian.org> Wed, 27 Nov 2002 14:15:00 +0100
Modified: trunk/testset/tags.diffs
===================================================================
--- trunk/testset/tags.diffs 2007-02-27 08:29:35 UTC (rev 828)
+++ trunk/testset/tags.diffs 2007-02-27 08:47:12 UTC (rev 829)
@@ -16,6 +16,9 @@
W: diffs source: diff-contains-substvars debian/substvars
W: diffs source: out-of-date-standards-version 3.5.9 (current is 3.7.2)
W: diffs: binary-without-manpage diffs
+W: diffs: possible-missing-colon-in-closes l11:Closes 456712
+W: diffs: possible-missing-colon-in-closes l12:Closes Bug# 123893
+W: diffs: possible-missing-colon-in-closes l13:Closes #1239124
W: diffs: wrong-bug-number-in-closes l6:#nnnnnn
W: diffs: wrong-bug-number-in-closes l7:#123nnn
W: diffs: wrong-bug-number-in-closes l8:#foo
Reply to: