[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#573399: lintian: Please check for Package-Type



Package: lintian
Version: 2.3.3
Severity: wishlist
Tags: patch

Hi,

following the instructions given by Frans in [1], I've written a tiny
check to ensure I wasn't missing any occurrences in the bunch of udebs
I'm currently adding. I guess it would be better to check what happens
in the resulting binaries, but I wanted to be aware of such issues
*before* even building those packages; that's why I implemented it so
that it checks the source control file. Hopefully, you'll get the idea
and either move it entirely, or only “duplicate” it for the binary
packages.

 1. http://lists.debian.org/debian-boot/2010/02/msg00524.html

Thanks for considering.

Mraw,
KiBi.
>From 6ce3c56971cba067267d7bec96e4114babf20e94 Mon Sep 17 00:00:00 2001
From: Cyril Brulebois <kibi@debian.org>
Date: Wed, 10 Mar 2010 21:28:35 +0100
Subject: [PATCH] Detect Package-Type in debian/control.

---
 checks/control-file      |    3 +++
 checks/control-file.desc |    8 ++++++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/checks/control-file b/checks/control-file
index 66b34a7..930b1b3 100644
--- a/checks/control-file
+++ b/checks/control-file
@@ -71,6 +71,9 @@ while (<CONTROL>) {
 			tag "xs-vcs-header-in-debian-control", "$field"
 			    if $known_source_fields{$base};
 		}
+		if ($field eq 'package-type') {
+			tag "package-type-in-debian-control", "line $.";
+		}
 		unless (/^\S+: \S/ || /^\S+:$/) {
 			tag 'debian-control-has-unusual-field-spacing', "line $.";
 		}
diff --git a/checks/control-file.desc b/checks/control-file.desc
index 234cc98..b9abdee 100644
--- a/checks/control-file.desc
+++ b/checks/control-file.desc
@@ -87,6 +87,14 @@ Info: There is an XS-Vcs-* field in the <tt>debian/control</tt> file.  As
  recognizes these headers and handles them correctly.  Consider removing
  the XS- prefix for this field.
 
+Tag: package-type-in-debian-control
+Severity: important
+Certainty: certain
+Info: There is a Package-Type field in the <tt>debian/control</tt>
+ file.  This field is only relevant to the build process and should
+ not be embedded in the resulting binary package.  As a consequence,
+ XC-Package-Type should be used instead.
+
 Tag: stronger-dependency-implies-weaker
 Severity: normal
 Certainty: certain
-- 
1.7.0


Reply to: