Re: .changes files as first-class objects
On Tue, 2010-03-23 at 23:38 -0700, Russ Allbery wrote:
> "Adam D. Barratt" <adam@adam-barratt.org.uk> writes:
>
> > As a recent post reminded me that I hadn't done so yet, I've rebased the
> > changes against current master and uploaded a new version to the URL
> > above.
>
> > The new version includes the changes we discussed back in January,
> > together with the security-relevant fixes I could see and a couple of
> > other issues I spotted at the same time; please yell if I missed
> > anything, particularly on the security front.
>
> This generally looks great. Some minor things (abbreviated to just
> relevant context):
>
> --- a/t/tests/distribution-multiple-bad/tags
> +++ b/t/tests/distribution-multiple-bad/tags
> @@ -1,4 +1,4 @@
> -E: distribution-multiple-bad_1.0_arch.changes:
> +E: distribution-multiple-bad_1.0_amd64 changes:
>
> The formatting change broke the post-tag munging to replace the local
> architecture with "arch".
[and some further instances]
Oops. I'd made a mental note to fix those, but obviously forgot to do
so in the end.
> With those fixes, I think it's ready to commit.
Thanks for the review.
I'll make the fixes you mentioned and look at getting the changes
committed.
Adam
Reply to: